Re: Crypto: Add support for 192 & 256 bit keys to AESNI RFC4106 - resubmission

2015-01-11 Thread Herbert Xu
On Sun, Jan 11, 2015 at 11:48:08PM -0500, Timothy McCaffrey wrote: > > This patch has been tested with Sandy Bridge and Haswell processors. With 128 > bit keys and input buffers > 512 bytes a slight performance degradation was > noticed (~1%). For input buffers of less than 512 bytes there was no

Crypto: Add support for 192 & 256 bit keys to AESNI RFC4106 - resubmission

2015-01-11 Thread Timothy McCaffrey
These patches fix the RFC4106 implementation in the aesni-intel module so it supports 192 & 256 bit keys. Since the AVX support that was added to this module also only supports 128 bit keys, and this patch only affects the SSE implementation, changes were also made to use the SSE version if key s

Re: [PATCH 5/6] crypto: sparc64/md5 - fix module description

2015-01-11 Thread David Miller
From: Mathias Krause Date: Sun, 11 Jan 2015 18:17:46 +0100 > MD5 is not SHA1. > > Cc: David S. Miller > Signed-off-by: Mathias Krause Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org Mor

Re: [PATCH 4/6] crypto: sparc64/des - add "des3_ede" module alias

2015-01-11 Thread David Miller
From: Mathias Krause Date: Sun, 11 Jan 2015 18:17:45 +0100 > This module provides implementations for "des3_ede", too. Announce those > via an appropriate crypto module alias so it can be used in favour to > the generic C implementation. > > Cc: David S. Miller > Signed-off-by: Mathias Krause

Re: [PATCH 2/6] crypto: sparc64/aes - fix module description

2015-01-11 Thread David Miller
From: Mathias Krause Date: Sun, 11 Jan 2015 18:17:43 +0100 > AES is a block cipher, not a hash. > > Cc: David S. Miller > Signed-off-by: Mathias Krause Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@v

Re: [PATCH 3/6] crypto: sparc64/camellia - fix module alias

2015-01-11 Thread David Miller
From: Mathias Krause Date: Sun, 11 Jan 2015 18:17:44 +0100 > The module alias should be "camellia", not "aes". > > Cc: David S. Miller > Signed-off-by: Mathias Krause Acked-by: David S. Miller -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message

[PATCH 5/6] crypto: sparc64/md5 - fix module description

2015-01-11 Thread Mathias Krause
MD5 is not SHA1. Cc: David S. Miller Signed-off-by: Mathias Krause --- arch/sparc/crypto/md5_glue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/crypto/md5_glue.c b/arch/sparc/crypto/md5_glue.c index 64c7ff5f72a9..b688731d7ede 100644 --- a/arch/sparc/crypto/

[PATCH 6/6] crypto: x86/des3_ede - drop bogus module aliases

2015-01-11 Thread Mathias Krause
This module implements variations of "des3_ede" only. Drop the bogus module aliases for "des". Cc: Jussi Kivilinna Signed-off-by: Mathias Krause --- arch/x86/crypto/des3_ede_glue.c |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/x86/crypto/des3_ede_glue.c b/arch/x86/crypto/des3_ede

[PATCH 1/6] crypto: add missing crypto module aliases

2015-01-11 Thread Mathias Krause
Commit 5d26a105b5a7 ("crypto: prefix module autoloading with "crypto-"") changed the automatic module loading when requesting crypto algorithms to prefix all module requests with "crypto-". This requires all crypto modules to have a crypto specific module alias even if their file name would otherwi

[PATCH 0/6] crypto: module alias fixes

2015-01-11 Thread Mathias Krause
Hi Herbert, this series is a follow up to commit 5d26a105b5a7 ("crypto: prefix module autoloading with "crypto-""). In patch 1 it adds the required MODULE_ALIAS_CRYPTO annotation where needed to bring back automatic crypto module loading. Namely, modules that have a file name matching the cipher t

[PATCH 4/6] crypto: sparc64/des - add "des3_ede" module alias

2015-01-11 Thread Mathias Krause
This module provides implementations for "des3_ede", too. Announce those via an appropriate crypto module alias so it can be used in favour to the generic C implementation. Cc: David S. Miller Signed-off-by: Mathias Krause --- arch/sparc/crypto/des_glue.c |1 + 1 file changed, 1 insertion(+

[PATCH 2/6] crypto: sparc64/aes - fix module description

2015-01-11 Thread Mathias Krause
AES is a block cipher, not a hash. Cc: David S. Miller Signed-off-by: Mathias Krause --- arch/sparc/crypto/aes_glue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/crypto/aes_glue.c b/arch/sparc/crypto/aes_glue.c index 705408766ab0..2e48eb8813ff 100644 --- a/

[PATCH 3/6] crypto: sparc64/camellia - fix module alias

2015-01-11 Thread Mathias Krause
The module alias should be "camellia", not "aes". Cc: David S. Miller Signed-off-by: Mathias Krause --- arch/sparc/crypto/camellia_glue.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sparc/crypto/camellia_glue.c b/arch/sparc/crypto/camellia_glue.c index 641f55cb6

Re: [PATCH v9 1/2] crypto: AF_ALG: add AEAD support

2015-01-11 Thread Stephan Mueller
Am Sonntag, 11. Januar 2015, 04:45:53 schrieb Stephan Mueller: Hi Herbert, > +static int aead_accept_parent(void *private, struct sock *sk) > +{ > + struct aead_ctx *ctx; > + struct alg_sock *ask = alg_sk(sk); > + unsigned int len = sizeof(*ctx) + crypto_aead_reqsize(private); > +