Re: Crypto Fixes for 4.2

2015-06-27 Thread Herbert Xu
On Fri, Jun 26, 2015 at 01:07:02PM -0700, Linus Torvalds wrote: On Fri, Jun 26, 2015 at 3:22 AM, Herbert Xu herb...@gondor.apana.org.au wrote: * Kill testmgr warning for gcm-aes-aesni. Hmm. You killed one of the warnings, but the setkey one remains. alg: aead: setkey failed on

Re: [PATCH] QAT: Fix uninitialized variable in qat driver

2015-06-27 Thread Tadeusz Struk
On 06/26/2015 10:56 AM, Neil Horman wrote: Hit a warning when building QAT, indicating that sz_out might be uninitalized before use. Looks like if you hit an error path and jump to err: you might find yourself trying to unmap an arbirarily long dma region. Its safe on intel since intel

Re: Crypto Fixes for 4.2

2015-06-27 Thread Linus Torvalds
On Fri, Jun 26, 2015 at 11:56 PM, Herbert Xu herb...@gondor.apana.org.au wrote: So I think Tadeusz's patch is the simplest fix for 4.2. Could you please test it to see if it makes your warning go away? Seems to silence it here. I get the feeling that the patch is still wrong - why are not

Re: akcipher use

2015-06-27 Thread Stephan Mueller
Am Donnerstag, 25. Juni 2015, 12:19:32 schrieb Tadeusz Struk: Hi Tadeusz, On 06/25/2015 04:58 AM, Stephan Mueller wrote: - how would a hardware implementation offering only a hybrid asym cipher implementation (i.e. a full signature mechanism or bulk data encryption mechanism) be

Re: akcipher use

2015-06-27 Thread Tadeusz Struk
Hi Stephan, On 06/27/2015 09:25 AM, Stephan Mueller wrote: Ok, in this case, it would mean that rsa would point to the software implementation and oaep(rsa) would point to the hardware. Would I be correct? All combinations are possible, and it is up to the implementation to decide. Yes,