On Tue, Aug 04, 2015 at 09:33:27PM -0700, Marcel Holtmann wrote:
>
> I think it actually is the correct interface. And it will still stay a purely
> algorithmic interface. It is just that the algorithm is bound to specific
> hardware with a specific key. I really do not understand your distinctio
Hi Herbert,
>> We already have an interface that can handle asymmetric keys and it is easy
>> to extend with new key formats and key types. So lets use that. I can
>> clearly see that after RSA, we get DSA, ECDH etc. So having a simple way to
>> handle these key formats is a good idea. That inf
On Tue, Aug 04, 2015 at 09:02:36PM -0700, Marcel Holtmann wrote:
>
> We already have an interface that can handle asymmetric keys and it is easy
> to extend with new key formats and key types. So lets use that. I can clearly
> see that after RSA, we get DSA, ECDH etc. So having a simple way to ha
Hi Herbert,
>> RSA Private Key is n + e + d (including 6 other fields). RSA Public Key is n
>> + e (no other fields).
>>
>> So for RSA you would make setkey to take RSA Private Key and setpubkey to
>> take RSA Public Key. Meaning you only have to use one of them since if you
>> have the privat
On Mon, Aug 03, 2015 at 12:25:31AM -0700, Marcel Holtmann wrote:
>
> RSA Private Key is n + e + d (including 6 other fields). RSA Public Key is n
> + e (no other fields).
>
> So for RSA you would make setkey to take RSA Private Key and setpubkey to
> take RSA Public Key. Meaning you only have t
On Tue, Aug 04, 2015 at 09:43:50AM -0500, Aaron Sierra wrote:
>
> You are correct about the leak and I regret introducing that (I am
> also leaking priv->rng), but I disagree with your dismissal of the
> rest of the changes as unrelated to the changelog.
I understand the problem, but your change
On 6/15/2015 8:18 PM, Russell King - ARM Linux wrote:
> On Mon, Jun 15, 2015 at 06:33:17PM +0200, Jon Nettleton wrote:
>> Funny enough I tackled this problem over the weekend as well. My
>> approach was to switch the driver over to use the *_relaxed() io
>> functions and then special case the bits
- Original Message -
> From: "Herbert Xu"
> Sent: Tuesday, August 4, 2015 2:18:05 AM
>
> On Fri, Jul 31, 2015 at 03:52:18PM -0500, Aaron Sierra wrote:
> >
> > @@ -2905,8 +2919,7 @@ static int talitos_probe(struct platform_device
> > *ofdev)
> > priv->reg = of_iomap(np, 0);
> > if
On 08/04/2015 06:44 AM, Herbert Xu wrote:
> On Tue, Aug 04, 2015 at 06:42:04AM -0700, Tadeusz Struk wrote:
>> > On 08/04/2015 06:32 AM, Herbert Xu wrote:
>>> > > What if someone calls adf_remove? For a software implementation
>>> > > you can prevent the algorithm from going away by holding module
>
On Tue, Aug 04, 2015 at 06:42:04AM -0700, Tadeusz Struk wrote:
> On 08/04/2015 06:32 AM, Herbert Xu wrote:
> > What if someone calls adf_remove? For a software implementation
> > you can prevent the algorithm from going away by holding module
> > reference counts. But a device can always be remove
On 08/04/2015 06:32 AM, Herbert Xu wrote:
> What if someone calls adf_remove? For a software implementation
> you can prevent the algorithm from going away by holding module
> reference counts. But a device can always be removed and you're
> not going to stop that no matter how many reference coun
On 08/04/2015 02:59 AM, Herbert Xu wrote:
> Good catch. However it's not as simple as that. We have a bigger
> problem here.
>
> For software implementations it's really easy because we use the
> module reference count to prevent unregisters from happening while
> there are tfms using it.
>
> H
On Tue, Aug 04, 2015 at 06:26:58AM -0700, Tadeusz Struk wrote:
>
> The way we handle it in qat is as follows - when tfm allocates a
> crypto "instance" on a qat dev it then calls qat_crypto_put_instance(),
> which calls also adf_dev_put() on the appropriate qat device.
> This then calls module_put(
On 08/04/2015 05:47 AM, Herbert Xu wrote:
> In order to make progress I'm going to fold your patch into my
> series and push it into cryptodev.
>
> I'll try to come up with a proper fix for this after I'm done
> with the AEAD stuff.
Thanks. Also thanks for converting this. It looks much cleaner n
On Tue, Aug 04, 2015 at 09:20:03PM +0800, kbuild test robot wrote:
> tree:
> git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
> head: a4198fd4b487afc60810f5a12b994721df220022
> commit: 92d95ba91772279b6ef9c6e09661f67abcf27259 [91/97] crypto: authenc -
> Convert t
tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
master
head: a4198fd4b487afc60810f5a12b994721df220022
commit: 92d95ba91772279b6ef9c6e09661f67abcf27259 [91/97] crypto: authenc -
Convert to new AEAD interface
config: i386-randconfig-i0-201531 (attached as .config)
On Tue, Aug 04, 2015 at 05:59:09PM +0800, Herbert Xu wrote:
> On Mon, Aug 03, 2015 at 10:01:02AM -0700, Tadeusz Struk wrote:
> >
> > There is one problem that I missed before.
> > We can shutdown a qat device and bring it back up via ioct.
> > Before we shut the last device we also unregister the a
On Mon, Aug 03, 2015 at 10:01:02AM -0700, Tadeusz Struk wrote:
>
> There is one problem that I missed before.
> We can shutdown a qat device and bring it back up via ioct.
> Before we shut the last device we also unregister the algorithms.
> Then we can bring them up again, but it fails without res
On Mon, Aug 03, 2015 at 12:05:03AM +0100, Colin King wrote:
> From: Colin Ian King
>
> Trival change, fix spelling mistake 'aquire' -> 'acquire' in
> dev_err message.
>
> Signed-off-by: Colin Ian King
Applied.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http
On Mon, Aug 03, 2015 at 06:56:21PM -0500, Aaron Sierra wrote:
> Compiling the talitos driver with my GCC 4.3.1 e500v2 cross-compiler
> resulted in a failed build due to the anonymous union/structures
> introduced in this commit:
>
> crypto: talitos - enhanced talitos_desc struct for SEC1
>
> Th
On Mon, Aug 03, 2015 at 09:08:05AM +0200, Stephan Mueller wrote:
> The AEAD API changes are now reflected in the crypto API doc book.
>
> Signed-off-by: Stephan Mueller
Applied.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pu
On Fri, Jul 31, 2015 at 03:52:18PM -0500, Aaron Sierra wrote:
>
> @@ -2905,8 +2919,7 @@ static int talitos_probe(struct platform_device *ofdev)
> priv->reg = of_iomap(np, 0);
> if (!priv->reg) {
> dev_err(dev, "failed to of_iomap\n");
> - err = -ENOMEM;
> -
22 matches
Mail list logo
