Re: Issues with HW RNG / SSS on Exynos 5422

2015-08-17 Thread Krzysztof Kozlowski
On 18.08.2015 15:02, Heiner Kallweit wrote: > Am 17.08.2015 um 08:30 schrieb Krzysztof Kozlowski: >> On 17.08.2015 15:10, Heiner Kallweit wrote: >>> Am 17.08.2015 um 02:19 schrieb Krzysztof Kozlowski: 2015-08-16 20:18 GMT+09:00 Heiner Kallweit : > Am 15.08.2015 um 13:19 schrieb Heiner Kall

[PATCH] crypto: sahara: Use dmam_alloc_coherent

2015-08-17 Thread Vaishali Thakkar
This patch moves the data allocated using dma_alloc_coherent to the corresponding managed interface. To be compatible with the change, various gotos are replaced with direct returns and unneeded labels are dropped. Signed-off-by: Vaishali Thakkar --- drivers/crypto/sahara.c | 46 +---

Re: Issues with HW RNG / SSS on Exynos 5422

2015-08-17 Thread Heiner Kallweit
Am 17.08.2015 um 08:30 schrieb Krzysztof Kozlowski: > On 17.08.2015 15:10, Heiner Kallweit wrote: >> Am 17.08.2015 um 02:19 schrieb Krzysztof Kozlowski: >>> 2015-08-16 20:18 GMT+09:00 Heiner Kallweit : Am 15.08.2015 um 13:19 schrieb Heiner Kallweit: > I'm having issues making the hardware

Re: [PATCH 1/2] Fixing vmx-crypto AES-CTR counter bug

2015-08-17 Thread Herbert Xu
On Fri, Aug 14, 2015 at 10:12:22AM -0300, Leonidas S Barbosa wrote: > AES-CTR is using a counter 8bytes-8bytes what miss match with > kernel specs. > > In the previous code a vadduwm was done to increment counter. > Replacing this for a vadduqm now considering both cases counter > 8-8 bytes and fu

Re: [PATCH] crypto: caam - add support for LS1021A

2015-08-17 Thread Herbert Xu
On Mon, Aug 17, 2015 at 03:24:10PM +0300, Horia Geantă wrote: > LS1021A is a QorIQ SoC having little endian CAAM. > > There are a few differences b/w QorIQ and i.MX from CAAM perspective: > > 1. i.MX platforms are somewhat special wrt. 64-bit registers: > -big endian format at 64-bit level: MSW a

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

2015-08-17 Thread Herbert Xu
On Mon, Aug 17, 2015 at 06:05:04PM -0700, Tadeusz Struk wrote: > On 08/17/2015 01:50 AM, Herbert Xu wrote: > >> If you don't like the first option then we still need this, as you pointed > >> out. > > Yes this looks like the right fix for qat. Please add a sign-off. > > You might be able to just

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

2015-08-17 Thread Tadeusz Struk
On 08/17/2015 01:50 AM, Herbert Xu wrote: >> If you don't like the first option then we still need this, as you pointed >> out. > Yes this looks like the right fix for qat. Please add a sign-off. > You might be able to just do it by replying to this thread, and > patchwork may be able to pick it

Re: [cryptodev:master 144/149] DockBook: Warning(include/crypto/aead.h): no structured comments found

2015-08-17 Thread Stephan Mueller
Am Montag, 17. August 2015, 21:14:27 schrieb kbuild test robot: Hi, thanks for the report. >tree: >git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git >master head: dd43c4e92fbb135dcbf02845578db60be56a453a >commit: b0d955ba4688fcba8112884931aea1f1e6f50f03 [144/149] crypto

[cryptodev:master 144/149] DockBook: Warning(include/crypto/aead.h): no structured comments found

2015-08-17 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: dd43c4e92fbb135dcbf02845578db60be56a453a commit: b0d955ba4688fcba8112884931aea1f1e6f50f03 [144/149] crypto: aead - Remove old AEAD interfaces reproduce: make htmldocs All warnings (new ones prefixed by

[cryptodev:master 147/148] gcm.c:undefined reference to `crypto_put_default_null_skcipher'

2015-08-17 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 9129c26da1711aba1e6295c28de8814301869732 commit: a26bcb04861db3061bb7db11ce905aa037111f81 [147/148] crypto: null - Use NULL2 in Makefile config: i386-randconfig-i1-201533 (attached as .config) reproduce

Re: crypto/Konfig

2015-08-17 Thread Herbert Xu
On Mon, Aug 17, 2015 at 02:34:05PM +0200, Stephan Mueller wrote: > Hi Herbert, > > something seems to be missing in the latest Kconfig file. > > Shall there be a tristate added? You're quite Stephan. Thanks, ---8<--- Subject: crypto: null - Add missing Kconfig tristate for NULL2 This patch ad

crypto/Konfig

2015-08-17 Thread Stephan Mueller
Hi Herbert, something seems to be missing in the latest Kconfig file. Shall there be a tristate added? $ make menuconfig scripts/kconfig/mconf Kconfig crypto/Kconfig:159:warning: config symbol defined without type crypto/Kconfig:160:warning: config symbol 'CRYPTO_NULL2' uses select, but is not

[PATCH] crypto: caam - add support for LS1021A

2015-08-17 Thread Horia Geantă
LS1021A is a QorIQ SoC having little endian CAAM. There are a few differences b/w QorIQ and i.MX from CAAM perspective: 1. i.MX platforms are somewhat special wrt. 64-bit registers: -big endian format at 64-bit level: MSW at address+0 and LSW at address+4 -little endian format at 32-bit level (wi

Re: [cryptodev:master 144/146] drivers/crypto/nx/nx.h:153:39: warning: 'struct crypto_aead' declared inside parameter list

2015-08-17 Thread Herbert Xu
On Mon, Aug 17, 2015 at 05:52:31PM +0800, kbuild test robot wrote: > tree: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master > head: 58268e58e63550e24dee7d6125078ab2a2a22272 > commit: b0d955ba4688fcba8112884931aea1f1e6f50f03 [144/146] crypto: aead - > Remove old

[cryptodev:master 144/146] drivers/crypto/nx/nx.h:153:39: warning: 'struct crypto_aead' declared inside parameter list

2015-08-17 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 58268e58e63550e24dee7d6125078ab2a2a22272 commit: b0d955ba4688fcba8112884931aea1f1e6f50f03 [144/146] crypto: aead - Remove old AEAD interfaces config: powerpc-defconfig (attached as .config) reproduce:

Re: [cryptodev:master 139/146] crypto/aead.c:770: undefined reference to `crypto_get_default_null_skcipher'

2015-08-17 Thread Herbert Xu
On Mon, Aug 17, 2015 at 05:27:16PM +0800, kbuild test robot wrote: > tree: > git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master > head: 58268e58e63550e24dee7d6125078ab2a2a22272 > commit: 149a39717dcce3b6ba15285c9fc86e4423437e05 [139/146] crypto: aead - Add > type-s

[cryptodev:master 139/146] crypto/aead.c:770: undefined reference to `crypto_get_default_null_skcipher'

2015-08-17 Thread kbuild test robot
tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master head: 58268e58e63550e24dee7d6125078ab2a2a22272 commit: 149a39717dcce3b6ba15285c9fc86e4423437e05 [139/146] crypto: aead - Add type-safe geniv init/exit helpers config: microblaze-mmu_defconfig (attached as .co

Re: [PATCH v2] crypto: amcc: Do a NULL check for pointer

2015-08-17 Thread Herbert Xu
On Fri, Aug 14, 2015 at 12:09:29AM -0300, Fabio Estevam wrote: > From: Fabio Estevam > > Compare pointer-typed values to NULL rather than 0. > > The semantic patch that makes this change is available > in scripts/coccinelle/null/badzero.cocci > > Signed-off-by: Fabio Estevam Applied. -- Emai

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

2015-08-17 Thread Herbert Xu
On Fri, Aug 14, 2015 at 07:24:23AM -0700, Tadeusz Struk wrote: > > If you don't like the first option then we still need this, as you pointed > out. Yes this looks like the right fix for qat. Please add a sign-off. You might be able to just do it by replying to this thread, and patchwork may be

Re: [PATCH 2/2] crypto: qat - Don't move data inside output buffer

2015-08-17 Thread Herbert Xu
On Fri, Aug 14, 2015 at 07:21:29AM -0700, Tadeusz Struk wrote: > > Yes, that was wrong, sorry. The reason I wanted to change it is that > the SW implementation can return a number with leading zeros. > This is because mpi_read_buffer() returns the whole thing. I think mpi_read_buffer is broken.

Crypto Fixes for 4.2

2015-08-17 Thread Herbert Xu
Hi Linus: This push fixes the following issues: * A regression caused by the conversion of IPsec ESP to the new AEAD interface: ESN with authencesn no longer works because it relied on the AD input SG list having a specific layout which is no longer the case. In linux-next authencesn is fi