Re: hash import/export

2015-10-11 Thread Herbert Xu
On Sun, Oct 11, 2015 at 08:34:27PM +0100, Russell King - ARM Linux wrote: > > Is there any reason a driver can't define its own structure to be > exported here which can be shared between each of the different methods > it supports? For algorithms in general you can use any format you like and th

Re: hash import/export

2015-10-11 Thread Russell King - ARM Linux
On Sun, Oct 11, 2015 at 08:34:27PM +0100, Russell King - ARM Linux wrote: > Herbert, > > I wonder if you can clear something up about the hash export/import > functionality. In: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344120.html > > you seem to imply that the exporte

Re: hash import/export

2015-10-11 Thread Boris Brezillon
On Sun, 11 Oct 2015 20:34:27 +0100 Russell King - ARM Linux wrote: > Herbert, > > I wonder if you can clear something up about the hash export/import > functionality. In: > > http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344120.html > > you seem to imply that the exported and

hash import/export

2015-10-11 Thread Russell King - ARM Linux
Herbert, I wonder if you can clear something up about the hash export/import functionality. In: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-May/344120.html you seem to imply that the exported and imported state can't be defined by the driver. Boris tells me, "AFAIR, crypto users

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-11 Thread Daniel Thompson
On 5 October 2015 at 10:22, Daniel Thompson wrote: > On 4 October 2015 at 11:32, Linus Walleij wrote: >> On Sat, Oct 3, 2015 at 10:35 PM, Daniel Thompson >> wrote: >> Then this construct: >> >>> +static int stm32_rng_read(struct hwrng *rng, void *data, size_t max, bool >>> wait) >>> +{ >> (...)

Re: [PATCH 2/3] hwrng: stm32 - add support for STM32 HW RNG

2015-10-11 Thread Daniel Thompson
On 5 October 2015 at 10:22, Daniel Thompson wrote: > On 4 October 2015 at 11:32, Linus Walleij wrote: >> On Sat, Oct 3, 2015 at 10:35 PM, Daniel Thompson >> 3. I took out the datasheet for Nomadik STn8820 and it seems that >> the hardware is very similar to what this driver is trying to drive. >>

crypto: sun4i-ss: bug with cryptodev

2015-10-11 Thread Corentin LABBE
Hello I am working on some tools for checking the good working of crypto device (and benching them). One of the tool use cryptodev (http://cryptodev-linux.org/) for using the kernel crypto API (and so any hardware accelerated crypto). The tool compare the results of an AES cipher via cryptodev a

Re: [PATCH v3 1/5] crypto: ensure algif_hash does not pass a zero-sized state

2015-10-11 Thread Herbert Xu
On Sat, Oct 10, 2015 at 05:52:29PM +0100, Russell King - ARM Linux wrote: > > If you're using AF_ALG, and you attach to (say) the ARM Neon SHA512 > implementation through it, and then use accept() to duplicate it's > state, what prevents the kernel from oopsing when hash_accept() calls > crypto_aha