Re: [PATCH 7/7] Create generated/random_init.h, used by random driver

2015-11-08 Thread kbuild test robot
Hi Sandy, [auto build test ERROR on: char-misc/char-misc-testing] [also build test ERROR on: v4.3 next-20151106] url: https://github.com/0day-ci/linux/commits/Sandy-Harris/A-couple-of-generated-files/20151107-223540 config: mips-allyesconfig (attached as .config) reproduce: wget

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Christoph Biedl
Maxime Ripard wrote... > > > > This patch specifiy statesize for sha1 and md5. > > > > > > > > Signed-off-by: LABBE Corentin > > > > Cc: sta...@vger.kernel.org > > > > > > Please also add a Fixes tag (and the stable version it applies to). > > > > I don't see the

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-08 Thread Zain
Hi Heiko, Thanks for your serious comments always. On 2015年11月08日 07:19, Heiko Stuebner wrote: > Hi Zain, > > looks like my comment on v1 came later than your v2 submission, > so here it is again :-) > > Am Freitag, 6. November 2015, 09:17:21 schrieb Zain Wang: >> The names registered are: >>

Re: [PATCH v2 1/4] Crypto: Crypto driver support aes/des/des3 for rk3288

2015-11-08 Thread Zain
On 2015年11月07日 12:40, Sandy Harris wrote: > On Thu, Nov 5, 2015 at 8:17 PM, Zain Wang wrote: >> The names registered are: >> ecb(aes) cbc(aes) ecb(des) cbc(des) ecb(des3_ede) cbc(des3_ede) >> You can alloc tags above in your case. > Why on Earth are you allowing

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Herbert Xu
Christoph Biedl wrote: > > Fixes: should rather point to the commit that caused the breakage in my > opinion. Which did this by intention: Absolutely not. That patch is correct and if you revert that you will simply end up registering a broken driver into

Re: [PATCH] crypto: sun4i-ss: add missing statesize

2015-11-08 Thread Herbert Xu
On Mon, Nov 09, 2015 at 08:27:06AM +0100, LABBE Corentin wrote: > sun4i-ss implementaton of md5/sha1 is via ahash algorithms. > A recent change make impossible to load them without giving statesize. > This patch specifiy statesize for sha1 and md5. > > Fixes: 8996eafdcbad ("crypto: ahash - ensure