Re: [RFC PATCH 2/2] Crypto kernel tls socket

On (11/23/15 09:43), Dave Watson wrote: > Currently gcm(aes) represents ~80% of our SSL connections. > > Userspace interface: > > 1) A transform and op socket are created using the userspace crypto interface > 2) Setsockopt ALG_SET_AUTHSIZE is called > 3) Setsockopt ALG_SET_KEY is called twice,

Re: hwrng: Some concerns about add_hwgenerator_randomness

Am Sonntag, 22. November 2015, 02:15:12 schrieb Nick Kossifidis: Hi Nick, >Hello all, > >I've been doing some reading on hw_random core and the drivers that >use it and it seems that three of them use the quality parameter on >the hwrng struct. When a driver sets this value, it ends up directly

[PATCH] crypto: Docs blurb about templates.

Signed-off-by: Andrew Zaborowski --- These are some notes about the template structs that can take some head-scratching to figure out from the code. Please check that this is the current intended use. --- Documentation/crypto/api-intro.txt | 40

Re: [PATCH] crypto: atmel: fix 64-bit warnings

On Tue, Nov 17, 2015 at 10:22:06AM +0100, Arnd Bergmann wrote: > The atmel AES driver assumes that 'int' and 'size_t' are the same > type in multiple locations, which the compiler warns about when > building it for 64-bit systems: > > In file included from ../drivers/crypto/atmel-aes.c:17:0: >

Re: [PATCH 2/2] crypto: mcryptd - use list_first_entry_or_null()

On Mon, Nov 16, 2015 at 10:37:15PM +0800, Geliang Tang wrote: > Simplify mcryptd_opportunistic_flush() with list_first_entry_or_null(). > > Signed-off-by: Geliang Tang Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH v2] hw_random: omap3-rom-rng: convert timer to delayed work

On Wed, Nov 18, 2015 at 09:59:01PM +0200, Aaro Koskinen wrote: > We cannot put the HW RNG to idle using a timer because we cannot disable > clocks from atomic context. Use a delayed work instead. > > Fixes a warning with CONFIG_DEBUG_MUTEXES on Nokia N900 during boot. > > Reported-by: Sebastian

Re: [PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

On Tue, Nov 17, 2015 at 12:00:46PM +0800, Zain Wang wrote: > > +static void rk_ablk_hw_init(struct rk_crypto_info *dev) > +{ > + struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(dev->ablk_req); > + struct rk_cipher_ctx *ctx = crypto_ablkcipher_ctx(tfm); > + u32 conf_reg = 0; >

Re: [PATCH 1/2] crypto: api - use list_first_entry_or_null and list_next_entry

On Mon, Nov 16, 2015 at 10:37:14PM +0800, Geliang Tang wrote: > Simplify crypto_more_spawns() with list_first_entry_or_null() > and list_next_entry(). > > Signed-off-by: Geliang Tang Patch applied. Thanks. -- Email: Herbert Xu Home Page:

Re: [PATCH 1/1] crypto: tcrypt: fix keysize argument of test_aead_speed for gcm(aes)

On Tue, Nov 17, 2015 at 01:37:10PM +0100, Cyrille Pitchen wrote: > The key sizes used by AES in GCM mode should be 128, 192 or 256 bits (16, > 24 or 32 bytes). > There is no additional 4byte nonce as for RFC 4106. > > Signed-off-by: Cyrille Pitchen Patch applied.

Re: [PATCH v3] crypto: atmel: fix bogus select

On Wed, Nov 18, 2015 at 04:33:54PM +0100, Arnd Bergmann wrote: > >From 0d53d42a56e9a3769847fd03c703876f2c063fb4 Mon Sep 17 00:00:00 2001 > From: Arnd Bergmann > Date: Tue, 27 Jan 2015 22:34:04 +0100 > Subject: [PATCH] [SUBMITTED] crypto: atmel: fix bogus select > > The Atmel at91

Re: [PATCH 1/2] crypto: sahara: set nb_[in|out]_sg as signed int

On Thu, Nov 19, 2015 at 01:38:17PM +0100, LABBE Corentin wrote: > The two unsigned int variables nb_in_sg and nb_out_sg can be assigned > signed value (-EINVAL) from sg_nents_for_len(). > Furthermore they are used only by dma_map_sg and dma_unmap_sg which wait > for an signed int, so they must be

[PATCH] crypto: nx: use of_property_read_u32()

use of_propert_read_u32() for reading int value, it can help reducing number of variables used Signed-off-by: Saurabh Sengar --- drivers/crypto/nx/nx-842-powernv.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] crypto: nx: use of_property_read_u32()

On Mon, Nov 23, 2015 at 4:56 AM, Saurabh Sengar wrote: > use of_propert_read_u32() for reading int value, > it can help reducing number of variables used > > Signed-off-by: Saurabh Sengar Acked-by: Dan Streetman > --- >

Re: [RFC PATCH 2/2] Crypto kernel tls socket

On (11/23/15 13:43), Dave Watson wrote: > > For kcm, opfd is the fd you would pass along in kcm_attach. > For rds, it looks like you'd want to use opfd as the sock instead of > the new one created by sock_create_kern in rds_tcp_conn_connect. I see. It's something to consider, and it would

Re: [PATCH v4 2/4] clk: rockchip: set an ID for crypto clk

Hi Zain, Am Dienstag, 17. November 2015, 12:00:45 schrieb Zain Wang: > Set an ID for crypto clk, so that it can be called in other part. > > Signed-off-by: Zain Wang > Acked-by: Michael Turquette > Tested-by: Heiko Stuebner

Re: [PATCH v4 2/4] clk: rockchip: set an ID for crypto clk

On 2015年11月24日 07:24, Heiko Stübner wrote: > Hi Zain, > > Am Dienstag, 17. November 2015, 12:00:45 schrieb Zain Wang: >> Set an ID for crypto clk, so that it can be called in other part. >> >> Signed-off-by: Zain Wang >> Acked-by: Michael Turquette

Re: [PATCH v4 3/4] Crypto: rockchip/crypto - add crypto driver for rk3288

On 2015年11月23日 20:51, Herbert Xu wrote: > On Tue, Nov 17, 2015 at 12:00:46PM +0800, Zain Wang wrote: >> +static void rk_ablk_hw_init(struct rk_crypto_info *dev) >> +{ >> +struct crypto_ablkcipher *tfm = crypto_ablkcipher_reqtfm(dev->ablk_req); >> +struct rk_cipher_ctx *ctx =

[RFC PATCH 2/2] Crypto kernel tls socket

Userspace crypto interface for TLS. Currently supports gcm(aes) 128bit only, however the interface is the same as the rest of the SOCK_ALG interface, so it should be possible to add more without any user interface changes. Currently gcm(aes) represents ~80% of our SSL connections. Userspace

[RFC PATCH 0/2] Crypto kernel TLS socket

An approach for a kernel TLS socket. Only the symmetric encryption / decryption is done in-kernel, as well as minimal framing handling. The handshake is kept in userspace, and the negotiated cipher / keys / IVs are then set on the algif_tls socket, which is then hooked in to a tcp socket using

[RFC PATCH 1/2] Crypto support aesni rfc5288

Support rfc5288 using intel aesni routines. See also rfc5246. AAD length is 13 bytes padded out to 16. Padding bytes have to be passed in in scatterlist currently, which probably isn't quite the right fix. The assoclen checks were moved to the individual rfc stubs, and the common routines

Re: [RFC PATCH 2/2] Crypto kernel tls socket

On 11/23/15 02:27 PM, Sowmini Varadhan wrote: > On (11/23/15 09:43), Dave Watson wrote: > > Currently gcm(aes) represents ~80% of our SSL connections. > > > > Userspace interface: > > > > 1) A transform and op socket are created using the userspace crypto > > interface > > 2) Setsockopt