Re: [PATCH 0/2] crypto: KEYS: convert public key to akcipher api

On Thu, 2015-12-10 at 10:39 -0800, Tadeusz Struk wrote: > Hi Mimi, > On 12/10/2015 10:25 AM, Mimi Zohar wrote: > >> This patch set converts the module verification and digital signature > >> > code to the new akcipher API. > >> > RSA implementation has been removed from crypto/asymmetric_keys and

re: crypto: qat - add support for new devices to FW loader

Hello Pingchao Yang, The patch b0272276d903: "crypto: qat - add support for new devices to FW loader" from Dec 4, 2015, leads to the following static checker warning: drivers/crypto/qat/qat_common/qat_hal.c:421 qat_hal_check_ae_active() warn: bitwise AND condition is false here

Re: [patch -next] crypto: qat - uint8_t is not large enough for accel_id

Hi Dan, On 12/10/2015 02:00 PM, Dan Carpenter wrote: > ->accel_id has to be large enough to hold ADF_MAX_DEVICES + 1 (which is > 1025) so uint8_t is too small. > > Fixes: 890c55f4dc0e ('crypto: qat - add support for c3xxx accel type') > Signed-off-by: Dan Carpenter > >

Re: [PATCH 0/2] crypto: KEYS: convert public key to akcipher api

On Thu, 2015-12-10 at 14:37 -0500, Mimi Zohar wrote: > On Thu, 2015-12-10 at 10:39 -0800, Tadeusz Struk wrote: > > Hi Mimi, > > On 12/10/2015 10:25 AM, Mimi Zohar wrote: > > >> This patch set converts the module verification and digital signature > > >> > code to the new akcipher API. > > >> > RSA

[patch -next] crypto: qat - uint8_t is not large enough for accel_id

->accel_id has to be large enough to hold ADF_MAX_DEVICES + 1 (which is 1025) so uint8_t is too small. Fixes: 890c55f4dc0e ('crypto: qat - add support for c3xxx accel type') Signed-off-by: Dan Carpenter diff --git a/drivers/crypto/qat/qat_common/adf_accel_devices.h

Re: [cryptodev:master 50/54] adf_c3xxxvf_hw_data.c:undefined reference to `adf_iov_putmsg'

Hi, On 12/09/2015 12:22 PM, kbuild test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git > master > head: 161151d79ff4f7ed35d4ebb0eb7727a517c34ef2 > commit: 8b206f2d666f41f0aa83dec83504801ee945d3dc [50/54] crypto: qat - add > support for

Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

On Thu, 2015-12-10 at 09:45 +0800, Herbert Xu wrote: > On Wed, Dec 09, 2015 at 09:23:14AM -0800, Tim Chen wrote: > > > > This is an internal algorithm. We are indeed casting the request > > to the outer ablkcipher request when we do the async cipher walk. > > The question remain: why does it

Re: [PATCH 0/2] crypto: KEYS: convert public key to akcipher api

On Wed, 2015-12-09 at 15:52 -0800, Tadeusz Struk wrote: > This patch set converts the module verification and digital signature > code to the new akcipher API. > RSA implementation has been removed from crypto/asymmetric_keys and the > new API is used for cryptographic primitives. > There is no

Re: [PATCH] crypto: omap-des: Fix "schedule while atomic" bug

+ Lokesh Vutla + linux-o...@vger.kernel.org On Thu, Dec 10, 2015 at 6:06 PM, Semen Protsenko wrote: > > From: Sam Protsenko > > When using DES module the next bug appears: > > BUG: scheduling while atomic:

Re: [PATCH 0/2] crypto: KEYS: convert public key to akcipher api

Hi Mimi, On 12/10/2015 10:25 AM, Mimi Zohar wrote: >> This patch set converts the module verification and digital signature >> > code to the new akcipher API. >> > RSA implementation has been removed from crypto/asymmetric_keys and the >> > new API is used for cryptographic primitives. >> > There

Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code

On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote: > > The inner cipher is called synchronously from the outer layer > async cipher algorithm in cbc_mb_async_ablk_decrypt via > > err = crypto_blkcipher_crt(child_tfm)->decrypt( > >desc, req->dst, req->src,

RE: crypto: qat - add support for new devices to FW loader

Hi Dan, Yes, you are right. It should be left shift to check the AE ctx enable. Thanks for your defect, I will send a patch to fix this issue. Best Regards, Pingchao yang -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Friday, December 11, 2015 6:03 AM

[RFC PATCH V3] Crypto: rockchip/crypto - add hash support for crypto engine in rk3288

Add md5 sha1 sha256 support for crypto engine in rk3288. This patch can't support multiple updatings because of limited of IC, as result, it can't support import and export too. Signed-off-by: Zain Wang --- Changes in V3: - add switch instead of multiple if. Changes

Re: [PATCH 1/2] crypto: sahara: fix 64-bit dma_addr_t compilation

On Tue, Dec 08, 2015 at 04:23:51PM +0100, Arnd Bergmann wrote: > The sahara hardware uses DMA descriptors with 32-bit addresses, but > dma_addr_t is variable size depending on whether we want to support > any devices that use 64-bit DMA addresses in hardware. > This means that the definition of

Re: [PATCH] crypto: constify drbg_state_ops structures

On Mon, Dec 07, 2015 at 09:36:57PM +0100, Julia Lawall wrote: > The drbg_state_ops structures are never modified, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Patch applied. Thanks. -- Email: Herbert Xu

Re: "crypto_hash_setkey" call from atomic context

Fabrizio Demaria wrote: > Hello, > > I am investigating the current usage of kernel crypto-libraries in the > SCTP code, considering to adopt the same crypto framework for the > MPTCP implementation. > > In sm_make_chunk.c, the crypto function "crypto_hash_setkey"

"crypto_hash_setkey" call from atomic context

Hello, I am investigating the current usage of kernel crypto-libraries in the SCTP code, considering to adopt the same crypto framework for the MPTCP implementation. In sm_make_chunk.c, the crypto function "crypto_hash_setkey" is called in an atomic context, despite the fact that this function

[PATCH] crypto: omap-des: Fix "schedule while atomic" bug

From: Sam Protsenko When using DES module the next bug appears: BUG: scheduling while atomic: kworker/0:1/63/0x0102 With backtrace as follows: << cut here >>> [] (dump_backtrace) from []

Re: WARNING in crypto_wait_for_test

Am Dienstag, 8. Dezember 2015, 12:12:27 schrieb Dmitry Vyukov: Hi Dmitry, >Hello, > >The following program triggers a WARNING in crypto_wait_for_test: > >// autogenerated by syzkaller (http://github.com/google/syzkaller) >#include >#include >#include > >int main() >{ >long r0 =