Re: "crypto_hash_setkey" call from atomic context

On Mon, Dec 14, 2015 at 09:53:03AM +0100, Fabrizio Demaria wrote: > In our MPTCP implementation we handled the setkey problem by > pre-allocating a properly aligned key's buffer right after > "crypto_alloc_hash", outside atomic context [1]. Would this workaround > be enough to guarantee that

Re: WARNING in crypto_wait_for_test

On Mon, Dec 14, 2015 at 11:45:02PM +0100, Stephan Mueller wrote: > > But with the given code, when you remove the bogus mask setting (which in > turn > leaves it as 0), the code works flawless. Please find out exactly why this would be triggering the warning because your previous explanation of

Re: [PATCH v2 2/2] integrity: convert digsig to akcipher api

On 12/14/2015 05:24 AM, Mimi Zohar wrote: > On Sat, 2015-12-12 at 18:26 -0800, Tadeusz Struk wrote: >> Convert asymmetric_verify to akcipher api. >> >> Signed-off-by: Tadeusz Struk >> --- >> security/integrity/Kconfig |1 + >>

Re: WARNING in crypto_wait_for_test

On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: > > Herbert, alg_bind currently blacklists one bit in the mask and type bit > array. > Shouldn't we instead white-list the allowed bits? Well a bogus mask shouldn't lead to the warning anyway. The warning in question is triggered

Re: [PATCH v2] crypto: qat - enable VF irq after guest exits ungracefully

On Wed, Dec 09, 2015 at 09:38:30PM -0800, Tadeusz Struk wrote: > From: Zeng Xin > > The VF bundle interrupt is not triggered any more in > the case when guest is shut down with sample app running. > Need to clear the flag interrupt bit when restarting to fix > this

Re: [PATCH] crypto: omap-des: Fix "schedule while atomic" bug

On Thu, Dec 10, 2015 at 06:06:59PM +0200, Semen Protsenko wrote: > From: Sam Protsenko > > When using DES module the next bug appears: > > BUG: scheduling while atomic: kworker/0:1/63/0x0102 > > With backtrace as follows: > > <<

Re: [PATCH v2 2/2] integrity: convert digsig to akcipher api

On Sat, 2015-12-12 at 18:26 -0800, Tadeusz Struk wrote: > Convert asymmetric_verify to akcipher api. > > Signed-off-by: Tadeusz Struk > --- > security/integrity/Kconfig |1 + > security/integrity/digsig_asymmetric.c | 10 +++--- > 2 files changed,

Re: [PATCH v2 0/5] crypto: add algif_akcipher user space API

Hi, On 10/26/2015 09:54 PM, Marcel Holtmann wrote: > Hi Stephan, > >> This patch set adds the AF_ALG user space API to externalize the >> asymmetric cipher API recently added to the kernel crypto API. >> >> The patch set is tested with the user space library of libkcapi [1]. >> Use [1]

[RFC PATCH V4] Crypto: rockchip/crypto - add hash support for crypto engine in rk3288

Add md5 sha1 sha256 support for crypto engine in rk3288. This patch can't support multiple updatings because of limited of IC, as result, it can't support import and export too. Signed-off-by: Zain Wang --- Changes in V4: - remove CRYPTO_ALG_NEED_FALLBACK. Changes in

Re: "crypto_hash_setkey" call from atomic context

In our MPTCP implementation we handled the setkey problem by pre-allocating a properly aligned key's buffer right after "crypto_alloc_hash", outside atomic context [1]. Would this workaround be enough to guarantee that "crypto_hash_setkey" can be safely called in atomic contexts? Is it always the

[PATCH 2/2] crypto: omap-aes,omap-des: Removed unused variable "err"

From: Rahul Pathak Removed unused variable "err" and directly return "0" Reported by coccicheck - ./drivers/crypto/omap-aes.c:542:5-8: Unneeded variable: "err". Return "0" on line 551 ./drivers/crypto/omap-des.c:530:5-8: Unneeded variable: "err". Return "0" on line 539

[PATCH 1/2] crypto: atmel-sha: Removed unused variable "err"

From: Rahul Pathak Removed unused variable "err" and directly return "0" Reported by coccicheck - ./drivers/crypto/atmel-sha.c:758:5-8: Unneeded variable: "err". Return "0" on line 766 Signed-off-by: Rahul Pathak --- drivers/crypto/atmel-sha.c | 3

Re: WARNING in crypto_wait_for_test

Am Montag, 14. Dezember 2015, 20:52:19 schrieb Herbert Xu: Hi Herbert, >On Thu, Dec 10, 2015 at 03:14:24AM +0100, Stephan Mueller wrote: >> Herbert, alg_bind currently blacklists one bit in the mask and type bit >> array. Shouldn't we instead white-list the allowed bits? > >Well a bogus mask