On Sun, Jan 24, 2016 at 07:10:50PM +0100, Julia Lawall wrote:
> Maybe the goto on line 1726 needs a preceding mutex_unlock?
Good catch! Thanks.
---8<---
This patch replaces uses of ablkcipher and blkcipher with skcipher,
and the long obsolete hash interface with shash.
Signed-off-by: Herbert Xu
This patch replaces uses of ablkcipher with skcipher, and the long
obsolete hash interface with ahash.
Signed-off-by: Herbert Xu
---
drivers/md/dm-crypt.c | 93 +-
1 file changed, 48 insertions(+), 45
This patch replaces uses of blkcipher with skcipher, and the long
obsolete hash interface with ahash. This is a bug-for-bug conversion
and no attempt has been made to fix bugs such as the ignored return
values of the crypto operations.
Signed-off-by: Herbert Xu
---
This patch replaces uses of blkcipher with the new skcipher
interface.
Signed-off-by: Herbert Xu
---
drivers/block/cryptoloop.c | 48 +++--
1 file changed, 25 insertions(+), 23 deletions(-)
diff --git
-where-possible/20160124-212323
config: x86_64-randconfig-x014-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/block/cryptoloop.c: In function 'cryptoloop_transfer':
>
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu
---
drivers/usb/wusbcore/crypto.c | 30 --
1 file changed, 16 insertions(+), 14 deletions(-)
diff --git a/drivers/usb/wusbcore/crypto.c
This patch replaces uses the long obsolete hash interface with ahash.
Signed-off-by: Herbert Xu
---
drivers/net/wireless/intersil/orinoco/mic.c | 29 ++--
drivers/net/wireless/intersil/orinoco/mic.h |4 +--
This patch replaces uses of blkcipher with skcipher, and the long
obsolete hash interface with ahash.
Signed-off-by: Herbert Xu
---
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_tkip.c | 92 +++---
The interfaces blkcipher and hash are obsolete. This patch replaces
them with skcipher and ahash respectively.
Signed-off-by: Herbert Xu
---
drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 99 ++-
-where-possible/20160124-212323
config: x86_64-randconfig-x009-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
fs/nfsd/nfs4recover.c: In function 'nfs4_make_rec_clidname':
>
This patch replaces uses of ablkcipher and blkcipher with skcipher,
and the long obsolete hash interface with shash.
Signed-off-by: Herbert Xu
---
fs/ecryptfs/crypto.c | 107 +---
fs/ecryptfs/ecryptfs_kernel.h | 12 +-
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu
---
net/rxrpc/ar-internal.h |2
net/rxrpc/ar-key.c | 12 +--
net/rxrpc/rxkad.c | 172 +---
3 files changed, 114
This patch replaces uses of the long obsolete hash interface with
either shash (for non-SG users) or ahash.
Signed-off-by: Herbert Xu
---
drivers/block/drbd/drbd_int.h | 16 +-
drivers/block/drbd/drbd_main.c | 16 +-
This patch replaces uses of blkcipher with skcipher and the long
obsolete hash interface with shash.
Signed-off-by: Herbert Xu
---
net/bluetooth/smp.c | 135
1 file changed, 63 insertions(+), 72 deletions(-)
This patch replaces uses of the long obsolete hash interface with
ahash.
Signed-off-by: Herbert Xu
---
drivers/scsi/iscsi_tcp.c| 54 ++--
drivers/scsi/iscsi_tcp.h|4 +--
drivers/scsi/libiscsi_tcp.c | 29
This patch replaces uses of the long obsolete hash interface with
shash.
Signed-off-by: Herbert Xu
---
include/net/sctp/auth.h|4 +--
include/net/sctp/structs.h |6 ++---
net/sctp/auth.c| 36 ---
This patch replaces uses of the long obsolete hash interface with
ahash.
Signed-off-by: Herbert Xu
---
include/net/tcp.h |6 +-
net/ipv4/tcp.c | 41 ++---
net/ipv4/tcp_fastopen.c |1 +
This patch replaces uses of ablkcipher with skcipher.
Signed-off-by: Herbert Xu
---
fs/ext4/crypto.c | 24 +++-
fs/ext4/crypto_fname.c | 32 +++-
fs/ext4/crypto_key.c | 42
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu
---
net/mac802154/llsec.c | 41 +++--
net/mac802154/llsec.h |3 +--
2 files changed, 24 insertions(+), 20 deletions(-)
diff --git
-where-possible/20160124-212323
config: x86_64-randconfig-x014-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/nfc/s3fwrn5/firmware.c: In function 's3fwrn5_fw_do
This patch replaces uses of ablkcipher with skcipher.
Signed-off-by: Herbert Xu
---
fs/f2fs/crypto.c | 24 +++-
fs/f2fs/crypto_fname.c | 32 +++-
fs/f2fs/crypto_key.c | 40
-where-possible/20160124-212323
config: x86_64-randconfig-x016-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/usb/wusbcore/crypto.c: In function 'wusb_ccm_mac':
>>
-where-possible/20160124-212323
config: x86_64-randconfig-x014-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/bluetooth/smp.c: In function 'aes_cmac':
>> net/bluetooth
Hi:
The crypto hash interface has been obsolete for many years and
this series converts all remaining users to shash and ahash as
appropriate. Despite the name ahash can be used synchronously
and is the preferred interface for those dealing with SGs.
The blkcipher and ablkcipher interfaces are
This patch replaces uses of blkcipher with skcipher and the long
obsolete hash interface with either shash (for non-SG users) and
ahash.
Signed-off-by: Herbert Xu
---
include/linux/sunrpc/gss_krb5.h | 32 +--
net/sunrpc/auth_gss/gss_krb5_crypto.c | 350
This patch removes the last reference to hash and ablkcipher from
IPsec and replaces them with ahash and skcipher respectively. For
skcipher there is currently no difference at all, while for ahash
the current code is actually buggy and would prevent asynchronous
algorithms from being discovered.
This patch replaces uses of blkcipher with skcipher.
Signed-off-by: Herbert Xu
---
fs/cifs/cifsencrypt.c | 32 +---
fs/cifs/smbencrypt.c | 26 +++---
2 files changed, 40 insertions(+), 18 deletions(-)
diff
This patch replaces uses of the long obsolete hash interface with
shash.
Signed-off-by: Herbert Xu
---
fs/nfsd/nfs4recover.c | 28 +---
1 file changed, 17 insertions(+), 11 deletions(-)
diff --git a/fs/nfsd/nfs4recover.c
-where-possible/20160124-212323
config: x86_64-randconfig-x012-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All error/warnings (new ones prefixed by >>):
fs/ecryptfs/crypto.c: In function 'ecryptfs_hash_digest':
On Sun, Jan 24, 2016 at 09:37:33PM +0800, kbuild test robot wrote:
>
> [auto build test ERROR on net/master]
> [also build test ERROR on v4.4 next-20160122]
> [if your patch is applied to the wrong git tree, please drop us a note to
> help improving the system]
These patches depend on the two
-where-possible/20160124-212323
config: x86_64-randconfig-x014-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
drivers/md/dm-crypt.c: In function 'crypt_iv_essiv_init':
>> d
-where-possible/20160124-212323
config: x86_64-randconfig-x014-201604 (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All errors (new ones prefixed by >>):
net/xfrm/xfrm_algo.c: In function 'xfrm_probe_algs':
>&
From: Herbert Xu
Date: Sun, 24 Jan 2016 21:19:11 +0800
> This patch removes the last reference to hash and ablkcipher from
> IPsec and replaces them with ahash and skcipher respectively. For
> skcipher there is currently no difference at all, while for ahash
> the
From: Herbert Xu
Date: Sun, 24 Jan 2016 21:20:12 +0800
> This patch replaces uses of the long obsolete hash interface with
> shash.
>
> Signed-off-by: Herbert Xu
Acked-by: David S. Miller
--
To unsubscribe from
On Fri, Jan 22, 2016 at 11:22:48AM -0600, Tom Lendacky wrote:
> On 01/12/2016 11:17 AM, Tom Lendacky wrote:
> > Commit 8996eafdcbad ("crypto: ahash - ensure statesize is non-zero")
> > added a check to prevent ahash algorithms from successfully registering
> > if the import and export functions
On Fri, Jan 22, 2016 at 05:52:45PM +0100, Nicolas Ferre wrote:
> Le 15/01/2016 15:49, Cyrille Pitchen a écrit :
> > Hi all,
> >
> > This series of patches fixes many issues such as the algo registration
> > failure
> > or the broken support of context switches.
>
> I think it's eligible as a
On Fri, Jan 22, 2016 at 04:52:36PM +, Horia Ioan Geanta Neag wrote:
> Herbert, I see that you've sent the crypto fixes for 4.5 pull request.
> Any reason why these patches were not included?
> I was expecting at least the first one to get it, it's even Cc-ing stable.
Well the second patch is
Hi Herbert,
> This patch replaces uses of blkcipher with skcipher and the long
> obsolete hash interface with shash.
>
> Signed-off-by: Herbert Xu
Acked-by: Marcel Holtmann
> ---
>
> net/bluetooth/smp.c | 135
>
From: Herbert Xu
Date: Sun, 24 Jan 2016 21:20:23 +0800
> This patch replaces uses of the long obsolete hash interface with
> ahash.
>
> Signed-off-by: Herbert Xu
Acked-by: David S. Miller
--
To unsubscribe from
On Fri, Jan 15, 2016 at 03:49:35PM +0100, Cyrille Pitchen wrote:
>
> +static int atmel_sha_export(struct ahash_request *req, void *out)
> +{
> + const struct atmel_sha_reqctx *ctx = ahash_request_ctx(req);
> + struct atmel_sha_state *state = out;
> +
> + memcpy(state->digest,
drop us a note to
> help improving the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Herbert-Xu/crypto-Use-skcipher-and-ahash-shash-where-possible/20160124-212323
> :: branch date: 5 hours ago
> :: commit date: 5 hours ago
>
> >> fs/ecryptfs/key
On Sun, Jan 24, 2016 at 09:16:57PM +0800, Herbert Xu wrote:
> This patch replaces uses of blkcipher with skcipher, and the long
> obsolete hash interface with ahash.
>
> Signed-off-by: Herbert Xu
> ---
>
>
On Sun, Jan 24, 2016 at 09:16:26PM +0800, Herbert Xu wrote:
> The interfaces blkcipher and hash are obsolete. This patch replaces
> them with skcipher and ahash respectively.
>
> Signed-off-by: Herbert Xu
> ---
>
> drivers/staging/rtl8192e/rtllib_crypt_tkip.c |
43 matches
Mail list logo