Re: [PATCH 0/2] Automatically load the vmx_crypto module if supported

2016-07-12 Thread Alastair D'Silva
On Wed, 2016-07-13 at 15:47 +1000, alast...@au1.ibm.com wrote: > From: Alastair D'Silva > > This series allows the vmx_crypto module to be detected and > automatically > loaded via UDEV if the CPU supports the vector crypto feature. > > Alastair D'Silva (2): >   powerpc: Add module autoloading bas

[PATCH 2/2] crypto: vmx - Convert to CPU feature based module autoloading

2016-07-12 Thread alastair
From: Alastair D'Silva This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure to automatically load the vmx_crypto module if the CPU supports it. Signed-off-by: Alastair D'Silva --- drivers/crypto/vmx/Kconfig | 2 +- drivers/crypto/vmx/vmx.c | 6 ++ 2 files changed, 3 insertions(+)

[PATCH 2/2] Automatically load the vmx_crypto module if supported.

2016-07-12 Thread alastair
From: Alastair D'Silva This patch utilises the GENERIC_CPU_AUTOPROBE infrastructure to automatically load the vmx_crypto module if the CPU supports it. Signed-off-by: Alastair D'Silva --- drivers/crypto/vmx/Kconfig | 2 +- drivers/crypto/vmx/vmx.c | 6 ++ 2 files changed, 3 insertions(+)

[PATCH 0/2] Automatically load the vmx_crypto module if supported

2016-07-12 Thread alastair
From: Alastair D'Silva This series allows the vmx_crypto module to be detected and automatically loaded via UDEV if the CPU supports the vector crypto feature. Alastair D'Silva (2): powerpc: Add module autoloading based on CPU features crypto: vmx - Convert to CPU feature based module autolo

[PATCH 1/2] powerpc: Add module autoloading based on CPU features

2016-07-12 Thread alastair
From: Alastair D'Silva This patch provides the necessary infrastructure to allow drivers to be automatically loaded via UDEV. It implements the minimum required to be able to use module_cpu_feature_match to trigger the GENERIC_CPU_AUTOPROBE mechanisms. The features exposed are a mirror of the cp

[PATCH 1/2] Allow drivers to be autoloaded.

2016-07-12 Thread alastair
From: Alastair D'Silva This patch provides the necessary infrastructure to allow drivers to be automatically loaded via UDEV. It implements the minimum required to be able to use module_cpu_feature_match to trigger the GENERIC_CPU_AUTOPROBE mechanisms. The features exposed are a mirror of the cp

Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

2016-07-12 Thread Stewart Smith
Stephen Rothwell writes: > On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo > wrote: >> >> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl >> b/drivers/crypto/vmx/aesp8-ppc.pl >> index 2280539..813ffcc 100644 >> --- a/drivers/crypto/vmx/aesp8-ppc.pl >> +++ b/drivers/crypto/vmx/aesp8-ppc.p

RE: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS

2016-07-12 Thread David Laight
From: Paulo Flabiano Smorigo > Sent: 11 July 2016 20:08 > > This patch add XTS subroutines using VMX-crypto driver. > > It gives a boost of 20 times using XTS. > > These code has been adopted from OpenSSL project in collaboration > with the original author (Andy Polyakov ). Yep, typical openssl

[PATCH v3 0/4] crypto: Key Derivation Function (SP800-108)

2016-07-12 Thread Stephan Mueller
Hi, this patch set implements all three key derivation functions defined in SP800-108. The implementation is provided as a template for random number generators, since a KDF can be considered a form of deterministic RNG where the key material is used as a seed. With the KDF implemented as a temp

[PATCH v3 3/4] crypto: kdf - SP800-108 Key Derivation Function

2016-07-12 Thread Stephan Mueller
The SP800-108 compliant Key Derivation Function is implemented as a random number generator considering that it behaves like a deterministic RNG. All three KDF types specified in SP800-108 are implemented. The code comments provide details about how to invoke the different KDF types. Signed-off-

[RFC PATCH] KEYS: add SP800-56A KDF support for DH

2016-07-12 Thread Stephan Mueller
Hi Mat, David, This patch is based on the cryptodev-2.6 tree with the patch 4693fc734d675c5518ea9bd4c9623db45bc37402 ("KEYS: Add placeholder for KDF usage with DH") from Linus' tree added on top. I am aware of the fact that the compat code is not present. This patch is intended for review to veri

[PATCH v3 2/4] crypto: kdf - add known answer tests

2016-07-12 Thread Stephan Mueller
Add known answer tests to the testmgr for the KDF (SP800-108) cipher. Signed-off-by: Stephan Mueller --- crypto/testmgr.c | 226 +++ crypto/testmgr.h | 110 +++ 2 files changed, 336 insertions(+) diff --git a/crypto/tes

[PATCH v3 1/4] crypto: add template handling for RNGs

2016-07-12 Thread Stephan Mueller
This patch adds the ability to register templates for RNGs. RNGs are "meta" mechanisms using raw cipher primitives. Thus, RNGs can now be implemented as templates to allow the complete flexibility the kernel crypto API provides. Signed-off-by: Stephan Mueller --- crypto/rng.c | 31 ++

[PATCH v3 4/4] crypto: kdf - enable compilation

2016-07-12 Thread Stephan Mueller
Include KDF into Kconfig and Makefile for compilation. Signed-off-by: Stephan Mueller --- crypto/Kconfig | 7 +++ crypto/Makefile | 1 + 2 files changed, 8 insertions(+) diff --git a/crypto/Kconfig b/crypto/Kconfig index 62fcbb9..7779af8 100644 --- a/crypto/Kconfig +++ b/crypto/Kconfig @@

[PATCH] DH support: add KDF handling support

2016-07-12 Thread Stephan Mueller
Hi Mat, David, During the development of this patch, I saw that the test framework seems to be broken: when I change the expected values by one bit, the test framework will still mark the received result as PASS even though the returned data does not match the expected data. ---8< Add the in

Re: [PATCH 3/3] crypto: Added Chelsio Menu to the Kconfig file

2016-07-12 Thread Herbert Xu
On Tue, Jul 12, 2016 at 03:30:41AM +0800, kbuild test robot wrote: > Hi, > > [auto build test WARNING on net-next/master] > [also build test WARNING on v4.7-rc7 next-20160711] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] Yeshaswi, please

Re: [PATCH 2/3] chcr: Support for Chelsio's Crypto Hardware

2016-07-12 Thread Herbert Xu
On Mon, Jul 11, 2016 at 11:28:07AM -0700, Yeshaswi M R Gowda wrote: > > + u_ctx = ULD_CTX(ctx); > + if (cxgb4_is_crypto_q_full(u_ctx->lldi.ports[0], ctx->tx_channel_id)) > + return -EBUSY; You cannot just return -EBUSY. If the request has the MAY_BACKLOG bit set, it must be qu

Re: [PATCH 5/6] crypto: img-hash - Add support for export and import

2016-07-12 Thread Herbert Xu
Will Thomas wrote: > > @@ -714,9 +740,12 @@ static struct ahash_alg img_algs[] = { >.update = img_hash_update, >.final = img_hash_final, >.finup = img_hash_finup, > + .export = img_hash_export, > + .import = img_hash_impor

Re: [PATCH 2/6] crypto: img-hash - Fix hash request context

2016-07-12 Thread Herbert Xu
Will Thomas wrote: > Move 0 length buffer to end of structure to stop overwriting > fallback request data. This doesn't cause a bug itself as the > buffer is never used alongside the fallback but should be > changed. > > Signed-off-by: Will Thomas > Reviewed-by: James Hartley This points out a

Re: [PATCH 1/6] crypto: img-hash - Fix null pointer exception

2016-07-12 Thread Herbert Xu
Will Thomas wrote: > Sporadic null pointer exceptions came from here. Fix them. > > Signed-off-by: Will Thomas > Reviewed-by: James Hartley > --- > drivers/crypto/img-hash.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-h