Re: [PATCH] crypto: cryptd - Remove unused but set variable 'tfm'

2016-10-31 Thread Herbert Xu
On Mon, Oct 31, 2016 at 03:42:43PM +0100, Tobias Klauser wrote: > Remove the unused but set variable tfm in cryptd_enqueue_request to fix > the following warning when building with 'W=1': > > crypto/cryptd.c:125:21: warning: variable 'tfm' set but not used > [-Wunused-but-set-variable] > >

Re: [PATCH] crypto: skcipher - Get rid of crypto_grab_skcipher2()

2016-10-31 Thread Herbert Xu
On Fri, Oct 28, 2016 at 09:51:13AM -0700, Eric Biggers wrote: > Since commit 3a01d0ee2b99 ("crypto: skcipher - Remove top-level > givcipher interface"), crypto_grab_skcipher2() and > crypto_grab_skcipher() are equivalent. So switch callers of > crypto_grab_skcipher2() to crypto_grab_skcipher()

Re: [PATCH] crypto: skcipher - Get rid of crypto_spawn_skcipher2()

2016-10-31 Thread Herbert Xu
On Fri, Oct 28, 2016 at 09:52:19AM -0700, Eric Biggers wrote: > Since commit 3a01d0ee2b99 ("crypto: skcipher - Remove top-level > givcipher interface"), crypto_spawn_skcipher2() and > crypto_spawn_skcipher() are equivalent. So switch callers of > crypto_spawn_skcipher2() to

Re: [PATCH v3] char: hw_random: atmel-rng: disable TRNG during suspend

2016-10-31 Thread Herbert Xu
On Fri, Oct 28, 2016 at 04:00:46PM +0800, Wenyou Yang wrote: > To fix the over consumption on the VDDCore due to the TRNG enabled, > disable the TRNG during suspend, not only disable the user interface > clock (which is controlled by PMC). Because the user interface clock > is independent from any

Re: [cryptodev:master 41/47] ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined!

2016-10-31 Thread Herbert Xu
On Wed, Oct 26, 2016 at 10:56:45AM +0100, Giovanni Cabiddu wrote: > Hi, > > On Wed, Oct 26, 2016 at 08:47:16AM +0800, kbuild test robot wrote: > > >> ERROR: "crypto_acomp_scomp_free_ctx" [crypto/acompress.ko] undefined! > > >> ERROR: "crypto_acomp_scomp_alloc_ctx" [crypto/acompress.ko] undefined!

Re: [PATCH] crypto: caam: fix type mismatch warning

2016-10-31 Thread Herbert Xu
On Tue, Oct 25, 2016 at 11:29:10PM +0200, Arnd Bergmann wrote: > Building the caam driver on arm64 produces a harmless warning: > > drivers/crypto/caam/caamalg.c:140:139: warning: comparison of distinct > pointer types lacks a cast > > We can use min_t to tell the compiler which type we want it

Re: [PATCH -next] crypto: drop pointless static qualifier in atmel_aes_probe()

2016-10-31 Thread Herbert Xu
On Mon, Oct 24, 2016 at 02:51:22PM +, Wei Yongjun wrote: > From: Wei Yongjun > > There is no need to have the 'struct atmel_aes_dev *aes_dd' variable > static since new value always be assigned before use it. > > Signed-off-by: Wei Yongjun

Re: [PATCH] crypto: sahara: fix typo "Decidated" -> "Dedicated"

2016-10-31 Thread Herbert Xu
On Tue, Oct 25, 2016 at 12:07:27PM +0100, Colin King wrote: > From: Colin Ian King > > Trivial fix to typo in dev_dbg message > > Signed-off-by: Colin Ian King Patch applied. Thanks. -- Email: Herbert Xu Home

Re: [PATCH] hwrng: core - zeroize buffers with random data

2016-10-31 Thread Herbert Xu
On Sat, Oct 22, 2016 at 03:57:05PM +0200, Stephan Mueller wrote: > > The HWRNG core allocates two buffers during initialization which are > used to obtain random data. After that data is processed, it is now > zeroized as it is possible that the HWRNG core will not be asked to > produce more

Re: [PATCH 0/3] crypto: testmgr - Add missing tests for internal sha*-mb implementations

2016-10-31 Thread Herbert Xu
On Wed, Oct 26, 2016 at 03:04:42PM -0200, Marcelo Cerri wrote: > This series adds null tests for all sha*-mb internal algorithms so they can > be used in FIPS mode without further problems. > > Since they are 3 separated modules I decided to use a separated commit for > each one. > > Marcelo

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-31 Thread Mat Martineau
Hi Stephan - On Mon, 31 Oct 2016, Stephan Mueller wrote: Am Freitag, 28. Oktober 2016, 15:21:19 CET schrieb Mat Martineau: Hi Mat, Please check the current patch (the one I sent to you as a pre-release did not contain the fix for the decryption part -- the patch sent to the list and what

Re: [PATCH 1/5] ARM: wire up HWCAP2 feature bits to the CPU modalias

2016-10-31 Thread Russell King - ARM Linux
On Sat, Oct 29, 2016 at 11:08:36AM +0100, Ard Biesheuvel wrote: > On 18 October 2016 at 11:52, Ard Biesheuvel wrote: > > Wire up the generic support for exposing CPU feature bits via the > > modalias in /sys/device/system/cpu. This allows udev to automatically > > load

[PATCH] crypto: cryptd - Remove unused but set variable 'tfm'

2016-10-31 Thread Tobias Klauser
Remove the unused but set variable tfm in cryptd_enqueue_request to fix the following warning when building with 'W=1': crypto/cryptd.c:125:21: warning: variable 'tfm' set but not used [-Wunused-but-set-variable] Signed-off-by: Tobias Klauser --- crypto/cryptd.c | 2 -- 1

Re: [PATCH] crypto: fix AEAD tag memory handling

2016-10-31 Thread Stephan Mueller
Am Freitag, 28. Oktober 2016, 15:21:19 CET schrieb Mat Martineau: Hi Mat, > > > > Please check the current patch (the one I sent to you as a pre-release did > > not contain the fix for the decryption part -- the patch sent to the list > > and what we discuss here contains the appropriate

Re: [RESEND][PATCH] crypto: caam: add support for iMX6UL

2016-10-31 Thread Russell King - ARM Linux
On Mon, Oct 17, 2016 at 01:28:00PM +0200, Marcus Folkesson wrote: > i.MX6UL does only require three clocks to enable CAAM module. > > Signed-off-by: Marcus Folkesson > Acked-by: Rob Herring > Reviewed-by: Horia Geantă > --- >