Re: [PATCH] crypto: sun4i-ss: support the Security System PRNG

On Thu, Nov 17, 2016 at 08:07:09PM -0500, Sandy Harris wrote: > Add Ted T'so to cc list. Shouldn't he be included on anything affecting > the random(4) driver? > Blindy used get_maintainer.pl, and since the file is in crypto, hw_random people were not set. Note that get_maintainer.pl on

Re: [PATCH] crypto: sun4i-ss: support the Security System PRNG

Add Ted T'so to cc list. Shouldn't he be included on anything affecting the random(4) driver? On Tue, Oct 18, 2016 at 8:34 AM, Corentin Labbe wrote: > From: LABBE Corentin > > The Security System have a PRNG. > This patch add support for it

Re: BUG: algif_hash crash with extra recv() in 4.9-rc5

On 11/17/2016 06:07 AM, Herbert Xu wrote: > On Wed, Nov 16, 2016 at 11:17:33AM -0800, Mat Martineau wrote: >> >> Herbert - >> >> Following commit 493b2ed3f7603a15ff738553384d5a4510ffeb95, there is a NULL >> dereference crash in algif_hash when recv() is called twice like this: >> >> send(sk, data,

RE: [PATCH] crypto: add virtio-crypto driver

Hi Gonglei, ... > + > +static int virtio_crypto_alg_ablkcipher_init_session( > + struct virtio_crypto_ablkcipher_ctx *ctx, > + int alg, const uint8_t *key, > + unsigned int keylen, > + int encrypt) > +{ > + struct scatterlist outhdr, key_sg,

Re: crypto: caam warning fix, was: master build: 0 failures 1 warnings (v4.9-rc5-177-g81bcfe5)

On Thursday, November 17, 2016 11:34:04 PM CET Herbert Xu wrote: > On Wed, Nov 16, 2016 at 05:40:41PM +0100, Arnd Bergmann wrote: > > > > This is currently the only build warning reported for v4.9, and you have > > merged > > the fix for v4.10 in > > > > d69985a07692 ("crypto: caam - fix type

Re: crypto: caam warning fix, was: master build: 0 failures 1 warnings (v4.9-rc5-177-g81bcfe5)

On Wed, Nov 16, 2016 at 05:40:41PM +0100, Arnd Bergmann wrote: > > This is currently the only build warning reported for v4.9, and you have > merged > the fix for v4.10 in > > d69985a07692 ("crypto: caam - fix type mismatch warning") > > Any chance you can send this for v4.9 so we have a clean

Re: [PATCH] powerpc: crypto/vmx: various build fixes

On Thu, Nov 17, 2016 at 11:51:56AM +1100, Michael Ellerman wrote: > > But maybe Herbert can fix it up for you when he applies this. Sure I can fix it up. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

On Wed, Nov 16, 2016 at 11:25:19AM -0600, Gary R Hook wrote: > > The kernel crypto layer does not yet support RSA, true. However, we > designed the ccp.ko layer to be available to anyone that wants to use > it. The underlying module currently has differing behavior/results > between the v3 and v5

Re: [PATCH] powerpc: crypto/vmx: various build fixes

On Wed, Nov 16, 2016 at 08:41:46PM +0530, Naveen N. Rao wrote: > First up, clean up the generated .S files properly on a 'make clean'. > Secondly, force re-generation of these files when building for different > endian-ness than what was built previously. Finally, generate the new > files in the

Re: BUG: algif_hash crash with extra recv() in 4.9-rc5

On Wed, Nov 16, 2016 at 11:17:33AM -0800, Mat Martineau wrote: > > Herbert - > > Following commit 493b2ed3f7603a15ff738553384d5a4510ffeb95, there is a NULL > dereference crash in algif_hash when recv() is called twice like this: > > send(sk, data, len, MSG_MORE); > recv(sk, hash1, len, 0); >

Re: [PATCH] powerpc: crypto/vmx: various build fixes

On 2016/11/17 09:03PM, Herbert Xu wrote: > On Thu, Nov 17, 2016 at 11:51:56AM +1100, Michael Ellerman wrote: > > > > Crypto patches usually have a subject like: > > > > crypto: vmx - Various build fixes Ok. > > > > But maybe Herbert can fix it up for you when he applies this. > > Sure I can

Re: BUG: algif_hash crash with extra recv() in 4.9-rc5

Herbert, On Thu, 17 Nov 2016, Herbert Xu wrote: On Wed, Nov 16, 2016 at 11:17:33AM -0800, Mat Martineau wrote: Herbert - Following commit 493b2ed3f7603a15ff738553384d5a4510ffeb95, there is a NULL dereference crash in algif_hash when recv() is called twice like this: send(sk, data, len,

Re: [PATCH] crypto: ccp - Fix handling of RSA exponent on a v5 device

On 11/17/2016 07:14 AM, Herbert Xu wrote: On Wed, Nov 16, 2016 at 11:25:19AM -0600, Gary R Hook wrote: The kernel crypto layer does not yet support RSA, true. However, we designed the ccp.ko layer to be available to anyone that wants to use it. The underlying module currently has differing

Re: [PATCH] crypto: sun4i-ss: support the Security System PRNG

Am Donnerstag, 17. November 2016, 09:07:48 CET schrieb Corentin Labbe: Hi Corentin, > > Seed again, or just do not seed (and so return -EAGAIN for read() function) > until ready_callback ? This is your choice. But for the start sequence, you should not simply rely on get_random_bytes. For the

Re: [PATCH] crypto: sun4i-ss: support the Security System PRNG

On Tue, Oct 18, 2016 at 04:24:22PM +0200, Stephan Mueller wrote: > Am Dienstag, 18. Oktober 2016, 14:34:27 CEST schrieb Corentin Labbe: > > Hi Corentin, > > > diff --git a/drivers/crypto/sunxi-ss/sun4i-ss-hwrng.c > > b/drivers/crypto/sunxi-ss/sun4i-ss-hwrng.c new file mode 100644 > > index

Re: [PATCH] crypto: sun4i-ss: support the Security System PRNG

On Tue, Oct 18, 2016 at 09:39:17PM +0530, PrasannaKumar Muralidharan wrote: > Hi Corentin, > > I have a few minor comments. > > On 18 October 2016 at 18:04, Corentin Labbe wrote: > > From: LABBE Corentin > > > > The Security System have a