Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote: > __CHECK_ENDIAN__ isn't on by default presumably because > it triggers too many sparse warnings for correct code. > But virtio is now clean of these warnings, and > we want to keep it this way - enable this for > sparse builds. >

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote: > It seems that there should be a better way to do it, > but this works too. In some cases there might be: > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -6,6 +6,8 @@ >  # it under the terms of the GNU

Re: [PATCH 10/10] virtio: enable endian checks for sparse builds

On 2016年12月06日 23:41, Michael S. Tsirkin wrote: __CHECK_ENDIAN__ isn't on by default presumably because it triggers too many sparse warnings for correct code. But virtio is now clean of these warnings, and we want to keep it this way - enable this for sparse builds. Signed-off-by: Michael S.

Re: [PATCH v2] crypto/mcryptd: Check mcryptd algorithm compatibility

I think a proper fix would be to find the reason why mcryptd crashes and fix that reason (i.e. make it fail in mcryptd_create_hash rather than crash). Testing flags could fix the bug for now but it could backfire later when more algorithms are added. Mikulas On Mon, 5 Dec 2016, Tim Chen

[PATCH 10/10] virtio: enable endian checks for sparse builds

__CHECK_ENDIAN__ isn't on by default presumably because it triggers too many sparse warnings for correct code. But virtio is now clean of these warnings, and we want to keep it this way - enable this for sparse builds. Signed-off-by: Michael S. Tsirkin --- It seems that there

[PATCH 00/10] virtio: sparse fixes

I run latest sparse from git on virtio drivers (turns out the version I had was rather outdated). This patchset fixes a couple of bugs this uncovered, and adds some annotations to make it sparse-clean. In particular, endian-ness is often tricky, so this patchset enabled endian-ness checks for

Re: [PATCH 2/3] crypto: brcm: Add Broadcom SPU driver

On Wed, Nov 30, 2016 at 03:07:32PM -0500, Rob Rice wrote: > +static const struct of_device_id bcm_spu_dt_ids[] = { > + { > + .compatible = "brcm,spum-crypto", > + .data = _ns2_types, > + }, > + { > + .compatible = "brcm,spum-nsp-crypto", > +

Re: [PATCH 1/3] crypto: brcm: DT documentation for Broadcom SPU driver

On Wed, Nov 30, 2016 at 03:07:31PM -0500, Rob Rice wrote: > Device tree documentation for Broadcom Secure Processing Unit > (SPU) crypto driver. > > Signed-off-by: Steve Lin > Signed-off-by: Rob Rice > --- >

RE: [PATCH v5 1/1] crypto: add virtio-crypto driver

Hi Herbert, Would you please review and/or ack the virtio_crypto_algs.c? It is the realization of specified algs based on Linux Crypto Framework. Thanks! Regards, -Gonglei > -Original Message- > From: Gonglei (Arei) > Sent: Thursday, December 01, 2016 8:39 PM > To: