Re: [RFC Part2 PATCH v3 03/26] crypto: ccp: Add Secure Encrypted Virtualization (SEV) device support

2017-09-12 Thread Borislav Petkov
On Tue, Sep 12, 2017 at 10:32:13AM -0500, Brijesh Singh wrote: > The debug statement is very helpful during development, it gives me the full > view of what command we send to PSP, data dump of command buffer before and > after the request completion. e.g when dyndbg is enabled the output looks

Re: [RFC Part2 PATCH v3 03/26] crypto: ccp: Add Secure Encrypted Virtualization (SEV) device support

2017-09-12 Thread Brijesh Singh
Hi Boris, I will address all your feedback in next rev. On 09/12/2017 09:02 AM, Borislav Petkov wrote: ... You could make that more tabular like this: case SEV_CMD_INIT: return sizeof(struct sev_data_init); case SEV_CMD_PLATFORM_STATUS: return

Re: [RFC Part2 PATCH v3 03/26] crypto: ccp: Add Secure Encrypted Virtualization (SEV) device support

2017-09-12 Thread Borislav Petkov
Just a cursory review: more indepth after the redesign. On Mon, Jul 24, 2017 at 03:02:40PM -0500, Brijesh Singh wrote: > AMDs new Secure Encrypted Virtualization (SEV) feature allows the memory > contents of a virtual machine to be transparently encrypted with a key > unique to the guest VM. The

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-12 Thread Srishti Sharma
On Tue, Sep 12, 2017 at 2:49 PM, Dan Carpenter wrote: > On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: >> The use of volatile for the variable monitor_lock is unnecessary. >> >> Signed-off-by: Srishti Sharma >> --- >>

[PATCH] crypto: inside-secure - fix gcc-4.9 warnings

2017-09-12 Thread Arnd Bergmann
All older compiler versions up to gcc-4.9 produce these harmless warnings: drivers/crypto/inside-secure/safexcel_cipher.c:389:9: warning: missing braces around initializer [-Wmissing-braces] drivers/crypto/inside-secure/safexcel_cipher.c:389:9: warning: (near initialization for

[PATCH 1/2] crypto: stm32 - Fix uninitialized data usage

2017-09-12 Thread Arnd Bergmann
The error handling in stm32_hash_irq_thread passes uninitialized data into stm32_hash_finish_req, as gcc points out: drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_irq_thread': drivers/crypto/stm32/stm32-hash.c:1088:2: error: 'err' may be used uninitialized in this function

Re: [PATCH] Staging: ccree: Don't use volatile for monitor_lock

2017-09-12 Thread Dan Carpenter
On Mon, Sep 11, 2017 at 09:29:31PM +0530, Srishti Sharma wrote: > The use of volatile for the variable monitor_lock is unnecessary. > > Signed-off-by: Srishti Sharma > --- > drivers/staging/ccree/ssi_request_mgr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >

Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

2017-09-12 Thread Stephan Mueller
Am Dienstag, 12. September 2017, 11:07:26 CEST schrieb Christophe LEROY: Hi Christophe, > Hi again > > Le 12/09/2017 à 09:22, Stephan Mueller a écrit : > > Am Dienstag, 12. September 2017, 09:20:41 CEST schrieb Stephan Mueller: > >> I am thinking now to add AC_PREREQ([2.60]) to configure.ac. >

Re: [PATCH 0/3] padata cpu awareness fixes

2017-09-12 Thread Steffen Klassert
On Fri, Sep 08, 2017 at 08:57:08PM +0200, Mathias Krause wrote: > Hi Steffen, Herbert, > > this series solves multiple issues of padata I ran into while trying to > make use of pcrypt for IPsec. > > The first issue is that the reorder timer callback may run on a CPU that > isn't part of the

Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

2017-09-12 Thread Christophe LEROY
Hi again Le 12/09/2017 à 09:22, Stephan Mueller a écrit : Am Dienstag, 12. September 2017, 09:20:41 CEST schrieb Stephan Mueller: I am thinking now to add AC_PREREQ([2.60]) to configure.ac. I meant 2.69, of course? :-) Ok ... CentOS ships with 2.63 and no update seems available via 'yum

Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

2017-09-12 Thread Christophe LEROY
Hi Stephan, Le 12/09/2017 à 09:20, Stephan Mueller a écrit : Am Dienstag, 12. September 2017, 09:01:08 CEST schrieb Christophe LEROY: Hi Christophe, Hi Stephan Le 11/09/2017 à 21:17, Stephan Müller a écrit : Am Montag, 11. September 2017, 19:07:31 CEST schrieb christophe leroy: Hi

[PATCH] crypto: talitos - Don't provide setkey for non hmac hashing algs.

2017-09-12 Thread Christophe Leroy
Today, md5sum fails with error -ENOKEY because a setkey function is set for non hmac hashing algs, see strace output below: mmap(NULL, 378880, PROT_READ, MAP_SHARED, 6, 0) = 0x77f5 accept(3, 0, NULL) = 7 vmsplice(5,

Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

2017-09-12 Thread Stephan Mueller
Am Dienstag, 12. September 2017, 09:20:41 CEST schrieb Stephan Mueller: > I am thinking now to add AC_PREREQ([2.60]) to configure.ac. I meant 2.69, of course? :-) Ciao Stephan

Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

2017-09-12 Thread Stephan Mueller
Am Dienstag, 12. September 2017, 09:01:08 CEST schrieb Christophe LEROY: Hi Christophe, > Hi Stephan > > Le 11/09/2017 à 21:17, Stephan Müller a écrit : > > Am Montag, 11. September 2017, 19:07:31 CEST schrieb christophe leroy: > > > > Hi christophe, > > > >> Hello Stephan, > >> > >> I'm

Re: md5sum (from libkcapi) fails as splice() returns -ENOKEY

2017-09-12 Thread Christophe LEROY
Hi Stephan Le 11/09/2017 à 21:17, Stephan Müller a écrit : Am Montag, 11. September 2017, 19:07:31 CEST schrieb christophe leroy: Hi christophe, Hello Stephan, I'm trying to use md5sum from the latest libkcapi 0.14 and I getting a failure with return code -5. What am I missing ? See strace