Re: [PATCH v3 24/27] staging: ccree: use a consistent file naming convention

2018-01-08 Thread Gilad Ben-Yossef
On Mon, Jan 8, 2018 at 5:28 PM, Greg Kroah-Hartman wrote: > On Sun, Jan 07, 2018 at 12:14:35PM +, Gilad Ben-Yossef wrote: >> The ccree driver source files were using an inconsistent >> naming convention stemming from what the company was called >> when they were

Re: [PATCH] crypto: clear htmldocs build warnings for crypto/hash

2018-01-08 Thread Herbert Xu
On Mon, Jan 08, 2018 at 05:43:18PM +0100, Kamil Konieczny wrote: > Is it mandatory for both async hash and shash ? > > in crypto/ahash.c in function > > static int crypto_ahash_init_tfm(struct crypto_tfm *tfm) > > there is: > > hash->export = ahash_no_export; > hash->import =

[PATCH V2 1/2] clk: imx: imx7d: add the snvs clock

2018-01-08 Thread Anson Huang
According to the i.MX7D Reference Manual, SNVS block has a clock gate, accessing SNVS block would need this clock gate to be enabled, add it into clock tree so that SNVS module driver can operate this clock gate. Signed-off-by: Anson Huang --- no changes since v1.

[PATCH V2 2/2] ARM: dts: imx7s: add snvs rtc clock

2018-01-08 Thread Anson Huang
Add i.MX7 SNVS RTC clock. Signed-off-by: Anson Huang --- changes since v1: update snvs lp rtc binding-doc for clock info. Documentation/devicetree/bindings/crypto/fsl-sec4.txt | 16 arch/arm/boot/dts/imx7s.dtsi | 2 ++ 2

Re: [PATCH 8/8] net: tipc: remove unused hardirq.h

2018-01-08 Thread Yang Shi
On 1/5/18 7:17 AM, David Miller wrote: From: "Yang Shi" Date: Fri, 05 Jan 2018 06:46:48 +0800 Any more comment on this change? These patches were not really submitted properly. If you post a series, the series goes to one destination and one tree. If they are

Re: [PATCH] crypto: clear htmldocs build warnings for crypto/hash

2018-01-08 Thread Kamil Konieczny
On 08.01.2018 16:56, Herbert Xu wrote: > On Mon, Jan 08, 2018 at 02:11:21PM +0100, Kamil Konieczny wrote: >> >> >> On 07.01.2018 00:01, Tobin C. Harding wrote: >>> SPHINX build emits multiple warnings of kind: >>> >>> warning: duplicate section name 'Note' >>> >>> (when building kernel via

Re: [PATCH v3 24/27] staging: ccree: use a consistent file naming convention

2018-01-08 Thread Greg Kroah-Hartman
On Sun, Jan 07, 2018 at 12:14:35PM +, Gilad Ben-Yossef wrote: > The ccree driver source files were using an inconsistent > naming convention stemming from what the company was called > when they were added. > > Move to a single consistent naming convention for better > code readability. > >

Re: [PATCH] staging: ccree: ssi_hash: remove unnecessary parentheses

2018-01-08 Thread Greg KH
On Thu, Dec 28, 2017 at 12:24:17PM +0200, Elad Wexler wrote: > Fixed a coding style issue > > Signed-off-by: Elad Wexler > --- > drivers/staging/ccree/ssi_hash.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Why did you send this twice? > diff --git

Re: [PATCH v2] hwrng: Clean up RNG list when last hwrng is unregistered

2018-01-08 Thread Gary R Hook
On 01/07/2018 11:05 PM, Herbert Xu wrote: On Fri, Jan 05, 2018 at 11:28:23AM -0600, Gary R Hook wrote: It may not have been obvious from the title but this fixes a bug which will impact the use of any HW RNG that is the only RNG registered. The breakage of rmmod/modprobe -r that this fix

Re: [PATCH] checkpatch: add *_ON_STACK to $declaration_macros

2018-01-08 Thread Gilad Ben-Yossef
On Wed, Dec 20, 2017 at 11:41 AM, Joe Perches wrote: > On Tue, 2017-06-27 at 10:55 +0300, Gilad Ben-Yossef wrote: >> Add the crypto API *_ON_STACK to $declaration_macros. >> >> Resolves the following false warning: >> >> WARNING: Missing a blank line after declarations >> +