Re: [PATCH 1/2] dt-bindings: crypto: hip07-sec, drop incorrect commas

2018-09-26 Thread Rob Herring
On Wed, Sep 12, 2018 at 05:07:17PM +0100, Jonathan Cameron wrote: > There should not be a comma in the address used for the instance > so drop them. > > This is a left over from a review of the final version before > Herbert Xu picked the series up. > > Reported-by: Rob Herring > Signed-off-by:

Re: [PATCH] crypto: qat - move temp buffers off the stack

2018-09-26 Thread Arnd Bergmann
On Wed, Sep 26, 2018 at 5:43 PM Kees Cook wrote: > On Wed, Sep 26, 2018 at 2:51 AM, Ard Biesheuvel > wrote: > > I think the depth warning is minor (90 bytes over), so I don't think > it's high priority to backport the fix. I'm fine either way, of > course. The way I see these warnings,

Re: [PATCH net-next v6 07/23] zinc: ChaCha20 ARM and ARM64 implementations

2018-09-26 Thread Jason A. Donenfeld
On Wed, Sep 26, 2018 at 5:42 PM Ard Biesheuvel wrote: > > On Wed, 26 Sep 2018 at 16:02, Ard Biesheuvel > wrote: > Actually, looking at the code again, the abstraction does appear to be > fine, it is just the chacha20 code that does not make use of it. So what you have in mind is something like

Re: [PATCH] crypto: qat - move temp buffers off the stack

2018-09-26 Thread Kees Cook
On Wed, Sep 26, 2018 at 2:51 AM, Ard Biesheuvel wrote: > Arnd reports that with Kees's latest VLA patches applied, the HMAC > handling in the QAT driver uses a worst case estimate of 160 bytes > for the SHA blocksize, allowing the compiler to determine the size > of the stack frame at runtime and

Re: [RFC] crypto: mxs-dcp - Implement sha import/export

2018-09-26 Thread Fabio Estevam
Hi Leonard, On Wed, Sep 26, 2018 at 7:31 AM, Leonard Crestez wrote: > That's not very easy since I don't know much about crypto api and don't > understand the patches. From what I do know some of them look a bit I am in the same position too :-) > dubious, I'm not sure those issues can't be

Re: [RFC] crypto: mxs-dcp - Implement sha import/export

2018-09-26 Thread Leonard Crestez
On Fri, 2018-09-21 at 19:09 -0300, Fabio Estevam wrote: > On Fri, Sep 21, 2018 at 5:13 PM, Leonard Crestez > wrote: > > The mxs-dcp driver fails to probe if sha1/sha256 are supported: > > > > [2.455404] mxs-dcp 80028000.dcp: Failed to register sha1 hash! > > [2.464042] mxs-dcp: probe of

Re: [PATCH] crypto: qat - move temp buffers off the stack

2018-09-26 Thread Ard Biesheuvel
On Wed, 26 Sep 2018 at 11:53, Ard Biesheuvel wrote: > > Arnd reports that with Kees's latest VLA patches applied, the HMAC > handling in the QAT driver uses a worst case estimate of 160 bytes > for the SHA blocksize, allowing the compiler to determine the size > of the stack frame at runtime and