Remove redundant blank lines in brace blocks
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 2 --
drivers/staging/ccree/ssi_buffer_mgr.c | 8
drivers/staging/ccree/ssi_cipher.c | 5 -
drivers/staging/ccree/ssi_driver.c | 1 -
drivers
Fix mismatched braces between if and else.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 3 ++-
drivers/staging/ccree/ssi_cipher.c | 7 +++
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c
b/drivers
Remove explicit comparisons to NULL in ccree driver.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 34 -
drivers/staging/ccree/ssi_buffer_mgr.c | 44 -
drivers/staging/ccree/ssi_cipher.c | 12
Replace custom type ssi_fips_error_t with underlying enum.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_fips.c | 4 ++--
drivers/staging/ccree/ssi_fips.h | 6 +++---
drivers/staging/ccree/ssi_fips_ext.c | 6 +++---
drivers/staging/ccree/ssi_fips_ll.c| 30
Replace custom type ssi_fips_state_t with underlying enum.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_fips.c | 4 ++--
drivers/staging/ccree/ssi_fips.h | 6 +++---
drivers/staging/ccree/ssi_fips_ext.c | 6 +++---
drivers/staging/ccree/ssi_fips_local.c | 8
Replace references to type tdes_keys_t with struct tdes_keys.
_
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_cipher.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c
b/drivers/staging/ccree/ssi_cipher.c
index b4fc9a6
Align block comments according to coding style.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index
Remove or add blank lines as needed to match coding style.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 20 +--
drivers/staging/ccree/ssi_aead.h| 4
drivers/staging/ccree/ssi_buffer_mgr.c | 7 ---
drivers/staging/ccree
The CCFipsSyncStatus_t type was not being used in the code.
Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_fips_local.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/ccree/ssi_fips_local.h
b/drivers/staging/ccree/ssi_fips_local.h
index
Fix cases where the else clause was not located correctly after the if
brace.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 3 +--
drivers/staging/ccree/ssi_pm.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree
Add and/or remove redundant and/or missing spaces in ccree source
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Kconfig | 2 +-
drivers/staging/ccree/ssi_aead.c| 38
drivers/staging/ccree/ssi_aead.h| 12 +--
drivers/staging/ccree
Fix cases in ccree where explicit comparsion to true/false
was made.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c | 18 +-
drivers/staging/ccree/ssi_buffer_mgr.c | 20 ++--
drivers/staging/ccree/ssi_cipher.c | 2 +-
drivers
Fix location of pointer in variables definitions and dereference.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.h| 4 ++--
drivers/staging/ccree/ssi_buffer_mgr.c | 12 ++--
drivers/staging/ccree/ssi_cipher.c | 8
drivers/staging/ccree
Fix a bunch of coding style across the whole ccree driver
Gilad Ben-Yossef (14):
staging: ccree: fix missing or redundant spaces
staging: ccree: drop comparsion to true/false
staging: ccree: fix else placement
staging: ccree: remove redundant blank lines
staging: ccree: no need for
Hash import and export was saving and restoring the wrong context
and therefore disabled. Fix it by restoring intermediate digest
and additional state needed.
The hash and mac transform now pass testmgr partial hash tests.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c
registering
a setkey method only for MAC transformations, leaving it out
for non-MAC ones, whether they are hash based on not.
Fixes: 50cfbbb7e627 ("staging: ccree: add ahash support").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_h
The function set_ack_last was not used anywhere. Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index
ll HW driver").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_request_mgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging/ccree/ssi_request_mgr.c
index 7c2d88a..2c6937a 100644
--- a/drivers/sta
Some SoC which implement CryptoCell have a dedicated clock
tied to it, some do not. Implement clock support if exists
based on device tree data and tie power management to it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging/ccree/ssi_driver.c | 43
The ccree driver has build time configurable support
to work on top of coherent (e.g. ACP) vs. none coherent bus
connections. Turn it to run-time configurable option
based on device tree.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Kconfig | 9 -
drivers/staging
An assortment of bug fixes and staging TODO items.
Highlights includes the driver passing crypto testmgr boot tests
and relying on device tree for various HW config options as
opposed to build time configuration.
CC: Dan Carpenter
Gilad Ben-Yossef (6):
staging: ccree: fix hash import/export
On Fri, Jun 23, 2017 at 7:29 PM, Greg Kroah-Hartman
wrote:
> On Thu, Jun 22, 2017 at 04:36:56PM +0300, Gilad Ben-Yossef wrote:
>> Fix a bug where the transformation init code did
>> not register a setkey method for none hash based MACs.
>
> "none hash based MACs"?
On Thu, Jun 22, 2017 at 4:58 PM, Dan Carpenter wrote:
> On Thu, Jun 22, 2017 at 04:36:55PM +0300, Gilad Ben-Yossef wrote:
>> static int ssi_ahash_export(struct ahash_request *req, void *out)
>> {
>> struct crypto_ahash *ahash = crypto_ahash_reqtfm(req);
>>
On Tue, Jun 20, 2017 at 5:51 PM, Jhih-Ming Huang wrote:
>
> Hi,
>
> This patch fix all coding style error in driver/staging/ccree/ssi_aead.c.
For patches 1-6:
Acked-by: Gilad Ben-Yossef
Thanks you,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in lar
On Sat, Jun 17, 2017 at 5:44 AM, Derek Robson wrote:
> Changed code indent to be tabs across whole driver
> Found using checkpatch
>
> Signed-off-by: Derek Robson
>
> V1 had vague subject.
Acked-by: Gilad Ben-Yossef
Thanks you,
Gilad
--
Gilad Ben-Yossef
Chief Coffee Dri
Hash import and export was saving and restoring the wrong context
and therefore disabled. Fix it by restoring intermediate digest
and additional state needed.
The hash and mac transform now pass testmgr partial hash tests.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c
same driver.
- Address Dan Carpenter style review comments
- Fix clk de-init being called on clk init failure
error path pointed out by Dan Carpenter.
Gilad Ben-Yossef (7):
staging: ccree: fix hash import/export
staging: ccree: register setkey for none hash macs
staging: ccree: add support
Add support for the older CryptoCell 710 and 630P hardware revisions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Kconfig| 7 +-
drivers/staging/ccree/cc_crypto_ctx.h| 16 ---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging/ccree/cc_regs.h
The ccree driver has build time configurable support
to work on top of coherent (e.g. ACP) vs. none coherent bus
connections. Turn it to run-time configurable option
based on device tree.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 37
Some SoC which implement CryptoCell have a dedicated clock
tied to it, some do not. Implement clock support if exists
based on device tree data and tie power management to it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging/ccree/ssi_driver.c | 40
The function set_ack_last was not used anywhere. Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index
Fix a bug where the transformation init code did
not register a setkey method for none hash based MACs.
Fixes commit 50cfbbb7e627 ("staging: ccree: add ahash support").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 83 --
ll HW driver").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_request_mgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging/ccree/ssi_request_mgr.c
index cffc8de..87f5ab6 100644
--- a/drivers/sta
On Thu, Jun 22, 2017 at 12:04 PM, Dan Carpenter
wrote:
> On Thu, Jun 22, 2017 at 10:07:52AM +0300, Gilad Ben-Yossef wrote:
>> The ccree driver has build time configurable support
>> to work on top of coherent (e.g. ACP) vs. none coherent bus
>> connections. Turn it to run-tim
On Thu, Jun 22, 2017 at 11:58 AM, Dan Carpenter
wrote:
> On Thu, Jun 22, 2017 at 10:07:51AM +0300, Gilad Ben-Yossef wrote:
>> +int cc_clk_on(struct ssi_drvdata *drvdata)
>> +{
>> + int rc = 0;
>> + struct clk *clk = drvdata->clk;
>> +
>> + i
On Thu, Jun 22, 2017 at 11:28 AM, Dan Carpenter
wrote:
> On Thu, Jun 22, 2017 at 10:14:08AM +0300, Gilad Ben-Yossef wrote:
>> On Thu, Jun 22, 2017 at 10:07 AM, Gilad Ben-Yossef
>> wrote:
>> > An assortment of bug fixes and staging TODO items.
>> > Highlights i
On Thu, Jun 22, 2017 at 10:07 AM, Gilad Ben-Yossef wrote:
> An assortment of bug fixes and staging TODO items.
> Highlights includes the driver passing crypto testmgr boot tests
> and support of multiple HW revs. without build time changes.
>
> Gilad Ben-Yossef (7):
> stagin
The function set_ack_last was not used anywhere. Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 12
1 file changed, 12 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index
Fix a bug where the transformation init code did
not register a setkey method for none hash based MACs.
Fixes commit 50cfbbb7e627 ("staging: ccree: add ahash support").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 83 --
Add support for the older CryptoCell 710 and 630P hardware revisions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Kconfig| 7 +-
drivers/staging/ccree/cc_crypto_ctx.h| 16 ---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging/ccree/cc_regs.h
The ccree driver has build time configurable support
to work on top of coherent (e.g. ACP) vs. none coherent bus
connections. Turn it to run-time configurable option
based on device tree.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c | 37
ll HW driver").
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_request_mgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_request_mgr.c
b/drivers/staging/ccree/ssi_request_mgr.c
index cffc8de..87f5ab6 100644
--- a/drivers/sta
Some SoC which implement CryptoCell have a dedicated clock
tied to it, some do not. Implement clock support if exists
based on device tree data and tie power management to it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/Makefile | 2 +-
drivers/staging/ccree/ssi_driver.c | 43
Hash import and export was saving and restoring the wrong context
and therefore disabled. Fix it by restoring intermediate digest
and additional state needed.
The hash and mac transform now pass testmgr partial hash tests.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c
An assortment of bug fixes and staging TODO items.
Highlights includes the driver passing crypto testmgr boot tests
and support of multiple HW revs. without build time changes.
Gilad Ben-Yossef (7):
staging: ccree: fix hash import/export
staging: ccree: register setkey for none hash macs
errors at the same time, making it
difficult to review, so unfortunately it has to be rejected as it is now.
Please feel free to send a series of patches each fixing a different style error
instead.
Thanks,
Gilad
> Thanks
>
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a c
On Sat, Jun 10, 2017 at 6:43 AM, Herbert Xu wrote:
> On Mon, May 29, 2017 at 11:22:48AM +0300, Gilad Ben-Yossef wrote:
>>
>> +static inline int crypto_wait_req(int err, struct crypto_wait *wait)
>> +{
>> + switch (err) {
>> + case -
ll HW driver").
Signed-off-by: Gilad Ben-Yossef
---
Please roll this patch into 4.12-rc5 if possible.
drivers/staging/ccree/ssi_buffer_mgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/ssi_buffer_mgr.c
b/drivers/staging/ccree/ssi_buffer_m
Fix inconsistent format and spelling in hash tests error messages.
Signed-off-by: Gilad Ben-Yossef
---
crypto/testmgr.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/crypto/testmgr.c b/crypto/testmgr.c
index 6f5f3ed..8c68c99 100644
--- a/crypto/testmgr.c
Remove no longer needed code used to simulate 48 bit dma addresses
on 32 bit platforms for development purposes.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 19
drivers/staging/ccree/ssi_buffer_mgr.c | 83 -
drivers
.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_lli_defs.h| 39 ++
drivers/staging/ccree/ssi_buffer_mgr.c | 8 +++
2 files changed, 25 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/ccree/cc_lli_defs.h
b/drivers/staging/ccree
request_mgr was using custom bit field macros. move over to
standard kernel bitfield ops.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_regs.h | 5 +
drivers/staging/ccree/ssi_request_mgr.c | 27 +--
2 files changed, 22 insertions(+), 10
The ccree driver had support for rough performance debugging
via cycle counting which has bit rotted and can easily be
replcaed with perf. Remove it from the driver.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 14
drivers/staging/ccree/ssi_aead.c
struct SepHashPrivateContext is not used anywhere in the code.
Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/hash_defs.h | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/ccree/hash_defs.h
b/drivers/staging/ccree/hash_defs.h
index
Hash enum were named using CamelCase, move over to snake_case.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 4 ++--
drivers/staging/ccree/hash_defs.h| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree
MSB64 macro is no longer used or needed. Drop it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index 1cbd2e1..aaa56c8 100644
Remove some unused macro definitions from hash definitions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/hash_defs.h | 31 +++
1 file changed, 3 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/ccree/hash_defs.h
b/drivers/staging/ccree
With all users removed or re-factored to use the standard
kernel bit fields ops we can now drop the custom
bit field macros.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_bitops.h| 39 --
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging
Remove spurious blank line from cc_regs.h
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_regs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_regs.h b/drivers/staging/ccree/cc_regs.h
index 53675e3..4a893a6 100644
--- a/drivers/staging/ccree/cc_regs.h
The hash code had some left overs from a misguided attempt
to support shash API with the HW. Remove the code handling
this.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_hash.c | 448 +++
1 file changed, 127 insertions(+), 321 deletions
Remove definitions of descriptor context which are not used
in the driver.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 86 ---
1 file changed, 86 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging
Some of the register definition files had none
kernel coding style usage of tabs vs. spaces in macro
definitions. This patch fixes them.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/dx_crys_kernel.h | 308 -
drivers/staging/ccree/dx_host.h
The cipher code had some left overs of an attempt to support
synch. cipher API with the HW. Remove the code handling this.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_cipher.c | 102 +++--
drivers/staging/ccree/ssi_driver.h | 1 -
2 files
A bunch of macros used to define M/LLI descriptors where
being defined in the C file. Move them over to private
include file where other relevant definitions are stored.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_lli_defs.h| 8
drivers/staging/ccree
The DUMP_SGL() and DUMP_MLLI_TABLE() debug macros were
defined but not used anywhere and the difference of their
definitions for debug vs. none debug indicated this has
not being used in a while.
Remove the dead code.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c
CC_CTX_SIZE was being defined using a hand rolled bit shift operation.
Replace with use of BIT macro.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers
the patches
- Better line breakup for code clarity as suggested by Joe Perches
Gilad Ben-Yossef (18):
staging: ccree: replace bit shift with BIT macro
staging: ccree: refactor HW command FIFO access
staging: ccree: remove 48 bit dma addr sim
staging: ccree: refactor LLI access macros
stagin
On Sat, Jun 3, 2017 at 11:46 AM, Greg Kroah-Hartman
wrote:
> On Thu, Jun 01, 2017 at 02:02:52PM +0300, Gilad Ben-Yossef wrote:
>> CC_CTX_SIZE was being defined using a hand rolled bit shift operation.
>> Replace with use of BIT macro.
>>
>> Signed-off-by: Gilad Ben
Remove spurious blanks lines from cc_crypto_ctx.h file
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_ctx.h
index ac39d34..9bfadb21 100644
Clip longer than 80 chars lines in header files worked
on in the patch set.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 3 ++-
drivers/staging/ccree/cc_regs.h | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ccree
cc_crypto_ctx.h file had a few macro definitions with missing
spaces around operators. Add missing spaces.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/ccree
CC_CTX_SIZE was being defined using a hand rolled bit shift operation.
Replace with use of BIT macro.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers
A few of the comments in cc_crypto_ctx.h where not formatted
correctly. Format according to coding style guidelines.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 19 +++
1 file changed, 11 insertions(+), 8 deletions(-)
diff --git a/drivers/staging
.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_lli_defs.h| 39 ++
drivers/staging/ccree/ssi_buffer_mgr.c | 8 +++
2 files changed, 25 insertions(+), 22 deletions(-)
diff --git a/drivers/staging/ccree/cc_lli_defs.h
b/drivers/staging/ccree
Remove no longer needed code used to simulate 48 bit dma addresses
on 32 bit platforms for development purposes.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_aead.c| 19
drivers/staging/ccree/ssi_buffer_mgr.c | 83 -
drivers
The ccree driver had support for rough performance debugging
via cycle counting which has bit rotted and can easily be
replcaed with perf. Remove it from the driver.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 14
drivers/staging/ccree/ssi_aead.c
struct SepHashPrivateContext is not used anywhere in the code.
Remove it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/hash_defs.h | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/staging/ccree/hash_defs.h
b/drivers/staging/ccree/hash_defs.h
index
With all users removed or re-factored to use the standard
kernel bit fields ops we can now drop the custom
bit field macros.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_bitops.h| 39 ---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 +-
drivers/staging
Remove spurious blank line from cc_regs.h
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_regs.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_regs.h b/drivers/staging/ccree/cc_regs.h
index e83938b..915c863 100644
--- a/drivers/staging/ccree/cc_regs.h
MSB64 macro is no longer used or needed. Drop it.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/ccree/cc_hw_queue_defs.h
b/drivers/staging/ccree/cc_hw_queue_defs.h
index 1cbd2e1..aaa56c8 100644
Hash enum were named using CamelCase, move over to snake_case.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_hw_queue_defs.h | 4 ++--
drivers/staging/ccree/hash_defs.h| 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/ccree
Some of the register definition files had none
kernel coding style usage of tabs vs. spaces in macro
definitions. This patch fixes them.
Remove some unused macro definitions from hash definitions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/dx_crys_kernel.h | 308
Remove some unused macro definitions from hash definitions.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/hash_defs.h | 31 +++
1 file changed, 3 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/ccree/hash_defs.h
b/drivers/staging/ccree
The DUMP_SGL() and DUMP_MLLI_TABLE() debug macros were
defined but not used anywhere and the difference of their
definitions for debug vs. none debug indicated this has
not being used in a while.
Remove the dead code.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/ssi_buffer_mgr.c
request_mgr was using custom bit field macros. move over to
standard kernel bitfield ops.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_regs.h | 5 +
drivers/staging/ccree/ssi_request_mgr.c | 25 +++--
2 files changed, 20 insertions(+), 10
Add parentheses around macro argument to guard against precedence
issues.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_crypto_ctx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ccree/cc_crypto_ctx.h
b/drivers/staging/ccree/cc_crypto_ctx.h
A bunch of macros used to define M/LLI descriptors where
being defined in the C file. Move them over to private
include file where other relevant definitions are stored.
Signed-off-by: Gilad Ben-Yossef
---
drivers/staging/ccree/cc_lli_defs.h| 8
drivers/staging/ccree
indicated by GregKH
- Better description for some of the patches
- Better line breakup for code clarity as suggested by Joe Perches
Gilad Ben-Yossef (20):
staging: ccree: remove spurious blank lines
staging: ccree: replace bit shift with BIT macro
staging: ccree: fix longer than 80 c
On Mon, May 29, 2017 at 8:36 PM, Joe Perches wrote:
> On Mon, 2017-05-29 at 20:11 +0300, Gilad Ben-Yossef wrote:
>> On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote:
>> > On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote:
>> > > On Sun, May 28, 2017
On Mon, May 29, 2017 at 5:41 PM, Greg Kroah-Hartman
wrote:
> On Sun, May 28, 2017 at 05:40:29PM +0300, Gilad Ben-Yossef wrote:
>> The Linked List Item descriptors were being accessed via
>> a baroque set of defines and macro. Re-factor for structs
>> and inline function for r
On Mon, May 29, 2017 at 5:38 PM, Greg Kroah-Hartman
wrote:
> On Sun, May 28, 2017 at 05:40:27PM +0300, Gilad Ben-Yossef wrote:
>> ccree had a lot of boilerplate code for dealing with bitops
>> and bitfield register access. Move it over to the generic kernel
>> infrastructu
On Mon, May 29, 2017 at 7:57 PM, Joe Perches wrote:
> On Mon, 2017-05-29 at 16:37 +0200, Greg Kroah-Hartman wrote:
>> On Sun, May 28, 2017 at 05:40:26PM +0300, Gilad Ben-Yossef wrote:
>> > cc_crypto_ctx.h had multiple coding style violations reported by
>> > checkpatch
gcm is starting an async. crypto op and waiting for it complete.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef
---
crypto/gcm.c | 32 ++--
1 file changed, 6 insertions(+), 26 deletions(-)
diff --git a/crypto/gcm.c b/crypto/gcm.c
index
algif starts several async crypto ops and waits for their completion.
Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef
---
crypto/af_alg.c | 27 ---
crypto/algif_aead.c | 14 +++---
crypto/algif_hash.c | 29
the
completion of the request any way.
Signed-off-by: Gilad Ben-Yossef
---
crypto/drbg.c | 34 --
include/crypto/drbg.h | 3 +--
2 files changed, 9 insertions(+), 28 deletions(-)
diff --git a/crypto/drbg.c b/crypto/drbg.c
index cdb27ac..101d9f0 100644
rolled versions.
Signed-off-by: Gilad Ben-Yossef
CC: Eric Biggers
CC: Ofir Drang
---
crypto/api.c | 13 +
include/linux/crypto.h | 41 +
2 files changed, 54 insertions(+)
diff --git a/crypto/api.c b/crypto/api.c
index 941cd4c
public_key_verify_signature() is starting an async crypto op and
waiting for it to complete. Move it over to generic code doing
the same.
Signed-off-by: Gilad Ben-Yossef
---
crypto/asymmetric_keys/public_key.c | 28
1 file changed, 4 insertions(+), 24 deletions
testmgr is starting async. crypto ops and waiting for them to complete.
Move it over to generic code doing the same.
This also provides a test of the generic crypto async. wait code.
Signed-off-by: Gilad Ben-Yossef
---
crypto/testmgr.c | 184
fscrypt starts several async. crypto ops and waiting for them to
complete. Move it over to generic code doing the same.
Signed-off-by: Gilad Ben-Yossef
---
fs/crypto/crypto.c | 28
fs/crypto/fname.c | 36 ++--
fs
async op finishing.
Signed-off-by: Gilad Ben-Yossef
---
drivers/md/dm-verity-target.c | 81 +++
drivers/md/dm-verity.h| 5 ---
2 files changed, 20 insertions(+), 66 deletions(-)
diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity
801 - 900 of 1003 matches
Mail list logo
