On Sun, Sep 15, 2024 at 05:15:25PM +0800, Herbert Xu wrote:
>
> Roberto, correct me if I'm wrong but your intended use case is
> the following patch series, right?
Actually the meat of the changes is in the following series:
https://lore.kernel.org/linux-integrity/2024090515
erto, correct me if I'm wrong but your intended use case is
the following patch series, right?
https://lore.kernel.org/linux-integrity/20240905152512.3781098-1-roberto.sa...@huaweicloud.com/
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://
e-case is bogus, then distro package
verification is going to be the only application for PGP keys in
the kernel.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
of guarantees.
Where is this discussion? I clicked through the two links above
and everyone seems to agree that putting it in user-space is a good
idea.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ing. If we really wanted to we could extend
the user-space verification to modules too and perhaps kick all
public key crypto out of the kernel.
The complexity and lack of reviewer attention in this area means
that we're more likely to introduce security holes into the kernel
with such cod
xposed outside of the kernel.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
drivers/crypto/nx/nx-842.h | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
drivers/crypto/intel/qat/qat_common/qat_bl.h | 2 ++
> 1 file changed, 2 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
kCFI is enabled.
>
> Cc: Kees Cook
> Cc: Linus Walleij
> Signed-off-by: Ard Biesheuvel
> ---
> arch/arm/crypto/crc32-ce-core.S | 17 +
> 1 file changed, 9 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.
>hash_algo) {
> + asn1 = rsa_lookup_asn1(params->hash_algo);
Could you please explain why this can't be done through pkcs1pad
instead of going to raw RSA?
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
emove this algorithm.
It can be resubmitted when it is integrated properly into the
asymmetric_keys subsystem.
Signed-off-by: Herbert Xu
---
crypto/Kconfig| 18 -
crypto/Makefile | 8 -
crypto/asymmetric_keys/pkcs7_parser.c | 4 -
c
ernel thread doing the same thing, but moreover random.c itself
has been modified so that it is no longer starved of entropy on
startup. There is no reason to feed any early randomness.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, May 22, 2024 at 02:51:36PM +0300, Jarkko Sakkinen wrote:
>
> What is the kthread doing this currently?
It's hwrng_fillfn.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
compared to
when the patch was first applied.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
gers
Fixes: 1b6d7f9eb150 ("tpm: add session encryption protection to
tpm2_get_random()")
Link: https://lore.kernel.org/r/119dc5ed-f159-41be-9dda-1a056f29888d@notapiano/
Signed-off-by: Herbert Xu
diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c
index f5c71a617a99
as F. R. A. Prado
Reported-by: Eric Biggers
Signed-off-by: Herbert Xu
---
crypto/api.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/crypto/api.c b/crypto/api.c
index 22556907b3bc..7c4b9f86c1ad 100644
--- a/crypto/api.c
+++ b/crypto/api.c
@@ -10,6 +10,7 @@
*
requires instantiation (anything with "()" in its
name).
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
no point and it may deadlock) until such a point where
all/most drivers have finished loading.
So if the algorithm is missing (which shouldn't happen because of
Kconfig selects), then it will simply fail.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
and all the required algorithms.
You can verify this with the failing .config file as it has
everything needed built into the kernel (which is in fact
where the problem is).
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
re
that it doesn't load modules if this is the case by checking
crypto_boot_test_finished().
Add a call to wait_for_device_probe so that the drivers that may
call into the Crypto API have finished probing.
Reported-by: NĂcolas F. R. A. Prado"
Reported-by: Eric Biggers
Signed-off-by: Herbert Xu
uct.
> ---
> crypto/rsa-pkcs1pad.c | 16 ++--
> include/crypto/rsa-pkcs1pad.h | 20
> 2 files changed, 30 insertions(+), 6 deletions(-)
> create mode 100644 include/crypto/rsa-pkcs1pad.h
Please provide a link to the patch that will make use of this.
Thank
On Wed, Apr 03, 2024 at 06:47:51PM +0300, Jarkko Sakkinen wrote:
>
> Reviewed-by: Jarkko Sakkinen
>
> I can only test that this does not break a machine without the
> hardware feature.
Please feel free to take this through your tree.
Thanks,
--
Email: Herbert Xu
ot at the end of another structure
> [-Wflex-array-member-not-at-end]
>
> Link: https://github.com/KSPP/linux/issues/202
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/crypto/intel/qat/qat_common/qat_bl.c | 6 --
> drivers/crypto/intel/qat/qat_common/qat_bl.h | 11 +
1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^~
>
> Signed-off-by: Gustavo A. R. Silva
> ---
> drivers/crypto/nx/nx-842.c | 6 --
> drivers/crypto/nx/nx-842.h | 10 ++
> 2 files changed, 10 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
rtio-crypto: implement RSA algorithm")
> Link:
> https://lore.kernel.org/all/0a194a79-e3a3-45e7-be98-83abd3e1c...@roeck-us.net/
> Signed-off-by: zhenwei pi
> ---
> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Patch
> Signed-off-by: Erick Archer
> ---
> drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ues/162
> Signed-off-by: Erick Archer
> ---
> drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
v2:
> A typo was fixed for the delimiter of a label.
>
> drivers/crypto/virtio/virtio_crypto_akcipher_algs.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
f-by: Gonglei
> ---
> drivers/crypto/virtio/virtio_crypto_core.c | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ta)
#endif
extern const struct seq_operations cpuinfo_op;
Please send this patch to the x86 people.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
drivers/crypto/virtio/virtio_crypto_core.c | 26 --
> 2 files changed, 18 insertions(+), 10 deletions(-)
Your patch has already been merged. So please send this as
an incremental patch.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
pe; and just for consistency, do the same for parameter `Xi`.
>
> Reported-by: Stephen Rothwell
> Closes:
> https://lore.kernel.org/linux-next/20231121131903.68a37...@canb.auug.org.au/
> Signed-off-by: Gustavo A. R. Silva
> ---
> arch/powerpc/crypto/aes-gcm-p10-glue.c
eletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
> include/soc/fsl/dcp.h| 17 +++
> 2 files changed, 110 insertions(+), 11 deletions(-)
> create mode 100644 include/soc/fsl/dcp.h
Acked-by: Herbert Xu
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> crypto/rsapubkey.asn1| 7 +++
> fs/smb/server/ksmbd_spnego_negtokeninit.asn1 | 8
> fs/smb/server/ksmbd_spnego_negtokentarg.asn1 | 7 +++++++
> net/ipv4/netfilter/nf_nat_snmp_basic.asn1| 8
> 9 files changed, 62 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
384 curve is used, force using either SHA384 or SHA512.
>
> Signed-off-by: Dimitri John Ledkov
> ---
> certs/Kconfig | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key:
384 curve is used, force using either SHA384 or SHA512.
>
> Signed-off-by: Dimitri John Ledkov
> ---
> certs/Kconfig | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key:
gt; sha224 being introduced.
>
> Signed-off-by: Dimitri John Ledkov
> ---
> kernel/module/Kconfig | 5 -
> 1 file changed, 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ic_keys/signature.c| 2 +-
> crypto/asymmetric_keys/x509_cert_parser.c | 8 ---
> crypto/testmgr.h | 80 ---
> include/linux/oid_registry.h | 4 --
> kernel/module/Kconfig | 5 --
> 8 files changed, 2
; (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
> functions).
>
> As found with Coccinelle[1], add __counted_by for struct adf_fw_counters.
>
> [1]
> https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
>
> Cc
; drivers/crypto/intel/qat/qat_common/qat_uclo.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
off-by: Justin Stitt
> ---
> Note: build-tested only.
> ---
> drivers/crypto/cavium/nitrox/nitrox_hal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
T
> ---
> crypto/crc32_generic.c | 24 +---
> 1 file changed, 1 insertion(+), 23 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
g
> Fixes: d8f1308a025f ("crypto: arm/curve25519 - wire up NEON implementation")
> Link: https://github.com/ClangBuiltLinux/continuous-integration2/issues/118
> Reported-by: Arnd Bergmann
> Suggested-by: Arnd Bergmann
> Suggested-by: Jessica Clarke
> Signed-off-b
silicon/hpre - add debug log
>
> drivers/crypto/hisilicon/hpre/hpre_crypto.c | 11 +--
> drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++--
> 2 files changed, 11 insertions(+), 4 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.
c | 40 +++
> .../crypto/qat/qat_common/adf_gen4_hw_data.h | 14 ++-
> drivers/crypto/qat/qat_common/adf_init.c | 4 ++
> 9 files changed, 99 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
le changed, 31 insertions(+), 6 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
3 files changed, 6 insertions(+), 6 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
.c | 2 +-
> 4 files changed, 4 insertions(+), 4 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Apr 08, 2021 at 11:21:51AM +0800, Tian Tao wrote:
> Remove including that don't need it.
>
> Signed-off-by: Tian Tao
> Signed-off-by: Zhiqi Song
> ---
> drivers/crypto/cavium/zip/common.h | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Em
re.c | 1 -
> 7 files changed, 3 insertions(+), 15 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
off-by: Weili Qian
> ---
> drivers/crypto/hisilicon/trng/trng.c | 13 ++---
> 1 file changed, 10 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ypto/hisilicon/qm.c | 29 -
> 1 file changed, 28 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
t; ---
> drivers/crypto/ixp4xx_crypto.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> drivers/crypto/geode-aes.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> v1 -> v2: Modify the 'Fixes tag' from '14bb76768275' to '4e6602916bc6 '.
>
> ---
> crypto/ecc.h | 8 ----
> 1 file changed, 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
-by: Hui Tang
> ---
> drivers/crypto/hisilicon/hpre/hpre_crypto.c | 18 ++
> 1 file changed, 18 insertions(+)
This triggers new sparse warnings.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Herbert.
I don't mind at all. Paolo you can take this through your tree.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
on/adf_transport.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
("crypto: chelsio - Use multiple txq/rxq per tfm to
> process the requests)
> Signed-off-by: Ayush Sawal
> ---
> drivers/crypto/chelsio/chcr_algo.c | 19 +--
> 1 file changed, 17 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
v1 -> v2:
> Re-edit the description.
>
> drivers/crypto/hisilicon/qm.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ons(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
o: sa2ul - Fix DMA mapping API usage")
> Signed-off-by: Colin Ian King
> ---
>
> V2: Fix typo in $SUBJECT
>
> ---
> drivers/crypto/sa2ul.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://
uot;crypto: sun8i-ss - support hash algorithms")
> Signed-off-by: Colin Ian King
> ---
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apan
On Thu, Apr 01, 2021 at 11:01:39AM +0800, Kai Ye wrote:
> Delete unneeded variable initialization
>
> Signed-off-by: Kai Ye
> ---
> drivers/crypto/rockchip/rk3288_crypto_ahash.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Her
o-main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
letion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
d-off-by: Jiapeng Chong
> ---
> drivers/crypto/ccp/ccp-ops.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
need to register the kernel mode algorithms.
>
> Signed-off-by: Longfang Liu
> ---
>
> Changes in V2:
> - Add algorithms unregistration processing
>
> drivers/crypto/hisilicon/sec2/sec_main.c | 17 -
> 1 file changed, 12 insertions(+), 5 deletions(-)
Pa
ers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ms")
> Signed-off-by: Corentin Labbe
> ---
> drivers/crypto/allwinner/Kconfig | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[i].page_ctrl = NULL;
> + hw_sge[i].buf = 0;
> + hw_sge[i].len = 0;
> + }
> +}
This causes a new sparse warning:
CHECK ../drivers/crypto/hisilicon/sgl.c
../drivers/crypto/hisilicon/sgl.c:200:31: warning: restricted __le16 degrades
to integer
Please
rs/crypto/chelsio/chcr_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
This patch doesn't apply against cryptodev. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
that the patch is in fact changing behaviour.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
r to improve the code.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
---
> crypto/api.c | 20
> 1 file changed, 12 insertions(+), 8 deletions(-)
Please don't mix unrelated changes in a single patch.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
off-by: Jiapeng Chong
> ---
> crypto/deflate.c | 1 -
> 1 file changed, 1 deletion(-)
The function might not do anything today but the documentation
clearly indicates that it could free any dynamically allocated
data so it should stay.
Cheers,
--
Email: Herbert Xu
Home Page: htt
d for this patch
for now.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
y: Longfang Liu
> ---
> drivers/crypto/hisilicon/sec2/sec_crypto.c | 37
> ++
> 1 file changed, 32 insertions(+), 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
reduced modulo the field prime'
> So we get its modulus to p, and then deal it with HPRE.
>
> Signed-off-by: Meng Yu
> ---
> drivers/crypto/hisilicon/hpre/hpre_crypto.c | 22 ++
> 1 file changed, 18 insertions(+), 4 deletions(-)
Patch applied. Thanks.
les changed, 3 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Sat, Mar 27, 2021 at 04:32:08PM +0800, Hui Tang wrote:
> s/shoul/should/
>
> Signed-off-by: Hui Tang
> ---
> drivers/crypto/hisilicon/hpre/hpre_main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert X
ions(+), 25 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
gt; lib/crypto/poly1305-donna64.c | 3 ++-
> lib/crypto/poly1305.c | 3 ++-
> 9 files changed, 18 insertions(+), 12 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ivers/crypto/hisilicon/zip/zip.h| 46 +-
> drivers/crypto/hisilicon/zip/zip_crypto.c | 706
> +-
> 2 files changed, 438 insertions(+), 314 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
file changed, 1 insertion(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| 6 +++---
> drivers/crypto/hisilicon/sec/sec_drv.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ntel(R) QAT DH895xcc accelerator")
> Signed-off-by: Giovanni Cabiddu
> Reviewed-by: Marco Chiappero
> ---
> drivers/crypto/qat/qat_common/adf_isr.c | 29 ++---
> 1 file changed, 21 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home P
h applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
o
> Reviewed-by: Andy Lutomirski
> Acked-by: Ard Biesheuvel
> Signed-off-by: Eric Biggers
> ---
> drivers/char/random.c | 17 ++-
> include/trace/events/random.h | 83 ---
> 2 files changed, 3 insertions(+), 97 deletions(-)
> ChaCha20 anymore. Fix it to always use the standard constants.
>
> Cc: linux-crypto@vger.kernel.org
> Cc: Andy Lutomirski
> Cc: Jann Horn
> Cc: Theodore Ts'o
> Acked-by: Herbert Xu
> Acked-by: Ard Biesheuvel
> Signed-off-by: Eric Biggers
> ---
>
gned-off-by: Eric Biggers
> ---
> crypto/rng.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
err(dev, "acpi_evaluate_dsm err.\n");
> -
> + hpre_cfg_by_dsm(qm);
> disable_flr_of_bme(qm);
> }
If the return value is non-zero you've just changed what this code
does from returning non-zero to returning zero. Are you sure about
this?
Thanks,
--
bug? Wouldn't the soft fallback setkey catch
this anyhow?
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
1 - 100 of 7859 matches
Mail list logo