>
> blocksize: 64
>
> digestsize : 16
>
> and I didnt see anything failed/unknow in /proc/crypto
>
> Why the failed algorithm is not visible ?
Please include the complete /proc/cry
acquire then I would have
no problems with everybody else following in its footsteps.
Here is the original patch in question:
https://lore.kernel.org/lkml/20200916233042.51634-1-ebigg...@kernel.org/
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Mon, Sep 21, 2020 at 08:27:14AM -0700, Paul E. McKenney wrote:
> On Mon, Sep 21, 2020 at 06:19:39PM +1000, Herbert Xu wrote:
> > On Thu, Sep 17, 2020 at 09:58:02AM -0700, Eric Biggers wrote:
> > >
> > > smp_load_acquire() is obviously correct, whereas READ_ONCE(
s line of reasoning, surely you should
be converting the RCU derference first and foremost, no?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
oCs on kernelCI.
I'll happily accept patches that fix the actual bug but not ones
just papering over it.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
t then the
macro CRYPTO_MINALIGN should cover it.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ag I can pull in to
> prevent merge issues in the future?
It's in the cryptodev tree, but unfortunately it's not in a
topic branch so you'd be pulling all other crypto changes along
with it.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
E failure get caught by the selftest?
If so please just leave it enabled so that it can be fixed properly.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
since v1:
> 1. Fix more warnings
> ---
> drivers/crypto/caam/caamalg_desc.c | 1 +
> drivers/crypto/caam/caamalg_qi2.c | 4 ++--
> drivers/crypto/caam/ctrl.c | 4 +++-
> drivers/crypto/caam/jr.c | 10 +-----
> 4 files changed, 11 insertions(+), 8 deletions(-
he joint coverage of their QA,
> we should be able to confirm that these algos are never used, and
> actually remove them altogether.
>
> crypto/Kconfig | 4
> 1 file changed, 4 insertions(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
pto/inside-secure/safexcel.h | 13 ++
> 2 files changed, 54 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
rpenter
> ---
> drivers/crypto/sa2ul.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
/qat_hal.c | 7 ---
> drivers/crypto/qat/qat_common/qat_uclo.c | 9 +
> drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 11 ---
> drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 11 ---
> 9 files changed, 33 insertions(+),
insertions(+), 9 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 1 file changed, 78 insertions(+), 108 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
oticed while transitioning to openssl 1.1 support.
>
> Fixes: 0d373d603202 ("crypto: omap-sham - Add OMAP4/AM33XX SHAM Support")
> Signed-off-by: Tero Kristo
> ---
> drivers/crypto/omap-sham.c | 3 +++
> 1 file changed, 3 insertions(+)
Patch applied. Thanks
-off-by: Pascal van Leeuwen
> ---
> drivers/crypto/inside-secure/safexcel_ring.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| 15
> drivers/crypto/hisilicon/zip/zip_crypto.c | 112 ++
> drivers/crypto/hisilicon/zip/zip_main.c | 126
> ++
> 3 files changed, 135 insertions(+), 118 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
{
> + msg->in = cpu_to_le64((u64)ctx->dh.dma_g);
Why do you need the u64 cast?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
that does the aligning for you.
Have a look at drivers/crypto/padlock-aes.c which does something
similar for the tfm ctx.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
posed to be another patch that contains test vectors?
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
/
> + if (pctx->entropy)
> + sk->sk_socket->ops = &algif_rng_test_ops;
> +
Please make that
if (IS_ENABLED(CONFIG_CRYPTO_USER_API_RNG_CAVP) && pctx->entropy)
so that this and the rest of the new code simply disappears when
the Kconfig option is of
config RTLLIB_CRYPTO_CCM
> config RTLLIB_CRYPTO_TKIP
> tristate "Support for rtllib TKIP crypto"
> depends on RTLLIB
> + select CRYPTO
> -select CRYPTO_ARC4
> +select CRYPTO_LIB_ARC4
As the driver has been converted over to the lib arc4 API, it
ways use the standard constants.
>
> Cc: linux-crypto@vger.kernel.org
> Signed-off-by: Eric Biggers
> ---
> drivers/char/random.c | 4 ++--
> include/crypto/chacha.h | 9 +++--
> 2 files changed, 9 insertions(+), 4 deletions(-)
Acked-by: Herbert Xu
--
Email: Herbert Xu
Hom
sed might not appear to be fully initialized.
The only architecture that requires a barrier for data dependency
is Alpha. The correct primitive to ensure that barrier is present
is smp_barrier_depends, or you could just use READ_ONCE.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.o
just take them away. Or am I missing something?
Good point.
Thomas mentioned that RT has been doing this for a while now so
perhaps someone has studied this problem already? Thomas?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
As long as nobody objects to the slight performance degradation on
legacy highmem platforms it should make kmap_atomic just go away on
modern platforms.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
*addr)
{
if (PageHighMem(page))
kunmap_atomic(addr);
}
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lve
manually checking every instance of kmap_atomic.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
be doing that by interrupting the SG miter walk rather than using
kmap.
Reported-by: Linus Torvalds
Signed-off-by: Herbert Xu
diff --git a/lib/crypto/chacha20poly1305.c b/lib/crypto/chacha20poly1305.c
index 431e04280332..5850f3b87359 100644
--- a/lib/crypto/chacha20poly1305.c
+++ b/lib/crypto
This patch moves the priv pointer into struct safexcel_context
because both structs that extend safexcel_context have that pointer
as well.
Signed-off-by: Herbert Xu
---
drivers/crypto/inside-secure/safexcel.h|1
drivers/crypto/inside-secure/safexcel_cipher.c | 42
As both safexcel_ahash_ctx and safexcel_cipher_ctx contain ipad
and opad buffers this patch moves them into the common struct
safexcel_context. It also adds a union so that they can be accessed
in the appropriate endian without crazy casts.
Signed-off-by: Herbert Xu
---
drivers/crypto/inside
safexcel_hmac_alg_setkey has been added for use by ahash
transforms.
As a result safexcel_aead_setkey's stack frame has been reduced by
about half in size, or about 512 bytes.
Reported-by: kernel test robot
Signed-off-by: Herbert Xu
---
drivers/crypto/inside-secure/safexcel.h|5 ++-
drivers/c
ate/ostate variables on the
stack. This patch series removes the warning by reusing the
ahash setkey code for aead. Note that we've simply moved the
istate/ostate into the ahash code and the overall stack usage
is actually unchanged.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
pto/s5p-sss.c | 15 +++
> 1 file changed, 7 insertions(+), 8 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Krzysztof Kozlowski
> ---
> drivers/crypto/s5p-sss.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ccvf/adf_drv.c | 6 ++
> 6 files changed, 12 insertions(+), 24 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
changed, 2 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> - add a Kconfig option to en/disable obsolete algorithms that are only kept
> around to prevent breaking users that rely on it via the socket interface
> - add a patch to clean up some bogus Kconfig dependencies
> - add acks to patches #1, #2 and #3
>
> [0]
> https://l
5 files changed, 196 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/rng/xiphera,xip8001b-trng.yaml
> create mode 100644 drivers/char/hw_random/xiphera-trng.c
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
> Signed-off-by: Marco Felsch
> ---
> drivers/char/hw_random/imx-rngc.c | 1 +
> 1 file changed, 1 insertion(+)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
to/qat/qat_common/qat_algs.c | 10 +-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 1 file changed, 3 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Aug 27, 2020 at 07:38:31PM +0200, Uros Bizjak wrote:
> x86_64 zero extends 32bit operations, so for 64bit operands,
> XORL r32,r32 is functionally equal to XORQ r64,r64, but avoids
> a REX prefix byte when legacy registers are used.
>
> Signed-off-by: Uros Bizjak
> Cc
On Thu, Aug 27, 2020 at 07:30:58PM +0200, Uros Bizjak wrote:
> x86_64 zero extends 32bit operations, so for 64bit operands,
> XORL r32,r32 is functionally equal to XORL r64,r64, but avoids
> a REX prefix byte when legacy registers are used.
>
> Signed-off-by: Uros Bizjak
> Cc
y: Nathan Chancellor
> Signed-off-by: Tero Kristo
> ---
> drivers/crypto/sa2ul.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
This patch fixes sparse endianness warnings by changing the type
of hash_init to u8 from u32. There should be no difference in the
generated code.
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/n2_core.c b/drivers/crypto/n2_core.c
index f137f22da8fb..3642bf83d809 100644
--- a/drivers
different base types)
../drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c:322:9:expected
unsigned long long [usertype] addr
../drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c:322:9:got restricted
__le32 [usertype] t_key
Please fix. Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
> Signed-off-by: Atte Tommiska
> Reported-by: kernel test robot
This Reported-by appears to be superfluous and I'll remove it
when applying.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Mon, Aug 31, 2020 at 06:16:49PM +0300, Ard Biesheuvel wrote:
>
> @@ -12,6 +12,7 @@
> #include
> #include
> #include
> +#include
This needs kernel.h too for the pr_warn_ratelimited. I'll add
it when I apply the series.
Thanks,
--
Email: Herb
"Support for STM32 crc accelerators"
> depends on ARCH_STM32
> select CRYPTO_HASH
> + select CRYPTO_CRC32
> + select CRYPTO_CRC32C
Shouldn't this be "select CRC32"?
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Thu, Sep 03, 2020 at 09:12:34PM +0800, Tianjia Zhang wrote:
>
> ---
> v6 changes:
> 1. remove mpi_sub_ui function from mpi library.
> 2. rebase on mainline.
This series is still missing acks for patches 6-8. Without them
it cannot proceed.
Thanks,
--
Email: Herbert Xu
ivs=[99.1%@+2668, 0.88%@alignmask+3630, 0.11%@+3403]
> iv_offset=33\"
> +[ 84.469074] need:35966fc8 b31ea266 2bf064e9 f20f40ad
> +[ 84.469084] have:e29e4491 f3b6effc fa366691 00e04bd9
>
> Thoses errors are random. (1 boot out of 2)
Do these really go away without this patch applied?
ring[i]->res_base, ring[i]->res_dma);
> dma_free_coherent(cryp->dev, MTK_DESC_RING_SZ,
> ring[i]->cmd_base, ring[i]->cmd_dma);
> kfree(ring[i]);
> - }
> + }while(i--);
Please add spaces before and after w
):
padata: fix possible padata_works_lock deadlock
kernel/padata.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lso just a test module though so the
> code isn't particularly crucial.
>
> Herbert/David? thoughts?
Please read the function as a whole, that fallthrough (and every other
one in do_test) needs to stay.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ned itself and not open-coded.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
should have no effect in the genereated code.
Instead of using cpu_to_Xe32 followed by a memcpy, this patch
converts the final hash write to use put_unaligned_X instead.
Reported-by: kernel test robot
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/allwinner/sun4i-ss/sun4i-ss-hash.c
b
without this last patch or not.
While lines beyond 80 characters are allowed, please don't send
patches that simply rewrite existing lines as longer ones.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
lot clearer.
This patch also fixes the incorrect endianness marking on wb,
although this should have no effect in the genereated code.
Fixes: 1e02e6fbdadb ("crypto: sun4i-ss - add the A33 variant of SS")
Reported-by: kernel test robot
Signed-off-by: Herbert Xu
diff --git a/drivers
Resend with new subject.
---8<---
The sa2ul driver uses crypto_authenc_extractkeys and therefore
must select CRYPTO_AUTHENC.
Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Reported-by: kernel test robot
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/Kconfig b/d
---
The sa2ul driver uses crypto_authenc_extractkeys and therefore
must select CRYPTO_AUTHENC.
Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Reported-by: kernel test robot
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index aa3a4ed
n then
be shared by both your crypto driver and your network driver so
you don't duplicate this everywhere.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ompile-test.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
: rename kzfree() to kfree_sensitive()")
> Signed-off-by: Denis Efremov
> ---
> Changes in v2:
> - fixes tag added
>
> drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 1 -
> 1 file changed, 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http
On Thu, Aug 27, 2020 at 09:53:28PM -0400, Daniel Jordan wrote:
> At Steffen's request, I'll help maintain padata for the foreseeable
> future.
>
> While at it, let's have patches go to lkml too since the code is now
> used outside of crypto.
>
> Signed-off
; Fix by leaving softirqs disabled while do_parallel holds
> padata_works_lock.
>
> Reported-by: syzbot+f4b9f49e38e25eb4e...@syzkaller.appspotmail.com
> Fixes: 4611ce2246889 ("padata: allocate work structures for parallel jobs
> from a pool")
> Signed-off-by: Da
xcel_hash.c | 3 +--
> 4 files changed, 9 insertions(+), 34 deletions(-)
All applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
drivers/crypto/sa2ul.c:1486:33: warning: cast from pointer to integer of
> different size [-Wpointer-to-int-cast]
>
> Signed-off-by: Krzysztof Kozlowski
> ---
> drivers/crypto/sa2ul.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
All applied. Thanks.
--
E
andom/cctrng.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
This patch fixes a couple of sparse endianness warnings in the
ux500 driver.
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/ux500/cryp/cryp_core.c
b/drivers/crypto/ux500/cryp/cryp_core.c
index e64e764bb035..c3adeb2e5823 100644
--- a/drivers/crypto/ux500/cryp/cryp_core.c
+++ b/drivers
working on big...")
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
index 138759dc8190..703a60d4e2f6 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/su
; > + i - HZIP_COMP_CORE_NUM);
> > > + if (!ret)
> > > + return -ENOMEM;
> >
> > and that is just so wrong - did you even try to test
> > the 'buffer too small' code path?
>
> Do you mean
/drivers/crypto/mediatek/mtk-platform.c
> +++ b/drivers/crypto/mediatek/mtk-platform.c
> @@ -469,7 +469,7 @@ static int mtk_desc_ring_alloc(struct mtk_cryp *cryp)
>return 0;
>
> err_cleanup:
> - for (; i--; ) {
> + for (; i >= 0; --i) {
How
e and that is the primary means of
getting to the object.
The tfm pointer is just an internal thing. So why do we have
to mark mem as not a leak?
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Tue, Sep 01, 2020 at 11:47:03AM +0300, Ard Biesheuvel wrote:
> On Tue, 1 Sep 2020 at 09:28, Herbert Xu wrote:
> >
> > Since commit b56f5cbc7e08ec7d31c42fc41e5247677f20b143 ("crypto:
> > arm/aes-neonbs - resolve fallback cipher at runtime") the CBC
> >
doing its own thing.
This patch removes the custom encryption path and simply invokes
the generic cbc template.
Signed-off-by: Herbert Xu
diff --git a/arch/arm/crypto/aes-neonbs-glue.c
b/arch/arm/crypto/aes-neonbs-glue.c
index e6fd32919c81..b324c5500846 100644
--- a/arch/arm/crypto/aes-neo
Now that crypto/cbc.h is only used by the generic cbc template,
we can merge it back into the CBC code.
Signed-off-by: Herbert Xu
diff --git a/crypto/cbc.c b/crypto/cbc.c
index e6f6273a7d39..0d9509dff891 100644
--- a/crypto/cbc.c
+++ b/crypto/cbc.c
@@ -6,7 +6,6 @@
*/
#include
-#include
Now that crypto/cbc.h is only used by the generic cbc template,
we can merge it back into the CBC code.
Signed-off-by: Herbert Xu
diff --git a/crypto/cbc.c b/crypto/cbc.c
index e6f6273a7d39..0d9509dff891 100644
--- a/crypto/cbc.c
+++ b/crypto/cbc.c
@@ -6,7 +6,6 @@
*/
#include
-#include
doing its own thing.
This patch removes the custom encryption path and simply invokes
the generic cbc template.
Signed-off-by: Herbert Xu
diff --git a/arch/arm/crypto/aes-neonbs-glue.c
b/arch/arm/crypto/aes-neonbs-glue.c
index e6fd32919c81..b324c5500846 100644
--- a/arch/arm/crypto/aes-neo
messages without MSG_MORE
(2020-08-27 23:20:36 +1000)
Giovanni Cabiddu (1):
crypto: qat - add delay before polling mailbox
Herbert Xu (1):
crypto: af_alg - Work around empty control messages without MSG_MORE
Randy Dunlap
order here does not matter?
I don't think it matters.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
+-
> 1 file changed, 5 insertions(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
>
> Signed-off-by: YueHaibing
> ---
> drivers/crypto/sa2ul.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
The endianness marking on the variable v in meson_cipher is wrong.
It is actually in CPU-order, not little-endian.
This patch fixes it.
Fixes: 3d04158814e7 ("crypto: amlogic - enable working on big...")
Signed-off-by: Herbert Xu
diff --git a/drivers/crypto/amlogic/amlogic-gxl-c
const struct seed_ctx *ctx = crypto_tfm_ctx(tfm);
>const __be32 *src = (const __be32 *)in;
>__be32 *dst = (__be32 *)out;
> - u32 x1, x2, x3, x4, t0, t1;
> + u32 x1, x2, x3, x4, t0;
>const u32 *ks = ctx->keysched;
>
&g
On Fri, Aug 21, 2020 at 01:43:19PM +, Corentin Labbe wrote:
>
> + err = pm_runtime_get_sync(ss->dev);
> + if (err < 0)
> + goto err_pm;
> + err = 0;
The error case needs to do this:
https://patchwork.kernel.org/patch/11728595/
Cheers,
--
Email:
8595/
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
tes by value is not good.
Passing struct chacha_state as a pointer doesn't work either.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ingly this particular file fails with those options on
gcc 8, 9 and 10.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
ion. To recreate
this warning, you need to enable both GCOV_KERNEL and UBSAN.
This is the minimal gcc command-line to recreate it:
gcc -Wframe-larger-than=1024 -fprofile-arcs -fsanitize=object-size -c -O2
chacha.c
If you take away either profile-arcs or sanitize=object-size then
the problem goes
control message). This
patch changes the kernel so that this is explicitly allowed.
Reported-by: Caleb Jorden
Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when...")
Cc:
Signed-off-by: Herbert Xu
diff --git a/crypto/af_alg.c b/crypto/af_alg.c
index a6f581ab200c..8be8bec07cdd
On Wed, Aug 26, 2020 at 05:42:27PM +0200, Ard Biesheuvel wrote:
>
> I still get a failure in aes_siv_encrypt(), which does not occur with
> the kernel side fix applied.
Where is this test from? I can't find it in the ell git tree.
Thanks,
--
Email: Herbert Xu
H
v. It does a sendmsg(2)
that expects to be followed by more sendmsg(2) calls before a
recvmsg(2). That's the one that needs a MSG_MORE.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
MSG_MORE where appropriate, this
patch works around the bug in the kernel so that existing binaries
continue to work.
We will print a warning however.
Reported-by: Caleb Jorden
Fixes: f3c802a1f300 ("crypto: algif_aead - Only wake up when...")
Cc:
Signed-off-by: Herbert Xu
diff --gi
as a patch series.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
y sendmsg(2) without a MSG_MORE will be interpreted as the end
of a request.
I'll work around this in the kernel though for the case where there
is no actual data, with a WARN_ON_ONCE.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
On Wed, Aug 26, 2020 at 01:59:53PM +0200, Ard Biesheuvel wrote:
> On Wed, 26 Aug 2020 at 13:50, Herbert Xu wrote:
> >
> > On Wed, Aug 26, 2020 at 12:40:14PM +0200, Ard Biesheuvel wrote:
> > >
> > > It would be helpful if someone could explain for the non-mac80
tring of sendmsg(2)'s with MSG_MORE folloed by a recvmsg(2)
in the same thread. I'll add a WARN_ON_ONCE so user-space can
eventually be fixed.
Cheers,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
501 - 600 of 8076 matches
Mail list logo
