Re: [PATCH] crypto: testmgr: add test vectors for skein

2018-07-01 Thread Jason Cooper
Hi Greg, On Sun, Jul 01, 2018 at 11:47:19AM +0200, Greg Kroah-Hartman wrote: > On Sun, Jul 01, 2018 at 05:16:11PM +0800, Herbert Xu wrote: > > On Thu, Jun 21, 2018 at 07:12:47AM +0900, Juan Manuel Torres Palma wrote: > > > On Wed, Jun 20, 2018 at 11:10:51AM -0700, Eric Biggers wrote: > > > > Also,

Re: [PATCH 0/3] crypto: marvell - Remove the old CESA driver

2017-10-11 Thread Jason Cooper
one who originally requested this transitioning time, Acked-by: Jason Cooper For the series. thx, Jason.

Re: [PATCH 0/4] hwrng: omap - fixes and improvements

2017-03-07 Thread Jason Cooper
> hwrng: omap - move clock related code to omap_rng_probe() > > drivers/char/hw_random/omap-rng.c | 36 +--- > 1 file changed, 25 insertions(+), 11 deletions(-) For the whole series, Acked-by: Jason Cooper thx, Jason.

Re: [PATCH v3 6/8] hwrng: amd: Replace global variable with private struct

2016-08-27 Thread Jason Cooper
On Sat, Aug 27, 2016 at 02:43:31PM +, Jason Cooper wrote: > Hi Corentin, > > On Fri, Aug 26, 2016 at 01:11:34PM +0200, LABBE Corentin wrote: > > Instead of having two global variable, it's better to use a > > private struct. This will permit to remove amd_pdev varia

Re: [PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver

2016-08-27 Thread Jason Cooper
32/iowrite32 > hwrng: amd: Convert to new hwrng read() API > > drivers/char/hw_random/amd-rng.c | 150 > +-- > 1 file changed, 96 insertions(+), 54 deletions(-) Once you've fixed up the casting in #6, you can add my Reviewed-by: Jason C

Re: [PATCH v3 6/8] hwrng: amd: Replace global variable with private struct

2016-08-27 Thread Jason Cooper
Hi Corentin, On Fri, Aug 26, 2016 at 01:11:34PM +0200, LABBE Corentin wrote: > Instead of having two global variable, it's better to use a > private struct. This will permit to remove amd_pdev variable > > Signed-off-by: LABBE Corentin > --- > drivers/char/hw_random/amd-rng.c | 57 > ++

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-26 Thread Jason Cooper
Hi Corentin, On Fri, Aug 26, 2016 at 10:38:02AM +0200, LABBE Corentin wrote: > On Thu, Aug 25, 2016 at 02:56:38PM +0000, Jason Cooper wrote: > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > > This patch convert the hwrng interface used by amd768-rng to it

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread Jason Cooper
Hi Corentin, On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > This patch convert the hwrng interface used by amd768-rng to its new API > by replacing data_read()/data_present() by read(). > > Furthermore, Instead of having two global variable, it's better to use a > private struc

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-14 Thread Jason Cooper
Hey Ted, On Wed, Aug 10, 2016 at 07:44:25PM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 02:04:44PM +0000, Jason Cooper wrote: > > iiuc, Ted, you're saying using the hw_random framework would be > > disasterous because despite most drivers having a default quali

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-11 Thread Jason Cooper
On Thu, Aug 11, 2016 at 10:54:11AM +0800, miaoq...@codeaurora.org wrote: > On 2016-08-10 21:24, Jason Cooper wrote: > >The fact is, barring userspace expectations of /dev/hwrng, hw_random is > >the appropriate place for it. It's not a devicetree blob, mac address, > >o

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-10 Thread Jason Cooper
Hi Miaoqing Pan, Stephen, *gentle reminder: others are reading which may not be directly included in the conversation. Including the archives. Please avoid top posting. :) On Wed, Aug 10, 2016 at 07:43:45AM +, Pan, Miaoqing wrote: > The problem with using the add_device_randomness is that w

Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices

2016-08-09 Thread Jason Cooper
Hi Keith, On Tue, Aug 09, 2016 at 10:58:05AM -0700, Keith Packard wrote: > Jason Cooper writes: > > Perhaps a /dev/hwrng[0-9] per rng? That would lend itself nicely to a > > sysfs interface for per device quality, rate, and enabled attributes. > > e.g. /sys/class/hw_

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-09 Thread Jason Cooper
Hi Henrique, On Tue, Aug 09, 2016 at 07:24:58AM -0300, Henrique de Moraes Holschuh wrote: > On Tue, 09 Aug 2016, Stephan Mueller wrote: > > RHEL 7 and Fedora do not adjust it. So, shall we consider those rng-tools > > then > > broken (at least in those large distros)? > > Might I humbly suggest

Re: [PATCH 2/2] ath9k: disable RNG by default

2016-08-09 Thread Jason Cooper
mbedded systems. > > Signed-off-by: Miaoqing Pan Until we get the hw_random/get_device_randomness question sorted... Reviewed-by: Jason Cooper thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.ke

Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices

2016-08-09 Thread Jason Cooper
Hi Keith, Herbert, On Tue, Aug 09, 2016 at 05:50:58PM +0800, Herbert Xu wrote: > On Mon, Jul 25, 2016 at 01:07:35PM -0700, Keith Packard wrote: > > Instead of having only one hwrng feeding /dev/random at a time, maintain > > a list of devices and cycle between them when filling the entropy pool. >

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-09 Thread Jason Cooper
Hi Ted, On Tue, Aug 09, 2016 at 07:56:22AM -0400, Theodore Ts'o wrote: > On Tue, Aug 09, 2016 at 06:30:03AM +, Pan, Miaoqing wrote: > > Agree with Jason's point, also understand Stephan's concern. The > > date rate can be roughly estimated by 'cat /dev/random |rngtest -c > > 1000', the averag

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, On Mon, Aug 08, 2016 at 05:29:30PM +, Jason Cooper wrote: > On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: ... > > If you think that this patch is a challenge because your driver starts to > > spin, please help and offer another solution. > &

Re: [PATCH v2] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-08 Thread Jason Cooper
Hi Stephan, Miaoqing Pan, On Mon, Aug 08, 2016 at 08:41:36AM +0200, Stephan Mueller wrote: > Am Montag, 8. August 2016, 02:03:36 CEST schrieb Pan, Miaoqing: > > The entropy was evaluated by crypto expert, the analysis report show the > > ADC with at least 10bits and up to 22 bits of min-entropy f

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-06 Thread Jason Cooper
Hi Stephan, On Sat, Aug 06, 2016 at 10:03:58PM +0200, Stephan Mueller wrote: > Am Samstag, 6. August 2016, 19:45:51 CEST schrieb Jason Cooper: > > On Fri, Aug 05, 2016 at 05:08:14PM +0200, Stephan Mueller wrote: ... > > > diff --git a/drivers/net/wireless/ath/ath9k/rng.c &

Re: [RFC][PATCH] RANDOM: ATH9K RNG delivers zero bits of entropy

2016-08-06 Thread Jason Cooper
> -ATH9K_RNG_ENTROPY(bytes_read)); This is the only use of this macro. I'd remove the #define on line 25 as well. > + add_hwgenerator_randomness((void *)rng_buf, bytes_read, 0); > } > > kfree(rng_buf); Oth

Re: [PATCH 1/7] A couple of generated files

2015-11-07 Thread Jason Cooper
Hey Sandy, I know we talked about this series offlist, but we need to fill in folks who are seeing it for the first time. Usually, this is done with a coverletter (--coverletter for git format-patch). No need to resend before receiving feedback, but would you mind replying with a description of

Re: [PATCH 1/7] A couple of generated files

2015-11-07 Thread Jason Cooper
On Sat, Nov 07, 2015 at 09:30:36AM -0500, Sandy Harris wrote: > Signed-off-by: Sandy Harris > --- > .gitignore | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.gitignore b/.gitignore > index fd3a355..dd80bfd 100644 > --- a/.gitignore > +++ b/.gitignore > @@ -112,3 +112,6 @@ all.confi

Re: [PATCH 3/7] Initialise pools randomly if CONFIG_RANDOM_INIT=y

2015-11-07 Thread Jason Cooper
On Sat, Nov 07, 2015 at 09:30:38AM -0500, Sandy Harris wrote: > Signed-off-by: Sandy Harris > --- > drivers/char/random.c | 50 ++ > 1 file changed, 46 insertions(+), 4 deletions(-) > > diff --git a/drivers/char/random.c b/drivers/char/random.c > i

Re: [PATCH 03/18] crypto: marvell: add flag to determine algorithm endianness

2015-10-19 Thread Jason Cooper
On Mon, Oct 19, 2015 at 04:25:07PM +0100, Russell King - ARM Linux wrote: > On Mon, Oct 19, 2015 at 03:04:51PM +0000, Jason Cooper wrote: > > Hey Russell, > > > > On Sun, Oct 18, 2015 at 05:23:40PM +0100, Russell King wrote: > > > static int mv_cesa_ahash_

Re: [PATCH 03/18] crypto: marvell: add flag to determine algorithm endianness

2015-10-19 Thread Jason Cooper
Hey Russell, On Sun, Oct 18, 2015 at 05:23:40PM +0100, Russell King wrote: > Rather than determining whether we're using a MD5 hash by looking at > the digest size, switch to a cleaner solution using a per-request flag > initialised by the method type. > > Signed-off-by: Russell King > --- > dr

Re: [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi

2015-05-26 Thread Jason Cooper
On Tue, May 26, 2015 at 11:10:51AM +0200, Boris Brezillon wrote: > On Tue, 26 May 2015 09:06:29 + > Jason Cooper wrote: > > > On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote: > > > Jason, Gregory, > > > > > > On Mon, 25 May 201

Re: [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi

2015-05-26 Thread Jason Cooper
On Mon, May 25, 2015 at 08:43:02PM +0200, Boris Brezillon wrote: > Jason, Gregory, > > On Mon, 25 May 2015 16:46:51 +0000 > Jason Cooper wrote: > > > On Mon, May 25, 2015 at 05:39:13PM +0200, Gregory CLEMENT wrote: > > > Hi Boris, Arnaud, > > > > >

Re: [PATCH v3 16/16] ARM: marvell/dt: add crypto node to kirkwood dtsi

2015-05-25 Thread Jason Cooper
On Mon, May 25, 2015 at 05:39:13PM +0200, Gregory CLEMENT wrote: > Hi Boris, Arnaud, > > On 22/05/2015 15:34, Boris Brezillon wrote: > > From: Arnaud Ebalard > > > > Add crypto related nodes to kirkwood.dtsi. > > Here you use a new compatible string but with an old binding > to let the user cho

Re: [PATCH v3 0/2] crypto: add a new driver for Marvell's CESA

2015-05-22 Thread Jason Cooper
+ Jason Gunthorpe, he may be interested in this. On Fri, May 22, 2015 at 03:33:46PM +0200, Boris Brezillon wrote: > Hello, > > This patch series adds a new driver supporting Marvell's CESA IP. > This driver addresses some limitations of the existing one. > From a performance and CPU load point of

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-17 Thread Jason Cooper
Hey Boris, On Fri, Apr 17, 2015 at 10:39:46AM +0200, Boris Brezillon wrote: > On Fri, 17 Apr 2015 10:33:56 +0200 Boris Brezillon > wrote: > > On Mon, 13 Apr 2015 20:11:46 + Jason Cooper > > wrote: > > > > > > > > > I'd appreciate if

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-13 Thread Jason Cooper
Hey Arnaud, On Mon, Apr 13, 2015 at 06:06:49PM +0200, Arnaud Ebalard wrote: > Jason Cooper writes: ... > >> >> I really tried to adapt the existing driver to add the missing > >> >> features (especially the support for TDMA), but all my attempts > >>

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-13 Thread Jason Cooper
Hey Gregory, On Mon, Apr 13, 2015 at 11:39:16AM +0200, Gregory CLEMENT wrote: > Hi Jason, Boris, > > On 11/04/2015 00:30, Jason Cooper wrote: > > Hey Boris, > > > > On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: > >> On Fri, 10 Apr 2015 13:5

Re: [PATCH 0/2] crypto: add new driver for Marvell CESA

2015-04-10 Thread Jason Cooper
Hey Boris, On Fri, Apr 10, 2015 at 05:11:48PM +0200, Boris Brezillon wrote: > On Fri, 10 Apr 2015 13:50:56 +0000 Jason Cooper wrote: > > On Thu, Apr 09, 2015 at 04:58:41PM +0200, Boris Brezillon wrote: > > > I know we usually try to adapt existing drivers instead of replacing

Re: [PATCH] staging: crypto: fixed style error in ahash.c

2014-12-05 Thread Jason Cooper
On Fri, Dec 05, 2014 at 02:44:54PM +0900, Joshua I. James wrote: > From: "Joshua I. James" > > Fixed style error identified by checkpatch. > > WARNING: Missing a blank line after declarations > + unsigned int unaligned = alignmask + 1 - (offset & alignmask); > + if (n

Re: [PATCH] staging: crypto: fixed style error in af_alg.c

2014-12-05 Thread Jason Cooper
On Fri, Dec 05, 2014 at 02:38:40PM +0900, Joshua I. James wrote: > From: "Joshua I. James" > > Fixed style error identified by checkpatch. > > ERROR: space required before the open parenthesis '(' > + switch(cmsg->cmsg_type) { > > Signed-off-by: Joshua I. James > --- > crypto/af

Re: [PATCH] staging: crypto: fixed style error in aead.c

2014-12-05 Thread Jason Cooper
Joshua, On Fri, Dec 05, 2014 at 02:24:44PM +0900, Joshua I. James wrote: > From: "Joshua I. James" > > Fixed style error identified by checkpatch. > > ERROR: do not use assignment in if condition > + if ((err = crypto_register_instance(tmpl, inst))) { Short comment needed here like I men

Re: [PATCH] staging: crypto: fixed style errors in ablkcipher.c

2014-12-05 Thread Jason Cooper
Joshua, Your subject, "[PATCH] staging: crypto: fixed style errors in ablkcipher.c" is misleading. 'staging' is a location in the tree, drivers/staging/, not a separate git tree. So your subject for this series should have been "[PATCH] crypto: ablkcipher: Cleanup minor checkpatch error." More

Re: [PATCH v2 01/11] crypto: Documentation - crypto API high level spec

2014-11-08 Thread Jason Cooper
has everything > > together in one place? > > How do you suggest that is done? The API comments in the header file follow > the Doxygen style. Note, Jason Cooper raised the concern that an API > documentation separate from the code will surely deviate from the code > relatively

Re: [PATCH] kernel crypto API interface specification

2014-10-16 Thread Jason Cooper
On Thu, Oct 16, 2014 at 06:50:58PM +0200, Stephan Mueller wrote: > Am Donnerstag, 16. Oktober 2014, 11:06:05 schrieb Jason Cooper: > > Hi Jason, > > > On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: > > > + Grant, Geert, > > > > > > St

Re: [PATCH] kernel crypto API interface specification

2014-10-16 Thread Jason Cooper
On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: > + Grant, Geert, > > Stephan has created some great example code for both the kernel crypto > API and the userspace crypto API. As examples tend to bitrot, I was > wondering if the code could serve as test code. Then

Re: [PATCH] kernel crypto API interface specification

2014-10-16 Thread Jason Cooper
On Thu, Oct 16, 2014 at 09:25:01AM -0400, Jason Cooper wrote: > + Grant, Geert, oops. It helps if I actually *add* them. Sorry for the noise. > Stephan has created some great example code for both the kernel crypto > API and the userspace crypto API. As examples tend to bitr

Re: [PATCH] kernel crypto API interface specification

2014-10-16 Thread Jason Cooper
implementation. Original patch is here: https://lkml.kernel.org/r/7502136.9bkwhtz...@myon.chronox.de On Thu, Oct 16, 2014 at 09:19:08AM +0200, Stephan Mueller wrote: > Am Mittwoch, 15. Oktober 2014, 13:58:00 schrieb Jason Cooper: > > Hi Jason, > > > Stephan, > >

Re: [PATCH] kernel crypto API interface specification

2014-10-15 Thread Jason Cooper
Stephan, Wow. This is very thorough. Herbert and others will be making the final call on this, but if I may make a suggestion: On Tue, Oct 14, 2014 at 09:46:50PM +0200, Stephan Mueller wrote: > The update adds a complete interface documentation of the kernel crypto > API. All cipher types suppo

Re: memset() in crypto code?

2014-10-06 Thread Jason Cooper
On Mon, Oct 06, 2014 at 01:59:06PM -0400, Sandy Harris wrote: > On Mon, Oct 6, 2014 at 1:44 PM, Jason Cooper wrote: > > > On Sat, Oct 04, 2014 at 11:09:40PM -0400, Sandy Harris wrote: > >> There was recently a patch to the random driver to replace memset() > >

Re: memset() in crypto code?

2014-10-06 Thread Jason Cooper
On Sat, Oct 04, 2014 at 11:09:40PM -0400, Sandy Harris wrote: > There was recently a patch to the random driver to replace memset() > because, according to the submitter, gcc sometimes optimises memset() > away which might leave data unnecessarily exposed. The solution > suggested was a function ca

Re: DMA support for mv_cesa

2014-07-28 Thread Jason Cooper
Muran, + free-electron's, mvebu maintainers On Mon, Jul 28, 2014 at 03:24:43PM +0200, Muran Hrun wrote: > What is the status of DMA support for mv_cesa? I tried applying the patches at > git://nwl.cc/~n0-1/linux.git (cesa-dma branch) > on kernel 3.15.6 but the kernel just crashed on my DNS-320, w

[PATCH] staging: crypto: skein: depend upon CRYPTO

2014-04-25 Thread Jason Cooper
x this in the Kconfig by depending on CRYPTO. Reported-by: Fengguang Wu Signed-off-by: Jason Cooper --- drivers/staging/skein/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/Kconfig b/drivers/staging/skein/Kconfig index 8f5a72a90ced..b9172bfcdc1b

[PATCH V3 02/21] staging: crypto: skein: allow building statically

2014-03-23 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- Changes since V2:

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-23 Thread Jason Cooper
On Tue, Mar 18, 2014 at 02:28:20PM +, Greg KH wrote: > On Tue, Mar 18, 2014 at 08:58:49AM -0400, Jason Cooper wrote: > > On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > > > On Tue, Mar 11, 2014 at 09:32:35PM +, Jason Cooper wrote: > > > > These ar

[PATCH V2 03/21] staging: crypto: skein: remove brg_*.h includes

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions

[PATCH V2 07/21] staging: crypto: skein: remove all typedef {struct,enum}

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42

[PATCH V2 06/21] staging: crypto: skein: remove unneeded typedefs

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein

[PATCH V2 15/21] staging: crypto: skein: fix do/while brace formatting

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein

[PATCH V2 05/21] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include

[PATCH V2 00/21] staging: add skein/threefish crypto algos

2014-03-23 Thread Jason Cooper
n particular, I really don't like the adhoc macro definitions, nor the camelCase. The plan is to get skein and threefish registered into the crypto API, build as modules, and then move it to crypto/. thx, Jason. Jason Cooper (21): staging: crypto: skein: import code from Skein3Fish.gi

[PATCH V2 16/21] staging: crypto: skein: fix brace placement errors

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff

[PATCH V2 08/21] staging: crypto: skein: use u8, u64 vice uint*_t

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18

[PATCH V2 13/21] staging: crypto: skein: remove trailing whitespace

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c

[PATCH V2 04/21] staging: crypto: skein: remove skein_port.h

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644

[PATCH V2 21/21] staging: crypto: skein: add TODO file

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null

[PATCH V2 17/21] staging: crypto: skein: wrap multi-line macros in do-while loops

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a

[PATCH V2 20/21] staging: crypto: skein: remove unnecessary line continuation

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c

[PATCH V2 19/21] staging: crypto: skein: remove braces from single-statement block

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b

[PATCH V2 18/21] staging: crypto: skein: remove externs from .c files

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a

[PATCH V2 09/21] staging: crypto: skein: fixup pointer whitespace

2014-03-23 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18

[PATCH V2 02/21] staging: crypto: skein: allow building statically

2014-03-23 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- Changes since RFC:

Re: [RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-18 Thread Jason Cooper
On Mon, Mar 17, 2014 at 02:52:52PM -0700, Greg KH wrote: > On Tue, Mar 11, 2014 at 09:32:35PM +0000, Jason Cooper wrote: > > These are the minimum changes required to get the code to build > > statically in the kernel. It's necessary to do this first so that we > > can

Re: [RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-12 Thread Jason Cooper
On Tue, Mar 11, 2014 at 09:32:32PM +, Jason Cooper wrote: > To facilitate tinkering with this, One can pull from the following: > > git://git.infradead.org/users/jcooper/linux.git tags/staging-skein-3.14-rc1 > > This is based on v3.14-rc1, and is prone to rebasing based on

[RFC PATCH 05/22] staging: crypto: skein: remove skein_port.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h | 14 +++- drivers/staging/skein/include/skein_port.h | 108 - drivers/staging/skein/skein.c | 21 -- 3 files changed, 13 insertions(+), 130 deletions(-) delete mode 100644

[RFC PATCH 14/22] staging: crypto: skein: remove trailing whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 16 +- drivers/staging/skein/include/skeinApi.h | 44 ++-- drivers/staging/skein/include/threefishApi.h | 40 - drivers/staging/skein/skeinBlockNo3F.c

[RFC PATCH 19/22] staging: crypto: skein: remove externs from .c files

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein_block.h | 22 ++ drivers/staging/skein/skein.c | 10 +- 2 files changed, 23 insertions(+), 9 deletions(-) create mode 100644 drivers/staging/skein/include/skein_block.h diff --git a

[RFC PATCH 21/22] staging: crypto: skein: remove unnecessary line continuation

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 707a21ae53c6..fd96ca0ad0ed 100644 --- a/drivers/staging/skein/skein_block.c

[RFC PATCH 09/22] staging: crypto: skein: use u8, u64 vice uint*_t

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skeinApi.h | 8 drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 22 +++--- drivers/staging/skein/threefish1024Block.c | 18

[RFC PATCH 06/22] staging: crypto: skein: remove __cplusplus and an unneeded stddef.h

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 11 --- drivers/staging/skein/include/skeinApi.h | 9 - drivers/staging/skein/include/threefishApi.h | 9 - 3 files changed, 29 deletions(-) diff --git a/drivers/staging/skein/include

[RFC PATCH 07/22] staging: crypto: skein: remove unneeded typedefs

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 73 ++--- drivers/staging/skein/include/skeinApi.h | 4 +- drivers/staging/skein/include/skein_iv.h | 26 drivers/staging/skein/include/threefishApi.h | 6 +- drivers/staging/skein

[RFC PATCH 08/22] staging: crypto: skein: remove all typedef {struct,enum}

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 58 ++-- drivers/staging/skein/include/skeinApi.h | 32 +++ drivers/staging/skein/include/threefishApi.h | 32 +++ drivers/staging/skein/skein.c| 42

[RFC PATCH 18/22] staging: crypto: skein: wrap multi-line macros in do-while loops

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 66 - 1 file changed, 51 insertions(+), 15 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 6e0f4a21aae3..707a21ae53c6 100644 --- a

[RFC PATCH 17/22] staging: crypto: skein: fix brace placement errors

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 30 - drivers/staging/skein/include/skein_iv.h | 65 -- drivers/staging/skein/skein.c| 111 ++- 3 files changed, 74 insertions(+), 132 deletions(-) diff

[RFC PATCH 10/22] staging: crypto: skein: fixup pointer whitespace

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/skein.h| 18 +- drivers/staging/skein/include/skeinApi.h | 10 +- drivers/staging/skein/include/threefishApi.h | 22 +++--- drivers/staging/skein/skeinApi.c | 18

[RFC PATCH 22/22] staging: crypto: skein: add TODO file

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/TODO | 11 +++ 1 file changed, 11 insertions(+) create mode 100644 drivers/staging/skein/TODO diff --git a/drivers/staging/skein/TODO b/drivers/staging/skein/TODO new file mode 100644 index ..f5c167a305ae --- /dev/null

[RFC PATCH 04/22] staging: crypto: skein: remove brg_*.h includes

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/include/brg_endian.h | 148 - drivers/staging/skein/include/brg_types.h | 131 - drivers/staging/skein/include/skein_port.h | 6 +- 3 files changed, 2 insertions(+), 283 deletions

[RFC PATCH 20/22] staging: crypto: skein: remove braces from single-statement block

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skeinApi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/skein/skeinApi.c b/drivers/staging/skein/skeinApi.c index f0015d5b10f5..dd109bf6f7b9 100644 --- a/drivers/staging/skein/skeinApi.c +++ b

[RFC PATCH 16/22] staging: crypto: skein: fix do/while brace formatting

2014-03-11 Thread Jason Cooper
Signed-off-by: Jason Cooper --- drivers/staging/skein/skein_block.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/staging/skein/skein_block.c b/drivers/staging/skein/skein_block.c index 780b4936f783..6e0f4a21aae3 100644 --- a/drivers/staging/skein

[RFC PATCH 00/22] staging: add skein/threefish crypto algos

2014-03-11 Thread Jason Cooper
on v3.14-rc1, and is prone to rebasing based on comments. thx, Jason. Jason Cooper (22): scripts: objdiff: detect object code changes between two commits staging: crypto: skein: import code from Skein3Fish.git staging: crypto: skein: allow building statically staging: crypto: skein: rem

[RFC PATCH 01/22] scripts: objdiff: detect object code changes between two commits

2014-03-11 Thread Jason Cooper
values as diff(1). This was written specifically to support adding the skein and threefish cryto drivers to the staging tree. I needed a programmatic way to confirm that commits changing >90% of the lines didn't inadvertently change the code. Signed-off-by: Jason Cooper --- scripts

[RFC PATCH 03/22] staging: crypto: skein: allow building statically

2014-03-11 Thread Jason Cooper
These are the minimum changes required to get the code to build statically in the kernel. It's necessary to do this first so that we can empirically determine that future cleanup patches aren't changing the generated object code. Signed-off-by: Jason Cooper --- drivers/stagi

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-06 Thread Jason Cooper
differences. > > Signed-off-by: Kees Cook > --- > drivers/char/hw_random/core.c |7 +++ > 1 file changed, 7 insertions(+) fwiw, Reviewed-by: Jason Cooper thx, Jason. > diff --git a/drivers/char/hw_random/core.c b/drivers/char/hw_random/core.c > index a0f77248

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-06 Thread Jason Cooper
On Wed, Mar 05, 2014 at 06:52:27PM -0600, Matt Mackall wrote: > On Wed, 2014-03-05 at 16:11 -0500, Jason Cooper wrote: > > > In other words, if there are 4096 bits of "unknownness" in X to start > > > with, and I can get those same 4096 bits of "unknownness&qu

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-05 Thread Jason Cooper
Matt, Kees, On Tue, Mar 04, 2014 at 04:39:57PM -0600, Matt Mackall wrote: > On Tue, 2014-03-04 at 11:59 -0800, Kees Cook wrote: > > On Tue, Mar 4, 2014 at 11:53 AM, Jason Cooper wrote: > > > On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: > > >> On Tue,

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Jason Cooper
On Tue, Mar 04, 2014 at 11:01:49AM -0800, Kees Cook wrote: > On Tue, Mar 4, 2014 at 7:38 AM, Jason Cooper wrote: > > Kees, Ted, > > > > On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: > >> When bringing a new RNG source online, it seems like it would make

Re: [PATCH][RESEND 3] hwrng: add randomness to system from rng sources

2014-03-04 Thread Jason Cooper
Kees, Ted, On Mon, Mar 03, 2014 at 03:51:48PM -0800, Kees Cook wrote: > When bringing a new RNG source online, it seems like it would make sense > to use some of its bytes to make the system entropy pool more random, > as done with all sorts of other devices that contain per-device or > per-boot d

Re: [PATCH] Crypto: CESA: Add support for DT based instantiation.

2012-09-09 Thread Jason Cooper
On Mon, Sep 03, 2012 at 08:29:34PM +0200, Andrew Lunn wrote: > Based on work by Michael Waller and Jason Cooper. > > Added support for getting the interrupt number and address of SRAM > from DT. > > Signed-off-by: Andrew Lunn Applied to: git://git.infradead.org/users

Re: [PATCH] Crypto: CESA: Add support for DT based instantiation.

2012-09-03 Thread Jason Cooper
On Mon, Sep 03, 2012 at 08:29:34PM +0200, Andrew Lunn wrote: > Based on work by Michael Waller and Jason Cooper. nit. "Michael Walle" If nothing significant crops up in the next few days, I'll fix it when I pull it in. thx, Jason. -- To unsubscribe from this list: send the

Re: [PATCH] crypto: mv_cesa requires on CRYPTO_HASH to build

2012-05-12 Thread Jason Cooper
_digest" [drivers/crypto/mv_cesa.ko] undefined! > ERROR: "crypto_shash_setkey" [drivers/crypto/mv_cesa.ko] undefined! > ERROR: "crypto_alloc_shash" [drivers/crypto/mv_cesa.ko] undefined! > make[1]: *** [__modpost] Error 1 > make: *** [modules] Error 2 > make: *** Wait

Re: [PATCH] crypto: fix build failure in mv_cesa.c (missing of header)

2012-03-10 Thread Jason Cooper
On Fri, Mar 09, 2012 at 02:58:25PM -0500, Paul Gortmaker wrote: > Commit 737b75872487f560397ba34846a19823b1addf88 (linux-next) > > "ARM: kirkwood: mv_cesa devicetree bindings" > > fails to compile as follows: > > CC drivers/crypto/mv_cesa.o > drivers/crypto/mv_cesa.c:1139: error: impl