Re: [PATCH RESEND] hwrng: core - don't pass stack allocated buffer to rng->read()

2016-10-21 Thread Laszlo Ersek
On 10/21/16 23:17, Richard W.M. Jones wrote: > On Fri, Oct 21, 2016 at 02:04:27PM -0700, Andy Lutomirski wrote: >> https://git.kernel.org/cgit/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=6d4952d9d9d4dc2bb9c0255d95a09405a1e958f7 > > I have tested this one, and it also fixes the bug I was

Re: [PATCH RESEND] hwrng: core - don't pass stack allocated buffer to rng->read()

2016-10-21 Thread Laszlo Ersek
On 10/21/16 23:04, Andy Lutomirski wrote: > On Fri, Oct 21, 2016 at 1:48 PM, Laszlo Ersek <ler...@redhat.com> wrote: >> The virtio-rng backend for hwrng passes the buffer that it receives for >> filling to sg_set_buf() directly, in: >> >> virtio_read() [dr

[PATCH RESEND] hwrng: core - don't pass stack allocated buffer to rng->read()

2016-10-21 Thread Laszlo Ersek
Kees Cook <keesc...@chromium.org> Cc: Matt Mackall <m...@selenic.com> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1383451 Fixes: d9e797261933 ("hwrng: add randomness to system from rng sources") See-also: 5e59d9a1aed2 ("virtio_console: Stop doing DMA on the stack") Rep

Re: [PATCH] hwrng: core - don't pass stack allocated buffer to rng->read()

2016-10-21 Thread Laszlo Ersek
On 10/21/16 22:32, Laszlo Ersek wrote: > [...] Self-NAK, I'll resend in a minute. I added a tag like this: Cc: <sta...@vger.kernel.org> # For v3.15+ and git turned it into a garbage email address. I'll drop the "# For v3.15+" part in the repost. (I'll also add explicit q

[PATCH] hwrng: core - don't pass stack allocated buffer to rng->read()

2016-10-21 Thread Laszlo Ersek
Matt Mackall <m...@selenic.com> Cc: Richard W.M. Jones <rjo...@redhat.com> Ref: https://bugzilla.redhat.com/show_bug.cgi?id=1383451 Fixes: d9e797261933 ("hwrng: add randomness to system from rng sources") See-also: 5e59d9a1aed2 ("virtio_console: Stop doing DMA on the s