Re: [PATCH v2] crypto: arm64/aes-modes - get rid of literal load of addend vector

2018-08-23 Thread Nick Desaulniers
rovement by itself, but also works around a Clang issue, > whose integrated assembler does not implement the GNU ARM asm syntax > completely, and does not support the =literal notation for FP registers > (more info at https://bugs.llvm.org/show_bug.cgi?id=38642) > > Cc: Nick Desaulniers

Re: [PATCH] crypto: arm64/aes-modes - get rid of literal load of addend vector

2018-08-21 Thread Nick Desaulniers
On Tue, Aug 21, 2018 at 11:19 AM Ard Biesheuvel wrote: > > On 21 August 2018 at 20:04, Nick Desaulniers wrote: > > On Tue, Aug 21, 2018 at 9:46 AM Ard Biesheuvel > > wrote: > >> > >> Replace the literal load of the addend vector with a sequence that >

Re: [PATCH] crypto: arm64/aes-modes - get rid of literal load of addend vector

2018-08-21 Thread Nick Desaulniers
arch64/programmer-friendly.s;h=6254c6476efdc848648b05068be0574e7addc85d;hb=HEAD#l11 They can help provide more context to future travelers. > > Cc: Nick Desaulniers > Signed-off-by: Ard Biesheuvel > --- > arch/arm64/crypto/aes-modes.S | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-)

Re: [PATCH] crypto/arm64: aes-ce-cipher - move assembler code to .S file

2017-11-21 Thread Nick Desaulniers
Checked for transcription errors, calling convention, and removal of temporary locals. LGTM. Reviewed-By: Nick Desaulniers <ndesaulni...@google.com> On Tue, Nov 21, 2017 at 5:40 AM, Ard Biesheuvel <ard.biesheu...@linaro.org> wrote: > Most crypto drivers involving kernel mode