Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

2018-03-21 Thread Philippe Ombredanne
ot;); would mean GPL-2.0+ (e.g. or any later version) and this would not match your top level license tag. I know this may seem confusing, but there is little hope we can change the MODULE_LICENSE tags that are used by many external module loaders. Comments in module.h explain it all. -- Cordially Philippe Ombredanne

Re: [PATCH 1/5 v4] add compression algorithm zBeWalgo

2018-03-20 Thread Philippe Ombredanne
ame thing in the MODULE_LICENSE and your SPDX tags. [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/license-rules.rst [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/module.h#n175 -- Cordially Philippe Ombredanne

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

2018-01-07 Thread Philippe Ombredanne
Gilad, On Sun, Jan 7, 2018 at 11:13 AM, Gilad Ben-Yossef wrote: > On Wed, Jan 3, 2018 at 5:01 PM, Philippe Ombredanne > wrote: >> Gilad, >> >> On Wed, Jan 3, 2018 at 2:35 PM, Gilad Ben-Yossef wrote: >>> Replace verbatim GPL v2 copy with SPDX tag. >&g

Re: [PATCH v2 01/27] staging: ccree: SPDXify driver

2018-01-03 Thread Philippe Ombredanne
the whole purpose to have clear licensing kernel-wide: using the latest and greatest introduces variations and creates a mess that we want to avoid in the first place. CC: Thomas Gleixner [1] https://lkml.org/lkml/2017/12/28/323 -- Cordially Philippe Ombredanne

Re: [PATCH 01/26] staging: ccree: SPDXify driver

2018-01-01 Thread Philippe Ombredanne
Thomas doc patches. .e.g. > +/* SPDX-License-Identifier: GPL-2.0 */ And then it might makes sense there too: > +/* Copyright (C) 2012-2017 ARM Limited or its affiliates. */ -- Cordially Philippe Ombredanne

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-27 Thread Philippe Ombredanne
Łukasz, On Wed, Dec 27, 2017 at 11:12 AM, Łukasz Stelmach wrote: > It was <2017-12-22 pią 19:30>, when Philippe Ombredanne wrote: >> On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach >> wrote: >>> It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote

Re: [PATCH v5] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Philippe Ombredanne
cense header instead of the traditional blurb. > > - MODULE_LICENSE("GPL v2") instead of "GPL" > > Thank you, Philippe Ombredanne. You have my cheerful ack for these changes: Acked-by: Philippe Ombredanne -- Cordially Philippe Ombredanne

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Philippe Ombredanne
On Fri, Dec 22, 2017 at 5:38 PM, Łukasz Stelmach wrote: > It was <2017-12-22 pią 14:34>, when Philippe Ombredanne wrote: >> Łukasz, >> >> On Fri, Dec 22, 2017 at 2:23 PM, Łukasz Stelmach >> wrote: >>> Add support for True Random Number Genera

Re: [PATCH v4] hwrng: exynos - add Samsung Exynos True RNG driver

2017-12-22 Thread Philippe Ombredanne
g/lkml/2017/12/4/934 [2] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/ -- Cordially Philippe Ombredanne

Re: [PATCH 1/2] padata: Remove FSF address

2017-12-20 Thread Philippe Ombredanne
Dear CheahKC, On Wed, Dec 20, 2017 at 10:17 PM, Cheah Kok Cheong wrote: > On Wed, Dec 20, 2017 at 09:20:48PM +0100, Philippe Ombredanne wrote: >> On Wed, Dec 20, 2017 at 9:15 PM, Cheah Kok Cheong wrote: >> > Remove FSF address otherwise checkpatch will flag my next patch. &g

Re: [PATCH 1/2] padata: Remove FSF address

2017-12-20 Thread Philippe Ombredanne
tails. > - * > - * You should have received a copy of the GNU General Public License along > with > - * this program; if not, write to the Free Software Foundation, Inc., > - * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA. > */ > > #include > -- >

Re: [PATCH 04/10] staging: ccree: staging: ccree: replace sysfs by debugfs interface

2017-12-14 Thread Philippe Ombredanne
rd out in your team too, this would be much welcomed! Thanks! [1] https://lkml.org/lkml/2017/12/4/934 -- Cordially Philippe Ombredanne

Re: [Part2 PATCH v9 12/38] crypto: ccp: Add Platform Security Processor (PSP) device support

2017-12-07 Thread Philippe Ombredanne
On Thu, Dec 7, 2017 at 9:21 PM, Brijesh Singh wrote: > > > On 12/06/2017 03:10 PM, Philippe Ombredanne wrote:>> diff --git > a/drivers/crypto/ccp/psp-dev.c b/drivers/crypto/ccp/psp-dev.c >>> >>> new file mode 100644 >>> index ..b5789f8785

Re: [Part2 PATCH v9 12/38] crypto: ccp: Add Platform Security Processor (PSP) device support

2017-12-06 Thread Philippe Ombredanne
this way: > +// SDPX-License-Identifier: GPL-2.0 > +/* > + * AMD Platform Security Processor (PSP) interface > + * > + * Copyright (C) 2016-2017 Advanced Micro Devices, Inc. > + * > + * Author: Brijesh Singh > + */ It is much cleaner and simpler, right? For the C++ comment style and first line placement, please see Thomas (tlgx) doc patches and Linus posts explaining his rationale of why he wants it this way. It would be awesome if this could be applied to all AMD contributions btw! -- Cordially Philippe Ombredanne

Re: [PATCH] crypto: replace FSF address with web source in license notices

2017-11-28 Thread Philippe Ombredanne
> Patch applied. Thanks. Herbert, You may have missed the thread on the similar "samples" patch [1] before applying this as-is? [1] https://lkml.org/lkml/2017/11/14/135 -- Cordially Philippe Ombredanne