Re: [PATCH 2/6 v2] crypto:s5p-sss: Add device tree support

2014-01-09 Thread Sachin Kamat
Hi Naveen, On 10 January 2014 11:37, Naveen Krishna Ch wrote: > Hello Tomasz, > [snip] >>> *pdev) >>> static struct platform_driver s5p_aes_crypto = { >>> .probe = s5p_aes_probe, >>> .remove = s5p_aes_remove, >>> + .id_table = s5p_sss_ids, >>> .driver = { >

Re: [PATCH 3/6 v2] crypto:s5p-sss: Add support for SSS module on Exynos

2014-01-09 Thread Sachin Kamat
Hi Naveen, On 9 January 2014 10:29, Naveen Krishna Chatradhi wrote: > This patch adds new compatible and varient to support the SSS module > on Exynos4 (Exynos4210), Exynos5 (Exynos5420 and Exynos5250) for which > 1. AES register are at an offset of 0x200 and > 2. hash interrupt is not available

Re: [PATCH 4/6 v2] crypto:s5p-sss: Kconfig: Let Exynos SoCs select SSS driver

2014-01-09 Thread Sachin Kamat
Hi Naveen, On 9 January 2014 10:29, Naveen Krishna Chatradhi wrote: > From: Naveen Krishna Ch > > This patch modifies Kconfig such that ARCH_EXYNOS SoCs > which includes (Exynos4210, Exynos5250 and Exynos5420) > can also select Samsung SSS(Security SubSystem) driver. What about Exynos4x12 and 5

[PATCH 2/3] crypto: ccp-pci: Remove redundant dev_set_drvdata

2013-12-20 Thread Sachin Kamat
Driver core sets it to NULL upon probe failure or release. Signed-off-by: Sachin Kamat --- drivers/crypto/ccp/ccp-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp-pci.c b/drivers/crypto/ccp/ccp-pci.c index 1fbeaf1856a8..f08c16d370cd 100644 --- a/drivers

[PATCH 3/3] crypto: talitos: Remove redundant dev_set_drvdata

2013-12-20 Thread Sachin Kamat
Driver core sets it to NULL upon probe failure or release. Signed-off-by: Sachin Kamat --- drivers/crypto/talitos.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c index a3d2e9b88c41..5967667e1a8f 100644 --- a/drivers/crypto/talitos.c

[PATCH 1/3] crypto: crypto4xx_core: Remove redundant dev_set_drvdata

2013-12-20 Thread Sachin Kamat
Driver core sets it to NULL upon probe failure or release. Signed-off-by: Sachin Kamat --- drivers/crypto/amcc/crypto4xx_core.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto/amcc/crypto4xx_core.c b/drivers/crypto/amcc/crypto4xx_core.c index efaf6302405f..37f9cc98ba17

[PATCH 1/2] crypto: sahara: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat Cc: Javier Martin --- drivers/crypto/sahara.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/sahara.c b/drivers/crypto

[PATCH 2/2] crypto: mv_cesa: Remove redundant of_match_ptr

2013-09-29 Thread Sachin Kamat
The data structure of_match_ptr() protects is always compiled in. Hence of_match_ptr() is not needed. Signed-off-by: Sachin Kamat Cc: Sebastian Andrzej Siewior --- drivers/crypto/mv_cesa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/mv_cesa.c b/drivers

[PATCH 1/2] crypto: tegra-aes: Fix NULL pointer dereference

2013-09-15 Thread Sachin Kamat
'dd' is tested for NULL. However, it is derefenced in the error message print. Change the print to pr_err to avoid this. Signed-off-by: Sachin Kamat --- drivers/crypto/tegra-aes.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/tegra-aes.c

[PATCH 2/2] crypto: tegra-aes: Use devm_clk_get

2013-09-15 Thread Sachin Kamat
devm_clk_get is device managed and makes code simpler. Signed-off-by: Sachin Kamat --- drivers/crypto/tegra-aes.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c index 33f9530..d8c7a13 100644 --- a/drivers/crypto

[PATCH 2/3] crypto: omap-aes - Staticize local symbols

2013-09-13 Thread Sachin Kamat
Local symbols used only in this file are made static. Signed-off-by: Sachin Kamat Cc: Dmitry Kasatkin --- drivers/crypto/omap-aes.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index ce791c2..e1e58d0 100644

[PATCH 1/3] crypto: mv_cesa - Staticize local symbols

2013-09-13 Thread Sachin Kamat
Local symbols used only in this file are made static. Signed-off-by: Sachin Kamat Cc: Sebastian Andrzej Siewior --- drivers/crypto/mv_cesa.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/crypto/mv_cesa.c b/drivers/crypto/mv_cesa.c index 3374a3e

[PATCH 3/3] crypto: tegra-aes - Staticize tegra_aes_cra_exit

2013-09-13 Thread Sachin Kamat
'tegra_aes_cra_exit' is used only in this file. Signed-off-by: Sachin Kamat Cc: Stephen Warren --- drivers/crypto/tegra-aes.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/tegra-aes.c b/drivers/crypto/tegra-aes.c index 2d58da9..4f5f715 10

Re: [PATCH 1/4] crypto: dcp: Remove redundant platform_set_drvdata()

2013-06-04 Thread Sachin Kamat
Hi Tobias, On 5 June 2013 00:51, Tobias Rauter wrote: > On 29.05.2013 13:39, Sachin Kamat wrote: >> >> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no >> driver is bound) removes the need to set driver data field to >> NULL. >> >> Signed-off

[PATCH 4/4] crypto: dcp: Staticize local symbols

2013-05-29 Thread Sachin Kamat
These symbols are referenced only in this file and hence should be static. Signed-off-by: Sachin Kamat --- drivers/crypto/dcp.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c index 49dd560..a8a7dd4 100644 --- a/drivers

[PATCH 3/4] crypto: dcp: Use NULL instead of 0

2013-05-29 Thread Sachin Kamat
Use NULL instead of 0 for pointer variables. Signed-off-by: Sachin Kamat --- drivers/crypto/dcp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c index 9e91c2c..49dd560 100644 --- a/drivers/crypto/dcp.c +++ b/drivers/crypto

[PATCH 2/4] crypto: dcp: Use devm_* APIs

2013-05-29 Thread Sachin Kamat
devm_* APIs are device managed and make cleanup and exit code simpler. Signed-off-by: Sachin Kamat Cc: Tobias Rauter --- drivers/crypto/dcp.c | 32 ++-- 1 file changed, 10 insertions(+), 22 deletions(-) diff --git a/drivers/crypto/dcp.c b/drivers/crypto/dcp.c

[PATCH 1/4] crypto: dcp: Remove redundant platform_set_drvdata()

2013-05-29 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Tobias Rauter --- This series compile tested against linux-next (20130529). --- drivers/crypto/dcp.c |1 - 1 file changed, 1

[PATCH 2/2] crypto: s5p-sss: Remove redundant platform_set_drvdata()

2013-05-03 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Vladimir Zapolskiy --- drivers/crypto/s5p-sss.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/crypto/s5p-sss.c b

[PATCH 1/2] crypto: mv_cesa: Remove redundant platform_set_drvdata()

2013-05-03 Thread Sachin Kamat
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat Cc: Sebastian Andrzej Siewior --- drivers/crypto/mv_cesa.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/crypto

[PATCH 1/1] crypto: picoxcell_crypto: Use of_match_ptr() macro

2013-03-14 Thread Sachin Kamat
This eliminates having an #ifdef returning NULL for the case when OF is disabled. Signed-off-by: Sachin Kamat --- drivers/crypto/picoxcell_crypto.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/picoxcell_crypto.c b/drivers/crypto/picoxcell_crypto.c

[PATCH 2/2] crypto: omap-sham: Use module_platform_driver macro

2013-03-04 Thread Sachin Kamat
module_platform_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Sachin Kamat --- drivers/crypto/omap-sham.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 3d1611f

[PATCH 1/2] crypto: omap-aes: Use module_platform_driver macro

2013-03-04 Thread Sachin Kamat
module_platform_driver() makes the code simpler by eliminating boilerplate code. Signed-off-by: Sachin Kamat --- drivers/crypto/omap-aes.c | 13 + 1 files changed, 1 insertions(+), 12 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 6aa425f

[PATCH 1/1] crypto: s5p-sss: Fix compilation error

2012-11-07 Thread Sachin Kamat
this patch, following build error is observed: arch/arm/plat-samsung/include/plat/dma-pl330.h:106:27: error: redefinition of struct s3c2410_dma_client Signed-off-by: Sachin Kamat --- Build tested using s5pv210_defconfig from the linux-next tree. --- drivers/crypto/s5p-sss.c |2 +- 1 files

Re: [PATCH] crypto: geode-aes: Use module_pci_driver

2012-09-05 Thread Sachin Kamat
Hi, Any comments on this patch? On 27 August 2012 15:45, Sachin Kamat wrote: > module_pci_driver makes the code simpler by eliminating > module_init and module_exit calls. > > Signed-off-by: Sachin Kamat > --- > drivers/crypto/geode-aes.c | 15 +-- >

[PATCH] crypto: geode-aes: Use module_pci_driver

2012-08-27 Thread Sachin Kamat
module_pci_driver makes the code simpler by eliminating module_init and module_exit calls. Signed-off-by: Sachin Kamat --- drivers/crypto/geode-aes.c | 15 +-- 1 files changed, 1 insertions(+), 14 deletions(-) diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c