Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with dma_map_single

2016-03-19 Thread Sinan Kaya
s so that the same driver can be used in a system with IOMMU. The IOMMU DMA ops will remap the DMA address to a bus address that is not physical address. All of this operation needs to be isolated from the device driver. I don't know the architecture or the driver enough to write this. This i

Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with dma_map_single

2016-03-19 Thread Sinan Kaya
On 3/18/2016 9:51 AM, Sinan Kaya wrote: > Another option is I can write > > engine->sram_dma = swiotlb_dma_to_phys(res->start) I realized that I made a mistake in the commit message and the code above. The code is trying to find DMA address from physical address. Not the o

[PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with dma_map_single

2016-03-19 Thread Sinan Kaya
Getting ready to remove dma_to_phys API. Drivers should not be using this API for DMA operations. Instead, they should go through the dma_map or dma_alloc APIs. Signed-off-by: Sinan Kaya --- drivers/crypto/marvell/cesa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 1/3] crypto: marvell/cesa - replace dma_to_phys with dma_map_single

2016-03-19 Thread Sinan Kaya
On 3/18/2016 10:20 AM, Boris Brezillon wrote: > On Fri, 18 Mar 2016 09:51:37 -0400 > Sinan Kaya wrote: > >> On 3/18/2016 7:25 AM, Robin Murphy wrote: >>> On 18/03/16 09:30, Boris Brezillon wrote: >>>> On Thu, 17 Mar 2016 23:50:20 + >>>> Russell