RESEND: Performance loss due to commit 37c3185 ([NET]: Added GSO toggle)

2015-06-25 Thread leroy christophe
Hello Herbert, In commit "[NET]: Added GSO toggle" 37c3185a02d4b85fbe134bf5204535405dd2c957, you force NETIF_F_HW_CSUM if GSO feature is selected. By default, SW GSO is active as soon as a network board has NETIF_F_SG feature. This means that function sk_setup_caps() forces NETIF_F_HW_CSUM for

Re: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility

2015-04-17 Thread leroy christophe
Le 17/04/2015 17:14, David Laight a écrit : From: Christophe Leroy Linux CodyingStyle recommends to use short variables for local variables. ptr is just good enough for those 3 lines functions. It helps keep single lines shorter than 80 characters. ... -static void to_talitos_ptr(struct talito

Re: [PATCH v3 00/17] crypto: talitos - Add support for SEC1

2015-04-17 Thread leroy christophe
Oops, this is the first time I use directly the output of git format-patch into sendmail, and it looks like the mails are dated with the commit date, not today's date. I will resend now with today's date. Sorry for the noise. Christophe Le 17/04/2015 15:47, Christophe Leroy a écrit : The purp

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

2015-03-06 Thread leroy christophe
Le 06/03/2015 01:28, Herbert Xu a écrit : On Thu, Mar 05, 2015 at 06:21:01PM -0600, Kim Phillips wrote: On Thu, 5 Mar 2015 17:46:05 +0100 Christophe Leroy wrote: [15/17] crypto: talitos - Implementation of SEC1 ... [16/17] crypto: talitos - SEC1 bugs on 0 data hash [17/17] crypto: talitos

Re: [PATCH 0/17] crypto: talitos - Add support for SEC1

2015-03-05 Thread leroy christophe
Le 06/03/2015 01:21, Kim Phillips a écrit : On Thu, 5 Mar 2015 17:46:05 +0100 Christophe Leroy wrote: [15/17] crypto: talitos - Implementation of SEC1 ... [16/17] crypto: talitos - SEC1 bugs on 0 data hash [17/17] crypto: talitos - Update DT bindings with SEC1 This patchseries doesn't ap

Re: algif_hash: splice of data > 2**16

2014-12-24 Thread leroy christophe
Le 24/12/2014 10:03, Stephan Mueller a écrit : Am Dienstag, 23. Dezember 2014, 18:16:01 schrieb leroy christophe: Hi leroy, Le 20/12/2014 07:37, Stephan Mueller a écrit : Am Donnerstag, 18. Dezember 2014, 13:22:20 schrieb leroy christophe: Hi Christophe, Le 18/12/2014 13:15, Stephan

Re: algif_hash: splice of data > 2**16

2014-12-23 Thread leroy christophe
Le 20/12/2014 07:37, Stephan Mueller a écrit : Am Donnerstag, 18. Dezember 2014, 13:22:20 schrieb leroy christophe: Hi Christophe, Le 18/12/2014 13:15, Stephan Mueller a écrit : Hi Herbert, While testing the vmsplice/splice interface of algif_hash I was made aware of the problem that data

Re: algif_hash: splice of data > 2**16

2014-12-18 Thread leroy christophe
Le 18/12/2014 13:15, Stephan Mueller a écrit : Hi Herbert, While testing the vmsplice/splice interface of algif_hash I was made aware of the problem that data blobs larger than 16 pages do not seem to be hashed properly. For testing, a file is mmap()ed and handed to vmsplice / splice. If the fi

Freescale SEC1 and AEAD / IPSEC

2014-04-24 Thread leroy christophe
I'm progressing well on the SEC1 implementation. I now have HASH (non HMAC) , DES and AES working properly. So it is now time to look at AEAD. I don't know much yet about crypto algorithm so forgive me if I ask stupid questions. The SEC1 doesn't have the IPSEC descriptor that SEC2 has. However

Freescale SEC1 and HMAC

2014-04-24 Thread leroy christophe
In the Talitos driver, there is a TALITOS_FTR_HMAC_OK flag which is set only for SEC2.1 Is there any reason for that ? According to the doc, SEC2 and SEC1 all seems to support HMAC. However I have tried it on SEC1 and it seems that it doesn't work properly when wanting to perform a continuation

Re: Parity Error on keys used for DES crypto test

2014-04-24 Thread leroy christophe
Le 24/04/2014 01:58, Kim Phillips a écrit : On Wed, 23 Apr 2014 10:20:16 +0200 leroy christophe wrote: I'm altering the Freescale Talitos Driver in order to support the SEC1 security engine, and I have a big issue with the DES test vectors in testmgr.h: The Sec Engine reports key p

Parity Error on keys used for DES crypto test

2014-04-23 Thread leroy christophe
Hi, I'm altering the Freescale Talitos Driver in order to support the SEC1 security engine, and I have a big issue with the DES test vectors in testmgr.h: The Sec Engine reports key parity error. Looking at the keys defined in testmgr.h for DES3, it looks like there is a real parity issue w

Re: Question about Talitos Linux driver for MPC885

2014-04-14 Thread leroy christophe
Le 28/11/2012 00:11, Kim Phillips a écrit : On Fri, 23 Nov 2012 14:51:08 +0100 leroy christophe wrote: Le 26/09/2012 02:47, Kim Phillips a écrit : On Tue, 25 Sep 2012 10:45:17 +0200 leroy christophe wrote: I'm trying to use the Talitos crypto driver with the MPC885 microcontroller

Re: Question about Talitos Linux driver for MPC885

2012-11-23 Thread leroy christophe
x27;m wondering what/where the problem is. Christophe Le 23/11/2012 14:51, leroy christophe a écrit : Dear Kim, Thank you for you quick answer. I didn't have much time to look at it until this week unfortunatly. I have some more questions/observations below Le 26/09/2012 02:47, Kim Philli

Re: Question about Talitos Linux driver for MPC885

2012-11-23 Thread leroy christophe
Dear Kim, Thank you for you quick answer. I didn't have much time to look at it until this week unfortunatly. I have some more questions/observations below Le 26/09/2012 02:47, Kim Phillips a écrit : On Tue, 25 Sep 2012 10:45:17 +0200 leroy christophe wrote: I'm trying to use t

Question about Talitos Linux driver for MPC885

2012-09-25 Thread leroy christophe
Dear Kim, I'm trying to use the Talitos crypto driver with the MPC885 microcontroller. For the time being, it doesn't work. The kernel startup blocks at the test of the DES function. I have added the following definition in the DTS file: crypto@2 { compatible = "fsl,se