Re: [1/1 take 2] HIFN 795x driver.

2007-10-08 Thread Sebastian Siewior
* Herbert Xu | 2007-10-08 11:15:10 [+0800]: On Sat, Oct 06, 2007 at 11:58:57PM +0200, Sebastian Siewior wrote: * Evgeniy Polyakov | 2007-10-02 19:00:13 [+0400]: +MODULE_LICENSE(GPL); +MODULE_AUTHOR(Evgeniy Polyakov [EMAIL PROTECTED]); +MODULE_DESCRIPTION(Driver for HIFN 795x crypto

Re: [1/1 take 2] HIFN 795x driver.

2007-10-07 Thread Herbert Xu
On Sat, Oct 06, 2007 at 11:58:57PM +0200, Sebastian Siewior wrote: * Evgeniy Polyakov | 2007-10-02 19:00:13 [+0400]: +MODULE_LICENSE(GPL); +MODULE_AUTHOR(Evgeniy Polyakov [EMAIL PROTECTED]); +MODULE_DESCRIPTION(Driver for HIFN 795x crypto accelerator chip.); Please also add MODULE_ALIAS

Re: [1/1 take 2] HIFN 795x driver.

2007-10-06 Thread Sebastian Siewior
* Evgeniy Polyakov | 2007-10-02 19:00:13 [+0400]: +MODULE_LICENSE(GPL); +MODULE_AUTHOR(Evgeniy Polyakov [EMAIL PROTECTED]); +MODULE_DESCRIPTION(Driver for HIFN 795x crypto accelerator chip.); Please also add MODULE_ALIAS for algos (that was aes, des and 3des as far as I remember). Sebastian -

Re: [1/1 take 2] HIFN 795x driver.

2007-10-05 Thread Herbert Xu
On Thu, Oct 04, 2007 at 07:04:53PM +0400, Evgeniy Polyakov wrote: It just can not be used in asynchronous hardware, so I will create soemthing new for HIFN driver specially. That sounds good. We can put it into ablkcipher.c and then get rid of the phys stuff from blkcipher.c. Cheers, --

Re: [1/1 take 2] HIFN 795x driver.

2007-10-04 Thread Herbert Xu
On Thu, Oct 04, 2007 at 01:22:20PM +0400, Evgeniy Polyakov wrote: I use ablkcipher_enqueue_request() when hardware can not handle new request, so this should be ok. Good point. I missed that. So there is no problem with the backlog case. But we still need to fix the partial block case.

Re: [1/1 take 2] HIFN 795x driver.

2007-10-04 Thread Evgeniy Polyakov
On Thu, Oct 04, 2007 at 01:49:23PM +0800, Herbert Xu ([EMAIL PROTECTED]) wrote: What is may backlog option? I did not find it in cryptd.c, which I used for reference. I found a backlog variables in the driver, but without any signs for the outside world - queue is initialized and backlog is

Re: [1/1 take 2] HIFN 795x driver.

2007-10-03 Thread Evgeniy Polyakov
On Tue, Oct 02, 2007 at 09:05:12PM +0200, Sebastian Siewior ([EMAIL PROTECTED]) wrote: DES currently does not pass tcrypt's multipage test, since HIFN adapter can not work with non-blocksize aligned chunks, although crypto alignmask is set to 3, tcrypt provides a block of size 2 in its

Re: [1/1 take 2] HIFN 795x driver.

2007-10-03 Thread Herbert Xu
Hi Evgeniy: On Wed, Oct 03, 2007 at 12:41:19PM +0400, Evgeniy Polyakov wrote: It has to be multiple of blocksize. I.e. it is impossible to crypt one byte - hardware will stall, DES test provides two bytes as input - this will not work. If that is going to be handled in driver, then it will

Re: [1/1 take 2] HIFN 795x driver.

2007-10-03 Thread Herbert Xu
On Wed, Oct 03, 2007 at 04:05:18PM +0400, Evgeniy Polyakov wrote: What is may backlog option? I did not find it in cryptd.c, which I used for reference. I found a backlog variables in the driver, but without any signs for the outside world - queue is initialized and backlog is being set to

Re: [1/1 take 2] HIFN 795x driver.

2007-10-02 Thread Sebastian Siewior
* Evgeniy Polyakov | 2007-10-02 19:00:13 [+0400]: DES currently does not pass tcrypt's multipage test, since HIFN adapter can not work with non-blocksize aligned chunks, although crypto alignmask is set to 3, tcrypt provides a block of size 2 in its multipage test, which fails. I recalled now