Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-19 Thread PrasannaKumar Muralidharan
> __ARM_FEATURE_UNALIGNED (cf., > http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0774f/chr1383660321827.html) > . MIPSEL does not define such a macro. > > # MIPS ci20 creator with GCC 4.6 > $ gcc -march=native -dM -E - #define __BIGGEST_ALIGNMENT__ 8 > > If the MIPS CPU

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-19 Thread PrasannaKumar Muralidharan
> Please forgive my ignorance Prasanna... > > For the JZ4780 I have, there are two registers in play. The first is > the control register which enables/disables the RNG. The control > register is named ERNG. The second register is the data register, and > it produces the random stream. The data reg

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-19 Thread Jeffrey Walton
On Wed, Aug 17, 2016 at 11:35 AM, PrasannaKumar Muralidharan wrote: > This patch adds support for hardware random number generator present in > JZ4780 SoC. > > Signed-off-by: PrasannaKumar Muralidharan > --- > ... > +static int jz4780_rng_read(struct hwrng *rng, void *buf, size_t max, bool > wa

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-19 Thread Jeffrey Walton
On Wed, Aug 17, 2016 at 11:35 AM, PrasannaKumar Muralidharan wrote: > This patch adds support for hardware random number generator present in > JZ4780 SoC. > > Signed-off-by: PrasannaKumar Muralidharan > --- > .../devicetree/bindings/rng/ingenic,jz4780-rng.txt | 12 +++ > MAINTAINERS

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-18 Thread Rob Herring
On Wed, Aug 17, 2016 at 09:05:51PM +0530, PrasannaKumar Muralidharan wrote: > This patch adds support for hardware random number generator present in > JZ4780 SoC. > > Signed-off-by: PrasannaKumar Muralidharan > --- > .../devicetree/bindings/rng/ingenic,jz4780-rng.txt | 12 +++ Acked-by: Rob He

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-18 Thread Daniel Thompson
On 18/08/16 12:53, LABBE Corentin wrote: On Thu, Aug 18, 2016 at 10:44:18AM +0530, PrasannaKumar Muralidharan wrote: +static int jz4780_rng_read(struct hwrng *rng, void *buf, size_t max, bool wait) +{ + struct jz4780_rng *jz4780_rng = container_of(rng, struct jz4780_rng, +

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-18 Thread LABBE Corentin
On Thu, Aug 18, 2016 at 10:44:18AM +0530, PrasannaKumar Muralidharan wrote: > >> +static int jz4780_rng_read(struct hwrng *rng, void *buf, size_t max, bool > >> wait) > >> +{ > >> + struct jz4780_rng *jz4780_rng = container_of(rng, struct jz4780_rng, > >> +

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-17 Thread PrasannaKumar Muralidharan
> I have just some minor comments below Appreciate your review. >> diff --git a/drivers/char/hw_random/jz4780-rng.c >> b/drivers/char/hw_random/jz4780-rng.c >> new file mode 100644 >> index 000..c9d2cde >> --- /dev/null >> +++ b/drivers/char/hw_random/jz4780-rng.c >> @@ -0,0 +1,105 @@ >> +/*

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-17 Thread Corentin LABBE
Hello I have just some minor comments below > diff --git a/drivers/char/hw_random/jz4780-rng.c > b/drivers/char/hw_random/jz4780-rng.c > new file mode 100644 > index 000..c9d2cde > --- /dev/null > +++ b/drivers/char/hw_random/jz4780-rng.c > @@ -0,0 +1,105 @@ > +/* > + * jz4780-rng.c - Random

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-17 Thread PrasannaKumar Muralidharan
On 17 August 2016 at 21:31, Daniel Thompson wrote: > On 17/08/16 16:35, PrasannaKumar Muralidharan wrote: >> >> This patch adds support for hardware random number generator present in >> JZ4780 SoC. >> >> Signed-off-by: PrasannaKumar Muralidharan >> --- >> .../devicetree/bindings/rng/ingenic,jz4

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-17 Thread Daniel Thompson
On 17/08/16 16:35, PrasannaKumar Muralidharan wrote: This patch adds support for hardware random number generator present in JZ4780 SoC. Signed-off-by: PrasannaKumar Muralidharan --- .../devicetree/bindings/rng/ingenic,jz4780-rng.txt | 12 +++ MAINTAINERS

[PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-17 Thread PrasannaKumar Muralidharan
This patch adds support for hardware random number generator present in JZ4780 SoC. Signed-off-by: PrasannaKumar Muralidharan --- .../devicetree/bindings/rng/ingenic,jz4780-rng.txt | 12 +++ MAINTAINERS| 5 + arch/mips/boot/dts/ingenic/jz4780.dtsi