On Mon, Apr 24, 2017 at 11:01:50AM +0200, Stephan Müller wrote:
>
> Shall I send an updated patch with aead_sock_destruct cleared?
Yes please.
Thanks,
--
Email: Herbert Xu
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
Am Montag, 24. April 2017, 10:43:24 CEST schrieb Herbert Xu:
Hi Herbert,
> On Fri, Apr 21, 2017 at 06:35:07PM +0200, Stephan Müller wrote:
> > After checking again, IMHO that is no unreleated cleanup or even a cleanup
> > at all.
> >
> > void *private used to be struct crypto_aead and is now str
On Fri, Apr 21, 2017 at 06:35:07PM +0200, Stephan Müller wrote:
>
> After checking again, IMHO that is no unreleated cleanup or even a cleanup at
> all.
>
> void *private used to be struct crypto_aead and is now struct aead_tfm.
> struct
> crypto_aead is found in private->aead. Hence, the patch
Am Freitag, 21. April 2017, 13:11:27 CEST schrieb Herbert Xu:
Hi Herbert,
> Please don't mix unrelated cleanups like this with the real change.
> It makes reviewing harder than necessary.
Apologies. I will resend it shortly.
Ciao
Stephan
Am Freitag, 21. April 2017, 13:11:27 CEST schrieb Herbert Xu:
Hi Herbert,
> On Mon, Apr 10, 2017 at 01:59:21PM +0200, Stephan Müller wrote:
> > @@ -757,12 +887,14 @@ static void aead_sock_destruct(struct sock *sk)
> >
> > af_alg_release_parent(sk);
> >
> > }
> >
> > -static int aead_acce
On Mon, Apr 10, 2017 at 01:59:21PM +0200, Stephan Müller wrote:
>
> @@ -757,12 +887,14 @@ static void aead_sock_destruct(struct sock *sk)
> af_alg_release_parent(sk);
> }
>
> -static int aead_accept_parent(void *private, struct sock *sk)
> +static int aead_accept_parent_nokey(void *private
Some cipher implementations will crash if you try to use them
without calling setkey first. This patch adds a check so that
the accept(2) call will fail with -ENOKEY if setkey hasn't been
done on the socket yet.
Signed-off-by: Stephan Mueller
---
crypto/algif_aead.c | 164 ++
