Hi Tudor,
On Wed, Mar 21, 2018 at 03:15:27PM +0200, Tudor Ambarus wrote:
> On 02/23/2018 02:37 PM, Antoine Tenart wrote:
> > On Fri, Feb 23, 2018 at 02:04:33PM +0200, Tudor Ambarus wrote:
> > >
> > > There are few other places in crypto where we extract the authenc keys
> > > in the same type of
Hi, Antoine,
On 02/23/2018 02:37 PM, Antoine Tenart wrote:
Hi Tudor,
On Fri, Feb 23, 2018 at 02:04:33PM +0200, Tudor Ambarus wrote:
There are few other places in crypto where we extract the authenc keys
in the same type of local variable, struct crypto_authenc_keys keys, and
we don't zeroize
On Fri, Feb 23, 2018 at 10:01:40AM +0100, Antoine Tenart wrote:
> The Atmel AES driver uses memzero_explicit on the keys on error, but the
> variable zeroed isn't the right one because of a typo. Fix this by using
> the right variable.
>
> Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support
Hi Tudor,
On Fri, Feb 23, 2018 at 02:04:33PM +0200, Tudor Ambarus wrote:
>
> There are few other places in crypto where we extract the authenc keys
> in the same type of local variable, struct crypto_authenc_keys keys, and
> we don't zeroize it after use. I think we should fix those cases too.
Thanks Antoine,
On 02/23/2018 11:01 AM, Antoine Tenart wrote:
The Atmel AES driver uses memzero_explicit on the keys on error, but the
variable zeroed isn't the right one because of a typo. Fix this by using
the right variable.
Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to
The Atmel AES driver uses memzero_explicit on the keys on error, but the
variable zeroed isn't the right one because of a typo. Fix this by using
the right variable.
Fixes: 89a82ef87e01 ("crypto: atmel-authenc - add support to
authenc(hmac(shaX), Y(aes)) modes")
Signed-off-by: Antoine Tenart
