Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-05-15 Thread Ben Hutchings
On Wed, 2016-04-27 at 12:17 +0800, Herbert Xu wrote: > On Tue, Apr 26, 2016 at 01:42:56PM +0200, Ben Hutchings wrote: > > > > > > It looks like the bug was introduced in 3.10 by: > > > > d733ac90f9fe8ac284e523f9920b507555b12f6d > > Author: Jussi Kivilinna > > Date:   

Patch "crypto: gcm - Fix rfc4543 decryption crash" has been added to the 3.14-stable tree

2016-05-01 Thread gregkh
This is a note to let you know that I've just added the patch titled crypto: gcm - Fix rfc4543 decryption crash to the 3.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is:

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-04-26 Thread Herbert Xu
On Tue, Apr 26, 2016 at 01:42:56PM +0200, Ben Hutchings wrote: > > It looks like the bug was introduced in 3.10 by: > > d733ac90f9fe8ac284e523f9920b507555b12f6d > Author: Jussi Kivilinna > Date:   Sun Apr 7 16:43:46 2013 +0300 > > crypto: gcm - fix rfc4543 to handle

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-04-26 Thread Ben Hutchings
On Fri, 2016-03-18 at 22:42 +0800, Herbert Xu wrote: > This bug has already bee fixed upstream since 4.2.  However, it > was fixed during the AEAD conversion so no fix was backported to > the older kernels. > > When we do an RFC 4543 decryption, we will end up writing the > ICV beyond the end of

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-04-26 Thread Ben Hutchings
On Sat, 2016-03-19 at 10:23 +0800, Herbert Xu wrote: > On Fri, Mar 18, 2016 at 10:34:23AM -0700, Greg KH wrote: > > > > On Fri, Mar 18, 2016 at 10:42:40PM +0800, Herbert Xu wrote: > > > > > > This bug has already bee fixed upstream since 4.2.  However, it > > > was fixed during the AEAD

[PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-03-19 Thread Herbert Xu
This bug has already bee fixed upstream since 4.2. However, it was fixed during the AEAD conversion so no fix was backported to the older kernels. When we do an RFC 4543 decryption, we will end up writing the ICV beyond the end of the dst buffer. This should lead to a crash but for some reason

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-03-19 Thread Herbert Xu
On Fri, Mar 18, 2016 at 10:34:23AM -0700, Greg KH wrote: > On Fri, Mar 18, 2016 at 10:42:40PM +0800, Herbert Xu wrote: > > This bug has already bee fixed upstream since 4.2. However, it > > was fixed during the AEAD conversion so no fix was backported to > > the older kernels. > > What was the

Re: [PATCH] crypto: gcm - Fix rfc4543 decryption crash

2016-03-19 Thread Greg KH
On Fri, Mar 18, 2016 at 10:42:40PM +0800, Herbert Xu wrote: > This bug has already bee fixed upstream since 4.2. However, it > was fixed during the AEAD conversion so no fix was backported to > the older kernels. What was the commit id of that fix? > > When we do an RFC 4543 decryption, we