Re: [PATCH] crypto: powerpc - Fix initialisation of crc32c context

2017-03-08 Thread Herbert Xu
Daniel Axtens wrote: > Turning on crypto self-tests on a POWER8 shows: > >alg: hash: Test 1 failed for crc32c-vpmsum >: ff ff ff ff > > Comparing the code with the Intel CRC32c implementation on which > ours is based shows that we are doing an init with 0, not

Re: [PATCH] crypto: powerpc - Fix initialisation of crc32c context

2017-03-05 Thread Michael Ellerman
Daniel Axtens writes: > Turning on crypto self-tests on a POWER8 shows: > > alg: hash: Test 1 failed for crc32c-vpmsum > : ff ff ff ff > > Comparing the code with the Intel CRC32c implementation on which > ours is based shows that we are doing an init with 0, not

Re: [PATCH] crypto: powerpc - Fix initialisation of crc32c context

2017-03-05 Thread Anton Blanchard
Hi Daniel, > Turning on crypto self-tests on a POWER8 shows: > > alg: hash: Test 1 failed for crc32c-vpmsum > : ff ff ff ff > > Comparing the code with the Intel CRC32c implementation on which > ours is based shows that we are doing an init with 0, not ~0 > as CRC32c requires. >

[PATCH] crypto: powerpc - Fix initialisation of crc32c context

2017-03-02 Thread Daniel Axtens
Turning on crypto self-tests on a POWER8 shows: alg: hash: Test 1 failed for crc32c-vpmsum : ff ff ff ff Comparing the code with the Intel CRC32c implementation on which ours is based shows that we are doing an init with 0, not ~0 as CRC32c requires. This probably wasn't caught