Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

2014-04-17 Thread Marek Vasut
On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote: Commit 128ea04a9885(lto: Make asmlinkage __visible) restricts asmlinkage to externally_visible, this causes compilation warnings: arch/x86/crypto/sha256_ssse3_glue.c:56:1: warning: ‘externally_visible’ attribute have

Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

2014-04-17 Thread H. Peter Anvin
On 04/17/2014 08:28 AM, Marek Vasut wrote: On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote: Commit 128ea04a9885(lto: Make asmlinkage __visible) restricts asmlinkage to externally_visible, this causes compilation warnings: arch/x86/crypto/sha256_ssse3_glue.c:56:1:

Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

2014-04-17 Thread Herbert Xu
On Thu, Apr 17, 2014 at 09:49:56PM -0700, H. Peter Anvin wrote: On 04/17/2014 08:28 AM, Marek Vasut wrote: On Wednesday, April 16, 2014 at 06:19:50 PM, Jianyu Zhan wrote: Commit 128ea04a9885(lto: Make asmlinkage __visible) restricts asmlinkage to externally_visible, this causes compilation

Re: [PATCH] crypto: sha{256,512}_ssse3 - remove asmlinkage from static functions

2014-04-17 Thread H. Peter Anvin
On 04/17/2014 09:58 PM, Herbert Xu wrote: It doesn't make sense, sorry. The right thing to drop here is not asmlinkage, it is static: this is an external declaration. It's a function pointer that's static, not the function that it's pointing to. {facepalm} Right, function *pointer*.