Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-03-02 Thread Herbert Xu
On Thu, Feb 26, 2009 at 11:20:26PM +, Russell King - ARM Linux wrote: I don't think you can use chained scatterlists unless the architecture supports it. It's not a case that you have to flatten the chaining before passing it over to the arch - it seems you're not allowed to create a

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-27 Thread Christian Hohnstaedt
On Thu, Feb 26, 2009 at 09:27:09PM +0100, Karl Hiramoto wrote: Herbert Xu wrote: Russell King - ARM Linux li...@arm.linux.org.uk wrote: We can't merge this until _all_ of ARM has been fixed for walking scatterlist chains. Right, this is definitely not the way to fix this bug.

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-26 Thread Russell King - ARM Linux
On Wed, Feb 25, 2009 at 04:35:40PM +0100, Karl Hiramoto wrote: The attached patch fixes my issue, but am not sure if it is correct or will cause problems else where. diff -Naurp linux-2.6.28.7.a/arch/arm/include/asm/scatterlist.h linux-2.6.28.7.b/arch/arm/include/asm/scatterlist.h ---

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-26 Thread Herbert Xu
Russell King - ARM Linux li...@arm.linux.org.uk wrote: We can't merge this until _all_ of ARM has been fixed for walking scatterlist chains. Right, this is definitely not the way to fix this bug. Because even if ARM completely supported chaining, you still have to fix all the other

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-26 Thread Karl Hiramoto
Herbert Xu wrote: Russell King - ARM Linux li...@arm.linux.org.uk wrote: We can't merge this until _all_ of ARM has been fixed for walking scatterlist chains. Right, this is definitely not the way to fix this bug. Because even if ARM completely supported chaining, you still have to

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-26 Thread Russell King - ARM Linux
On Thu, Feb 26, 2009 at 08:10:43PM +0800, Herbert Xu wrote: Russell King - ARM Linux li...@arm.linux.org.uk wrote: We can't merge this until _all_ of ARM has been fixed for walking scatterlist chains. Right, this is definitely not the way to fix this bug. Because even if ARM completely

Re: [PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-26 Thread Herbert Xu
Russell King - ARM Linux li...@arm.linux.org.uk wrote: I don't think you can use chained scatterlists unless the architecture supports it. It's not a case that you have to flatten the chaining before passing it over to the arch - it seems you're not allowed to create a chained scatterlist in

Re: Re:[PATCH] ixp4xx_crypto panic with fragmented packets in scatterlist

2009-02-25 Thread Herbert Xu
Karl Hiramoto k...@hiramoto.org wrote: The attached patch fixes my issue, but am not sure if it is correct or will cause problems else where. This is what we'll do once generic chaining is available on all architectures. Until then it's up to the driver to fix the SG list up before passing