Re: [PATCH] trusted-keys: skcipher bug info

2016-09-20 Thread Mimi Zohar
On Tue, 2016-09-20 at 20:35 +0800, Herbert Xu wrote: > On Tue, Sep 20, 2016 at 08:11:51AM -0400, Mimi Zohar wrote: > > Hi Herbert, > > > > The initial random iv value, initialized in encrypted_init(), should > > not be modified. Commit c3917fd "KEYS: Use skcipher", which replaced > > the

Re: [PATCH] trusted-keys: skcipher bug info

2016-09-20 Thread Herbert Xu
On Tue, Sep 20, 2016 at 08:11:51AM -0400, Mimi Zohar wrote: > Hi Herbert, > > The initial random iv value, initialized in encrypted_init(), should > not be modified. Commit c3917fd "KEYS: Use skcipher", which replaced > the blkcipher with skcipher, modifies the iv in >

[PATCH] trusted-keys: skcipher bug info

2016-09-20 Thread Mimi Zohar
Hi Herbert, The initial random iv value, initialized in encrypted_init(), should not be modified. Commit c3917fd "KEYS: Use skcipher", which replaced the blkcipher with skcipher, modifies the iv in crypto_skcipher_encrypt()/decrypt(). The following example creates an encrypted key, writes the