Re: [PATCH 00/17] Multiple changes to crypto/ansi_cprng.c

2014-12-05 Thread Neil Horman
On Wed, Dec 03, 2014 at 03:27:53PM -0500, George Spelvin wrote: So, generally speaking I'm ok with most of this I think, One open issue... I thought you had said that the non-determinsitic version was not in the current X9.31 and I had the impression that it wasn't wanted. I've got

Re: [PATCH 00/17] Multiple changes to crypto/ansi_cprng.c

2014-12-04 Thread Stephan Mueller
Am Mittwoch, 3. Dezember 2014, 15:27:53 schrieb George Spelvin: Hi George, but before it goes anywhere, it really needs to pass the NIST and FIPS test vectors. Can you do that please and post the results? It of course passes the ones in testmgr.h, and I can add the others from

Re: [PATCH 00/17] Multiple changes to crypto/ansi_cprng.c

2014-12-03 Thread Neil Horman
On Tue, Dec 02, 2014 at 03:33:14AM -0500, George Spelvin wrote: Thank you all for your hospitality to my amateurish efforts. Given that this all started with me reading the code in an attempt to understand it, it is likely that some of the problems I address are actually misunderstandings on

Re: [PATCH 00/17] Multiple changes to crypto/ansi_cprng.c

2014-12-03 Thread George Spelvin
So, generally speaking I'm ok with most of this I think, One open issue... I thought you had said that the non-determinsitic version was not in the current X9.31 and I had the impression that it wasn't wanted. I've got reorganized patch series that gets rid of that and just tweaks the comments.

[PATCH 00/17] Multiple changes to crypto/ansi_cprng.c

2014-12-02 Thread George Spelvin
Thank you all for your hospitality to my amateurish efforts. Given that this all started with me reading the code in an attempt to understand it, it is likely that some of the problems I address are actually misunderstandings on my part. If all I get from this patch series is some enlightenment,