[PATCH 1/3] sha512: make it work, undo percpu message schedule

2012-01-14 Thread Alexey Dobriyan
commit f9e2bca6c22d75a289a349f869701214d63b5060 aka crypto: sha512 - Move message schedule W[80] to static percpu area created global message schedule area. If sha512_update will ever be entered twice, hash will be silently calculated incorrectly. Probably the easiest way to notice incorrect

Re: [PATCH 1/3] sha512: make it work, undo percpu message schedule

2012-01-14 Thread Eric Dumazet
Le samedi 14 janvier 2012 à 21:27 +0300, Alexey Dobriyan a écrit : commit f9e2bca6c22d75a289a349f869701214d63b5060 aka crypto: sha512 - Move message schedule W[80] to static percpu area created global message schedule area. Signed-off-by: Alexey Dobriyan adobri...@gmail.com Cc:

Re: [PATCH 1/3] sha512: make it work, undo percpu message schedule

2012-01-14 Thread Linus Torvalds
On Sat, Jan 14, 2012 at 1:46 PM, Eric Dumazet eric.duma...@gmail.com wrote: This is too risky, and we provided an alternate patch, not just for fun. Did you see the second patch? The one that got rid of the *stupid* 80-entry array? I don't know why so many sha implementations do that idiotic

Re: [PATCH 1/3] sha512: make it work, undo percpu message schedule

2012-01-14 Thread Eric Dumazet
Le samedi 14 janvier 2012 à 13:52 -0800, Linus Torvalds a écrit : On Sat, Jan 14, 2012 at 1:46 PM, Eric Dumazet eric.duma...@gmail.com wrote: This is too risky, and we provided an alternate patch, not just for fun. Did you see the second patch? I saw it and felt it was not a stable

Re: [PATCH 1/3] sha512: make it work, undo percpu message schedule

2012-01-14 Thread Herbert Xu
On Sat, Jan 14, 2012 at 09:27:37PM +0300, Alexey Dobriyan wrote: commit f9e2bca6c22d75a289a349f869701214d63b5060 aka crypto: sha512 - Move message schedule W[80] to static percpu area created global message schedule area. If sha512_update will ever be entered twice, hash will be silently