[PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to linux/slab_def.h

2010-05-19 Thread David Woodhouse
Signed-off-by: David Woodhouse david.woodho...@intel.com --- include/linux/slab_def.h | 24 mm/slab.c| 24 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/include/linux/slab_def.h b/include/linux/slab_def.h

Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to linux/slab_def.h

2010-05-19 Thread Johannes Stezenbach
Hi, I have some comments/questions, I hope it's not too silly: On Wed, May 19, 2010 at 12:01:42PM +0100, David Woodhouse wrote: +#ifndef ARCH_KMALLOC_MINALIGN +/* + * Enforce a minimum alignment for the kmalloc caches. + * Usually, the kmalloc caches are cache_line_size() aligned, except

Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to linux/slab_def.h

2010-05-19 Thread Manfred Spraul
On 05/19/2010 03:30 PM, Johannes Stezenbach wrote: Hi, I have some comments/questions, I hope it's not too silly: On Wed, May 19, 2010 at 12:01:42PM +0100, David Woodhouse wrote: +#ifndef ARCH_KMALLOC_MINALIGN +/* + * Enforce a minimum alignment for the kmalloc caches. + * Usually, the

Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to linux/slab_def.h

2010-05-19 Thread David Woodhouse
On Wed, 2010-05-19 at 14:19 -0500, Christoph Lameter wrote: Maybe we can consolidate that into slab.h so that the alignment is the same for all allocators? Doing so at least for slub and slab would make sense. I wanted to move them first though, as a separate step. -- David Woodhouse

Re: [PATCH 1/4] mm: Move ARCH_SLAB_MINALIGN and ARCH_KMALLOC_MINALIGN to linux/slab_def.h

2010-05-19 Thread Christoph Lameter
On Wed, 19 May 2010, Pekka Enberg wrote: Christoph Lameter wrote: Maybe we can consolidate that into slab.h so that the alignment is the same for all allocators? But we don't want that for SLOB as discussed in the other thread. It really wants to be sizeof(unsigned long), not