Re: [PATCH 2/2] MIPS: crypto: Add crc32 and crc32c hw accelerated module

2017-10-04 Thread Marcin Nowakowski
Hi James, On 03.10.2017 08:38, Marcin Nowakowski wrote: The need for 64-bit signed length is unfortunate. Do you get decent assembly and comparable/better performance on 32-bit if you just use len and only decrement it in the loops? i.e. -   while ((length -= sizeof(uXX)) >= 0) { +  

Re: [PATCH 2/2] MIPS: crypto: Add crc32 and crc32c hw accelerated module

2017-10-02 Thread Marcin Nowakowski
Hi Jonas, James, On 02.10.2017 16:20, Jonas Gorski wrote: On 29 September 2017 at 23:34, James Hogan wrote: Hi Marcin, On Wed, Sep 27, 2017 at 02:18:36PM +0200, Marcin Nowakowski wrote: This module registers crc32 and crc32c algorithms that use the optional CRC32[bhwd] and CRC32C[bhwd] instr

Re: [PATCH 2/2] MIPS: crypto: Add crc32 and crc32c hw accelerated module

2017-10-02 Thread Jonas Gorski
On 29 September 2017 at 23:34, James Hogan wrote: > Hi Marcin, > > On Wed, Sep 27, 2017 at 02:18:36PM +0200, Marcin Nowakowski wrote: >> This module registers crc32 and crc32c algorithms that use the >> optional CRC32[bhwd] and CRC32C[bhwd] instructions in MIPSr6 cores. >> >> Signed-off-by: Marcin

Re: [PATCH 2/2] MIPS: crypto: Add crc32 and crc32c hw accelerated module

2017-09-29 Thread James Hogan
Hi Marcin, On Wed, Sep 27, 2017 at 02:18:36PM +0200, Marcin Nowakowski wrote: > This module registers crc32 and crc32c algorithms that use the > optional CRC32[bhwd] and CRC32C[bhwd] instructions in MIPSr6 cores. > > Signed-off-by: Marcin Nowakowski > Cc: linux-crypto@vger.kernel.org > Cc: Herbe

[PATCH 2/2] MIPS: crypto: Add crc32 and crc32c hw accelerated module

2017-09-27 Thread Marcin Nowakowski
This module registers crc32 and crc32c algorithms that use the optional CRC32[bhwd] and CRC32C[bhwd] instructions in MIPSr6 cores. Signed-off-by: Marcin Nowakowski Cc: linux-crypto@vger.kernel.org Cc: Herbert Xu Cc: "David S. Miller" --- arch/mips/Kconfig | 4 + arch/mips/Makefi