Re: [PATCH 2/2 v2] talitos: Freescale integrated security engine (SEC) driver

2008-06-05 Thread Herbert Xu
On Thu, Jun 05, 2008 at 04:44:15PM -0500, Kim Phillips wrote: > > it is :). I'm working on it :). Good :) > the h/w has a IV out feature we should probably be using. How about > something like this (UNTESTED): Looks great! Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert

Re: [PATCH 2/2 v2] talitos: Freescale integrated security engine (SEC) driver

2008-06-05 Thread Kim Phillips
On Thu, 5 Jun 2008 15:22:24 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote: > On Fri, May 30, 2008 at 06:58:30PM -0500, Kim Phillips wrote: > > > > + /* get random IV */ > > + get_random_bytes(req->giv, crypto_aead_ivsize(authenc)); > > Sorry but this is unworkable given our current RNG infrastru

Re: [PATCH 2/2 v2] talitos: Freescale integrated security engine (SEC) driver

2008-06-04 Thread Herbert Xu
On Fri, May 30, 2008 at 06:58:30PM -0500, Kim Phillips wrote: > > + /* get random IV */ > + get_random_bytes(req->giv, crypto_aead_ivsize(authenc)); Sorry but this is unworkable given our current RNG infrastructure. Draining 16 bytes for every packet is going to make /dev/random unuseable

[PATCH 2/2 v2] talitos: Freescale integrated security engine (SEC) driver

2008-05-30 Thread Kim Phillips
Add support for the SEC available on a wide range of PowerQUICC devices, e.g. MPC8349E, MPC8548E. this initial version supports authenc(hmac(sha1),cbc(aes)) for use with IPsec. Signed-off-by: Kim Phillips <[EMAIL PROTECTED]> --- removed priv->status hw interrupt status assignment. Done tasklet no