Re: [PATCH v1.4 3/5] key: add tpm_send command

2010-11-19 Thread David Howells
David Safford wrote: > Currently transmit_command() in tpm.c expects an int, > but it changes it to size_t for the actual tpm_transmit(). > We will work with Rajiv to do a cleanup, as this touches > a number of calls. You can pass a size_t value to an int. The compiler will cast automatically.

Re: [PATCH v1.4 3/5] key: add tpm_send command

2010-11-19 Thread David Safford
On Fri, 2010-11-19 at 15:45 +, David Howells wrote: > Mimi Zohar wrote: > > > +int tpm_send(u32 chip_num, void *cmd, int buflen) > > I'd recommend size_t for buflen; apart from that: > > Acked-by: David Howells right - that would be better. Currently transmit_command() in tpm.c expects a

Re: [PATCH v1.4 3/5] key: add tpm_send command

2010-11-19 Thread David Howells
Mimi Zohar wrote: > +int tpm_send(u32 chip_num, void *cmd, int buflen) I'd recommend size_t for buflen; apart from that: Acked-by: David Howells -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v1.4 3/5] key: add tpm_send command

2010-11-18 Thread Mimi Zohar
Add internal kernel tpm_send() command used to seal/unseal keys. Changelog: - replaced module_put in tpm_send() with new tpm_chip_put() wrapper (suggested by David Howells) - Make tpm_send() cmd argument a 'void *' (suggested by David Howells) Signed-off-by: David Safford Signed-off-by: Mimi Z