Re: [PATCH v1.5 5/5] keys: add new key-type encrypted

2010-12-08 Thread David Howells
Mimi Zohar zo...@linux.vnet.ibm.com wrote: +static struct key *request_trusted_key(const char *trusted_desc, +u8 **master_key, +unsigned int *master_keylen) You need to annotate the function with an __acquires() to

Re: [PATCH v1.5 5/5] keys: add new key-type encrypted

2010-12-07 Thread Mimi Zohar
On Fri, 2010-12-03 at 13:42 +, David Howells wrote: Mimi Zohar zo...@linux.vnet.ibm.com wrote: +#define KEY_TRUSTED_PREFIX trusted: +#define KEY_TRUSTED_PREFIX_LEN (sizeof (KEY_TRUSTED_PREFIX) - 1) +#define KEY_USER_PREFIX user: +#define KEY_USER_PREFIX_LEN (sizeof

Re: [PATCH v1.5 5/5] keys: add new key-type encrypted

2010-12-03 Thread David Howells
Mimi Zohar zo...@linux.vnet.ibm.com wrote: +#define KEY_TRUSTED_PREFIX trusted: +#define KEY_TRUSTED_PREFIX_LEN (sizeof (KEY_TRUSTED_PREFIX) - 1) +#define KEY_USER_PREFIX user: +#define KEY_USER_PREFIX_LEN (sizeof (KEY_USER_PREFIX) - 1) I'd recommend using static const char arrays. +static

[PATCH v1.5 5/5] keys: add new key-type encrypted

2010-11-24 Thread Mimi Zohar
Sorry for the multiple postings, misconfigured mailer bounced patch 5. Resending ... Define a new kernel key-type called 'encrypted'. Encrypted keys are kernel generated random numbers, which are encrypted/decrypted with a 'trusted' symmetric key. Encrypted keys are created/encrypted/decrypted in