Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-13 Thread Ard Biesheuvel
On 13 April 2015 at 06:13, Herbert Xu herb...@gondor.apana.org.au wrote: On Sat, Apr 11, 2015 at 09:15:10PM +0200, Ard Biesheuvel wrote: @Herbert: could you please apply this onto cryptodev before sending out your pull request for v4.1? Done. And please disregard $subject, I will post a v3

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-12 Thread Herbert Xu
On Sat, Apr 11, 2015 at 09:15:10PM +0200, Ard Biesheuvel wrote: @Herbert: could you please apply this onto cryptodev before sending out your pull request for v4.1? Done. And please disregard $subject, I will post a v3 with a similar 'depends on' added (unless you're ok to add it yourself)

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-11 Thread Ard Biesheuvel
On 11 April 2015 at 10:48, Arnd Bergmann a...@arndb.de wrote: On Saturday 11 April 2015 09:35:15 Ard Biesheuvel wrote: On 10 April 2015 at 22:23, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 10 apr. 2015, at 22:08, Arnd Bergmann a...@arndb.de wrote: On Friday 10 April 2015 16:29:08

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-11 Thread Arnd Bergmann
On Saturday 11 April 2015 12:27:18 Ard Biesheuvel wrote: Ah i see it now. The new Sha256 module as well as the Sha512 i am proposing here both use a single .o containing the !neon and neon implementations, and only expose the latter if KERNEL_MODE_NEON. This way, we can use the exact same

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-11 Thread Arnd Bergmann
On Saturday 11 April 2015 09:35:15 Ard Biesheuvel wrote: On 10 April 2015 at 22:23, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 10 apr. 2015, at 22:08, Arnd Bergmann a...@arndb.de wrote: On Friday 10 April 2015 16:29:08 Ard Biesheuvel wrote: +#if __ARM_MAX_ARCH__=7 +.arch

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-11 Thread Ard Biesheuvel
On 10 April 2015 at 22:23, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 10 apr. 2015, at 22:08, Arnd Bergmann a...@arndb.de wrote: On Friday 10 April 2015 16:29:08 Ard Biesheuvel wrote: +#if __ARM_MAX_ARCH__=7 +.arch armv7-a +.fpu neon + This will cause a build failure on an

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-11 Thread Ard Biesheuvel
On 11 apr. 2015, at 10:48, Arnd Bergmann a...@arndb.de wrote: On Saturday 11 April 2015 09:35:15 Ard Biesheuvel wrote: On 10 April 2015 at 22:23, Ard Biesheuvel ard.biesheu...@linaro.org wrote: On 10 apr. 2015, at 22:08, Arnd Bergmann a...@arndb.de wrote: On Friday 10 April 2015

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-10 Thread Arnd Bergmann
On Friday 10 April 2015 16:29:08 Ard Biesheuvel wrote: +#if __ARM_MAX_ARCH__=7 +.arch armv7-a +.fpu neon + This will cause a build failure on an ARMv7-M build, which is incompatible with .arch armv7-a and .fpu neon. Arnd -- To unsubscribe from this list: send the line

Re: [PATCH v2] crypto/arm: accelerated SHA-512 using ARM generic ASM and NEON

2015-04-10 Thread Ard Biesheuvel
On 10 apr. 2015, at 22:08, Arnd Bergmann a...@arndb.de wrote: On Friday 10 April 2015 16:29:08 Ard Biesheuvel wrote: +#if __ARM_MAX_ARCH__=7 +.arch armv7-a +.fpu neon + This will cause a build failure on an ARMv7-M build, which is incompatible with .arch armv7-a and .fpu neon.