Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-27 Thread Imre Kaloz
On Mon, 25 May 2015 13:17:13 +0200, Boris Brezillon boris.brezil...@free-electrons.com wrote: Sorry, I didn't word it right - the series is missing the crypto nodes for the orion, 375 and 38x platforms. I only add nodes for platforms I have tested on. If you're able to test on those

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Herbert Xu
On Fri, May 22, 2015 at 03:33:48PM +0200, Boris Brezillon wrote: +struct ahash_alg mv_ahmac_sha1_alg = { + .init = mv_cesa_ahmac_sha1_init, + .update = mv_cesa_ahash_update, + .final = mv_cesa_ahash_final, + .finup = mv_cesa_ahash_finup, + .digest =

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Herbert Xu
On Mon, May 25, 2015 at 10:10:16AM +0200, Boris Brezillon wrote: Yep, I noticed that after submitting this version. I guess I only needed the import function for my test cases and thus forgot to implement the import function. Anyway, I just added the the import functions (they'll be available

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Boris Brezillon
Hi Herbert, On Mon, 25 May 2015 15:58:12 +0800 Herbert Xu herb...@gondor.apana.org.au wrote: On Fri, May 22, 2015 at 03:33:48PM +0200, Boris Brezillon wrote: +static int mv_cesa_sha1_export(struct ahash_request *req, void *out) +{ + struct sha1_state *out_state = out; + struct

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Boris Brezillon
On Mon, 25 May 2015 16:05:47 +0800 Herbert Xu herb...@gondor.apana.org.au wrote: On Fri, May 22, 2015 at 03:33:48PM +0200, Boris Brezillon wrote: +struct ahash_alg mv_ahmac_sha1_alg = { + .init = mv_cesa_ahmac_sha1_init, + .update = mv_cesa_ahash_update, + .final =

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Herbert Xu
On Mon, May 25, 2015 at 10:18:11AM +0200, Boris Brezillon wrote: Hm, I'm not I understand what you mean: the CESA engine is supporting hardware HMAC. What makes you think I'm doing the HMAC operation in software (I guess I haven't properly filled the ahash_alg structure :-)) ? Nevermind, I

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Herbert Xu
On Fri, May 22, 2015 at 03:33:48PM +0200, Boris Brezillon wrote: +static int mv_cesa_sha1_export(struct ahash_request *req, void *out) +{ + struct sha1_state *out_state = out; + struct crypto_ahash *ahash = crypto_ahash_reqtfm(req); + struct mv_cesa_ahash_req *creq =

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Imre Kaloz
Hi Boris, On Mon, 25 May 2015 13:08:12 +0200, Boris Brezillon boris.brezil...@free-electrons.com wrote: Yep, I noticed that after submitting this version. I guess I only needed the import function for my test cases and thus forgot to implement the import function. Anyway, I just added

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Boris Brezillon
On Mon, 25 May 2015 13:13:43 +0200 Imre Kaloz ka...@openwrt.org wrote: Hi Boris, On Mon, 25 May 2015 13:08:12 +0200, Boris Brezillon boris.brezil...@free-electrons.com wrote: Yep, I noticed that after submitting this version. I guess I only needed the import function for my test

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Boris Brezillon
Hi Imre, On Mon, 25 May 2015 12:44:44 +0200 Imre Kaloz ka...@openwrt.org wrote: Hi Boris, On Mon, 25 May 2015 10:10:16 +0200, Boris Brezillon boris.brezil...@free-electrons.com wrote: snip Yep, I noticed that after submitting this version. I guess I only needed the import

Re: [PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-25 Thread Imre Kaloz
Hi Boris, On Mon, 25 May 2015 10:10:16 +0200, Boris Brezillon boris.brezil...@free-electrons.com wrote: snip Yep, I noticed that after submitting this version. I guess I only needed the import function for my test cases and thus forgot to implement the import function. Anyway, I just added

[PATCH v3 02/16] crypto: add a new driver for Marvell's CESA

2015-05-22 Thread Boris Brezillon
The existing mv_cesa driver supports some features of the CESA IP but is quite limited, and reworking it to support new features (like involving the TDMA engine to offload the CPU) is almost impossible. This driver has been rewritten from scratch to take those new features into account. This