Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-10 Thread Marek Vasut
On Thursday, July 10, 2014 at 01:05:39 AM, Dmitry Kasatkin wrote: On 10 July 2014 00:00, Marek Vasut ma...@denx.de wrote: On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: [...] Right, but my concern is not about unloading the kernel module, but about the IMA module

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-10 Thread Dmitry Kasatkin
On 10/07/14 11:02, Marek Vasut wrote: On Thursday, July 10, 2014 at 01:05:39 AM, Dmitry Kasatkin wrote: On 10 July 2014 00:00, Marek Vasut ma...@denx.de wrote: On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: [...] Right, but my concern is not about unloading the kernel

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-10 Thread Marek Vasut
On Thursday, July 10, 2014 at 01:18:41 PM, Dmitry Kasatkin wrote: [...] All right, that was my understanding of the entire discussion -- an accelerator dying mid-way and what will IMA do about that. But as we fallback to early allocated shash, which is not USB yet, then there is no

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-09 Thread Marek Vasut
On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: [...] Right, but my concern is not about unloading the kernel module, but about the IMA module parameters left initialized. The existing code will continue using ahash (software version), even though the kernel module was

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-09 Thread Dmitry Kasatkin
On 10 July 2014 00:00, Marek Vasut ma...@denx.de wrote: On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: [...] Right, but my concern is not about unloading the kernel module, but about the IMA module parameters left initialized. The existing code will continue using ahash

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-07 Thread Mimi Zohar
On Fri, 2014-07-04 at 15:05 +0300, Dmitry Kasatkin wrote: Async hash API allows to use HW acceleration for hash calculation. It may give significant performance gain or/and reduce power consumption, which might be very beneficial for battery powered devices. This patch introduces hash

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-07 Thread Dmitry Kasatkin
On 07/07/14 14:56, Mimi Zohar wrote: On Fri, 2014-07-04 at 15:05 +0300, Dmitry Kasatkin wrote: Async hash API allows to use HW acceleration for hash calculation. It may give significant performance gain or/and reduce power consumption, which might be very beneficial for battery powered

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-07 Thread Mimi Zohar
On Mon, 2014-07-07 at 16:37 +0300, Dmitry Kasatkin wrote: On 07/07/14 14:56, Mimi Zohar wrote: On Fri, 2014-07-04 at 15:05 +0300, Dmitry Kasatkin wrote: +/** This is the kernel-doc delimiter. + * ima_calc_file_hash - calculae file hash + * Missing kernel-doc argument

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-07 Thread Dmitry Kasatkin
On 07/07/14 18:44, Mimi Zohar wrote: On Mon, 2014-07-07 at 16:37 +0300, Dmitry Kasatkin wrote: On 07/07/14 14:56, Mimi Zohar wrote: On Fri, 2014-07-04 at 15:05 +0300, Dmitry Kasatkin wrote: +/** This is the kernel-doc delimiter. + * ima_calc_file_hash - calculae file hash + * Missing

Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-07 Thread Mimi Zohar
On Mon, 2014-07-07 at 19:11 +0300, Dmitry Kasatkin wrote: On 07/07/14 18:44, Mimi Zohar wrote: On Mon, 2014-07-07 at 16:37 +0300, Dmitry Kasatkin wrote: On 07/07/14 14:56, Mimi Zohar wrote: On Fri, 2014-07-04 at 15:05 +0300, Dmitry Kasatkin wrote: +/** This is the kernel-doc

[PATCH v3 1/3] ima: use ahash API for file hash calculation

2014-07-04 Thread Dmitry Kasatkin
Async hash API allows to use HW acceleration for hash calculation. It may give significant performance gain or/and reduce power consumption, which might be very beneficial for battery powered devices. This patch introduces hash calculation using ahash API. ahash performance depends on data size