Re: [PATCH v3 3/3] crypto: add basic driver for the MXC SCC

2016-03-11 Thread Herbert Xu
On Mon, Mar 07, 2016 at 01:00:05PM +0100, Steffen Trumtrar wrote: > > + if (ctx->ctrl & SCC_SCM_CTRL_CBC_MODE && req->info) > + memcpy(scc->base + SCC_SCM_INIT_VECTOR_0, req->info, > +scc->block_size_bytes); Please ensure that the IV is copied back on exit. I

[PATCH v3 3/3] crypto: add basic driver for the MXC SCC

2016-03-07 Thread Steffen Trumtrar
According to the Freescale GPL driver code, there are two different Security Controller (SCC) versions: SCC and SCC2. The SCC is found on older i.MX SoCs, e.g. the i.MX25. This is the version implemented and tested here. As there is no publicly available documentation for this IP core, all