Re: [RFC] consider keysize in algorithm selection

2007-10-11 Thread Sebastian Siewior
* Herbert Xu | 2007-10-11 19:47:00 [+0800]: I'm not quite happy with adding keysize to the core API though. At some point I'd like to see the DMA operations folded into the API as well so having a key is going to be far from universal. ACK In fact the compression operation is an existing example

Re: [RFC] consider keysize in algorithm selection

2007-10-11 Thread Herbert Xu
On Thu, Oct 11, 2007 at 03:28:48PM +0200, Sebastian Siewior wrote: It is possible that future machines will support 192 and 256 key sizes as well but what do I know, I don't work there :) Anyway even if they support all key sizes at later time you have still those who don't. On the other hand

Re: [RFC] consider keysize in algorithm selection

2007-10-11 Thread Herbert Xu
On Thu, Oct 11, 2007 at 02:43:14PM +0200, Sebastian Siewior wrote: In other words, let's make geode-aes use the padlock-sha method and just fall back to a lower-priority AES algorithm if it sees a key size that it can't handle. geode and s390 :) Are you sure about s390? I can't find a key

[RFC] consider keysize in algorithm selection

2007-10-10 Thread Sebastian Siewior
Hello Herbert, this is my first attempt. patch 1 - the main patch (touching core api) patch 2 - fixing remaining crypto infrastructure patch 3 - fixing some users Almost all users are easy to fix. The wlan stack allocates the cipher at one time and sets the key at another time. So I don't know