Re: [RFC] tcp md5 use of alloc_percpu

2014-10-24 Thread Herbert Xu
Crestez Dan Leonard wrote: > >> Yep, but the sg stuff does not allow for stack variables. Because of >> possible offloading and DMA, I dont know... > A stack buffer is used in tcp_md5_hash_header to add a tcphdr to the > hash. A quick grep for sg_init_one find a couple of additional instances >

Re: [RFC] tcp md5 use of alloc_percpu

2014-10-22 Thread Crestez Dan Leonard
On 10/22/2014 10:12 PM, Eric Dumazet wrote: On Wed, 2014-10-22 at 21:55 +0300, Crestez Dan Leonard wrote: Hello, It seems that the TCP MD5 feature allocates a percpu struct tcp_md5sig_pool and uses part of that memory for a scratch buffer to do crypto on. Here is the relevant code: static int