Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-04 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 2 Jun 2008 20:41:07 +1000 On Mon, Jun 02, 2008 at 11:33:09AM +0200, Adrian-Ken Rueegsegger wrote: This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Sebastian Siewior
* Adrian-Ken Rueegsegger | 2008-06-01 19:16:18 [+0200]: This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger [EMAIL PROTECTED] ---

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Adrian-Ken Rueegsegger
Sebastian Siewior wrote: * Adrian-Ken Rueegsegger | 2008-06-01 19:16:18 [+0200]: This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger [EMAIL

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Herbert Xu
On Mon, Jun 02, 2008 at 09:02:08AM +0200, Adrian-Ken Rueegsegger wrote: Yes, that would be the other way to do it. Is there a preference or specific reason for renaming the hash algorithm than changing the reference to the algorithm? I think the rmd name is fine. The existing entry in IPsec

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Adrian-Ken Rueegsegger
Herbert Xu wrote: On Mon, Jun 02, 2008 at 09:02:08AM +0200, Adrian-Ken Rueegsegger wrote: Yes, that would be the other way to do it. Is there a preference or specific reason for renaming the hash algorithm than changing the reference to the algorithm? I think the rmd name is fine. The

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Herbert Xu
On Mon, Jun 02, 2008 at 09:09:40AM +0200, Adrian-Ken Rueegsegger wrote: Ok thanks for the clarification. I will resubmit the patch to the addresses you specified. I assume linux-crypto should also be cc'd? Yes please. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

[RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Adrian-Ken Rueegsegger
This patch makes HMAC-RIPEMD-160 usable with IPsec/XFRM. The RIPEMD-160 implementation is currently in the cryptodev-2.6 tree. Since I have no IPsec test setup the patch has not (yet) been tested with IPsec and is thus marked as RFC. I will put together a test environment which will take some

[RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Adrian-Ken Rueegsegger
This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger [EMAIL PROTECTED] --- net/xfrm/xfrm_algo.c |4 ++-- 1 files changed, 2 insertions(+), 2

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-02 Thread Herbert Xu
On Mon, Jun 02, 2008 at 11:33:09AM +0200, Adrian-Ken Rueegsegger wrote: This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger [EMAIL PROTECTED]

[RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Adrian-Ken Rueegsegger
This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger [EMAIL PROTECTED] --- net/xfrm/xfrm_algo.c |4 ++-- 1 files changed, 2 insertions(+), 2

[RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Adrian-Ken Rueegsegger
This patch makes HMAC-RIPEMD-160 usable with IPsec/XFRM. Since I have no IPsec test setup the patch has not (yet) been tested with IPsec and is thus marked as RFC. I will put together a test environment which will take some time. In the meantime it would be great if somebody who already has a

Re: [RFC PATCH] [XFRM] xfrm_algo: correct usage of RIPEMD-160

2008-06-01 Thread Herbert Xu
On Sun, Jun 01, 2008 at 07:16:18PM +0200, Adrian-Ken Rueegsegger wrote: This patch fixes the usage of RIPEMD-160 in xfrm_algo which in turn allows hmac(rmd160) to be used as authentication mechanism in IPsec ESP and AH (see RFC 2857). Signed-off-by: Adrian-Ken Rueegsegger [EMAIL PROTECTED]